public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bi, Dandan" <dandan.bi@intel.com>
To: "Long, Qin" <qin.long@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [patch] CryptoPkg/BaseCryptLib: Make comments consistent with the function
Date: Thu, 10 Nov 2016 08:43:13 +0000	[thread overview]
Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB39657176@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <BF2CCE9263284D428840004653A28B6E515625C6@SHSMSX103.ccr.corp.intel.com>

Yes! I will correct them and send a V2 patch.

Thanks,
Dandan

-----Original Message-----
From: Long, Qin 
Sent: Thursday, November 10, 2016 4:25 PM
To: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org
Subject: RE: [patch] CryptoPkg/BaseCryptLib: Make comments consistent with the function

Dandan,

Could you help to correct the comments in BaseCryptLib.h, which also used the unaligned parameter name? 


Best Regards & Thanks,
LONG, Qin

> -----Original Message-----
> From: Bi, Dandan
> Sent: Thursday, November 10, 2016 3:40 PM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin
> Subject: [patch] CryptoPkg/BaseCryptLib: Make comments consistent with 
> the function
> 
> Cc: Qin Long <qin.long@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c     | 2 +-
>  CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c
> b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c
> index 5d349dc..e17ef29 100644
> --- a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c
> +++ b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c
> @@ -162,11 +162,11 @@ HmacSha256Update (
> 
>    If HmacSha256Context is NULL, then return FALSE.
>    If HashValue is NULL, then return FALSE.
> 
>    @param[in, out]  HmacSha256Context  Pointer to the HMAC-SHA256 
> context.
> -  @param[out]      HashValue          Pointer to a buffer that receives the
> HMAC-SHA256 digest
> +  @param[out]      HmacValue          Pointer to a buffer that receives the
> HMAC-SHA256 digest
>                                        value (32 bytes).
> 
>    @retval TRUE   HMAC-SHA256 digest computation succeeded.
>    @retval FALSE  HMAC-SHA256 digest computation failed.
> 
> diff --git a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c
> b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c
> index 48704e1..35abdda 100644
> --- a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c
> +++ b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c
> @@ -107,11 +107,11 @@ HmacSha256Update (
>    Completes computation of the HMAC-SHA256 digest value.
> 
>    Return FALSE to indicate this interface is not supported.
> 
>    @param[in, out]  HmacSha256Context  Pointer to the HMAC-SHA256 
> context.
> -  @param[out]      HashValue          Pointer to a buffer that receives the
> HMAC-SHA256 digest
> +  @param[out]      HmacValue          Pointer to a buffer that receives the
> HMAC-SHA256 digest
>                                        value (32 bytes).
> 
>    @retval FALSE  This interface is not supported.
> 
>  **/
> --
> 1.9.5.msysgit.1



      reply	other threads:[~2016-11-10  8:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-10  7:40 [patch] CryptoPkg/BaseCryptLib: Make comments consistent with the function Dandan Bi
2016-11-10  7:40 ` [patch] MdeModulePkg/BMMUI: add comments for function parameter Dandan Bi
2016-11-10  7:50   ` Dong, Eric
2016-11-10  7:40 ` [patch] ShellPkg: Fix the coding style issue Dandan Bi
2016-11-10  7:48   ` Ni, Ruiyu
2016-11-10  8:24 ` [patch] CryptoPkg/BaseCryptLib: Make comments consistent with the function Long, Qin
2016-11-10  8:43   ` Bi, Dandan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C0D5C461C9E904E8F62152F6274C0BB39657176@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox