From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 428CA81DB3 for ; Thu, 10 Nov 2016 00:43:13 -0800 (PST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP; 10 Nov 2016 00:43:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,618,1473145200"; d="scan'208";a="1066574885" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 10 Nov 2016 00:43:16 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 10 Nov 2016 00:43:16 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 10 Nov 2016 00:43:15 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.96]) with mapi id 14.03.0248.002; Thu, 10 Nov 2016 16:43:13 +0800 From: "Bi, Dandan" To: "Long, Qin" , "edk2-devel@lists.01.org" Thread-Topic: [patch] CryptoPkg/BaseCryptLib: Make comments consistent with the function Thread-Index: AQHSOyvlIhsslRXht0CP0e1hmfCJEqDR5kGw Date: Thu, 10 Nov 2016 08:43:13 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB39657176@shsmsx102.ccr.corp.intel.com> References: <1478763614-16892-1-git-send-email-dandan.bi@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] CryptoPkg/BaseCryptLib: Make comments consistent with the function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Nov 2016 08:43:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes! I will correct them and send a V2 patch. Thanks, Dandan -----Original Message----- From: Long, Qin=20 Sent: Thursday, November 10, 2016 4:25 PM To: Bi, Dandan ; edk2-devel@lists.01.org Subject: RE: [patch] CryptoPkg/BaseCryptLib: Make comments consistent with = the function Dandan, Could you help to correct the comments in BaseCryptLib.h, which also used t= he unaligned parameter name?=20 Best Regards & Thanks, LONG, Qin > -----Original Message----- > From: Bi, Dandan > Sent: Thursday, November 10, 2016 3:40 PM > To: edk2-devel@lists.01.org > Cc: Long, Qin > Subject: [patch] CryptoPkg/BaseCryptLib: Make comments consistent with=20 > the function >=20 > Cc: Qin Long > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c | 2 +- > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c > b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c > index 5d349dc..e17ef29 100644 > --- a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c > +++ b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c > @@ -162,11 +162,11 @@ HmacSha256Update ( >=20 > If HmacSha256Context is NULL, then return FALSE. > If HashValue is NULL, then return FALSE. >=20 > @param[in, out] HmacSha256Context Pointer to the HMAC-SHA256=20 > context. > - @param[out] HashValue Pointer to a buffer that receives = the > HMAC-SHA256 digest > + @param[out] HmacValue Pointer to a buffer that receives = the > HMAC-SHA256 digest > value (32 bytes). >=20 > @retval TRUE HMAC-SHA256 digest computation succeeded. > @retval FALSE HMAC-SHA256 digest computation failed. >=20 > diff --git a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c > b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c > index 48704e1..35abdda 100644 > --- a/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c > +++ b/CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256Null.c > @@ -107,11 +107,11 @@ HmacSha256Update ( > Completes computation of the HMAC-SHA256 digest value. >=20 > Return FALSE to indicate this interface is not supported. >=20 > @param[in, out] HmacSha256Context Pointer to the HMAC-SHA256=20 > context. > - @param[out] HashValue Pointer to a buffer that receives = the > HMAC-SHA256 digest > + @param[out] HmacValue Pointer to a buffer that receives = the > HMAC-SHA256 digest > value (32 bytes). >=20 > @retval FALSE This interface is not supported. >=20 > **/ > -- > 1.9.5.msysgit.1