public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bi, Dandan" <dandan.bi@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ShellPkg: #ifndef of header files should have postfix underscore
Date: Tue, 15 Nov 2016 02:31:08 +0000	[thread overview]
Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3965D6F0@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20161115015726.168432-1-ruiyu.ni@intel.com>

Reviewed-by: Dandan Bi <dandan.bi@intel.com>

Thanks,
Dandan

-----Original Message-----
From: Ni, Ruiyu 
Sent: Tuesday, November 15, 2016 9:57 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>
Subject: [PATCH] ShellPkg: #ifndef of header files should have postfix underscore

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
---
 ShellPkg/Include/Protocol/EfiShell.h               | 4 ++--
 ShellPkg/Include/Protocol/EfiShellDynamicCommand.h | 4 ++--
 ShellPkg/Include/Protocol/EfiShellParameters.h     | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/ShellPkg/Include/Protocol/EfiShell.h b/ShellPkg/Include/Protocol/EfiShell.h
index 4fb8f23..8e3c2fe 100644
--- a/ShellPkg/Include/Protocol/EfiShell.h
+++ b/ShellPkg/Include/Protocol/EfiShell.h
@@ -13,8 +13,8 @@
 
 **/
 
-#ifndef __EFI_SHELL_PROTOCOL_H__WRAPPER -#define __EFI_SHELL_PROTOCOL_H__WRAPPER
+#ifndef __EFI_SHELL_PROTOCOL_H__WRAPPER__ #define 
+__EFI_SHELL_PROTOCOL_H__WRAPPER__
 
 #include <Protocol/Shell.h>
 
diff --git a/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h b/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h
index 43cb688..50f9398 100644
--- a/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h
+++ b/ShellPkg/Include/Protocol/EfiShellDynamicCommand.h
@@ -13,8 +13,8 @@
 
 **/
 
-#ifndef __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER
-#define __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER
+#ifndef __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER__
+#define __EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL_H__WRAPPER__
 
 #include <Protocol/ShellDynamicCommand.h>
 
diff --git a/ShellPkg/Include/Protocol/EfiShellParameters.h b/ShellPkg/Include/Protocol/EfiShellParameters.h
index ba8bd1a..184b029 100644
--- a/ShellPkg/Include/Protocol/EfiShellParameters.h
+++ b/ShellPkg/Include/Protocol/EfiShellParameters.h
@@ -12,8 +12,8 @@
 
 **/
 
-#ifndef __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER
-#define __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER
+#ifndef __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER__
+#define __EFI_SHELL_PARAMETERS_PROTOCOL_H__WRAPPER__
 
 #include <Protocol/ShellParameters.h>
 
--
2.9.0.windows.1



  reply	other threads:[~2016-11-15  2:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-15  1:57 [PATCH] ShellPkg: #ifndef of header files should have postfix underscore Ruiyu Ni
2016-11-15  2:31 ` Bi, Dandan [this message]
2016-11-15 15:59   ` Carsey, Jaben

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C0D5C461C9E904E8F62152F6274C0BB3965D6F0@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox