From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E3DDB81E85 for ; Mon, 14 Nov 2016 21:28:21 -0800 (PST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP; 14 Nov 2016 21:28:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,640,1473145200"; d="scan'208";a="1059571379" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 14 Nov 2016 21:28:26 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 14 Nov 2016 21:28:25 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.96]) with mapi id 14.03.0248.002; Tue, 15 Nov 2016 13:28:24 +0800 From: "Bi, Dandan" To: "Tian, Feng" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [patch] MdeModulePkg/Emmc: coding style update to not use pointer as boolean Thread-Index: AQHSPv6KQpBkxea+fESzhypEYcSoNKDZg9pg Date: Tue, 15 Nov 2016 05:28:23 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3965D7B0@shsmsx102.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] MdeModulePkg/Emmc: coding style update to not use pointer as boolean X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Nov 2016 05:28:22 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Dandan Bi Thanks, Dandan -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Feng= Tian Sent: Tuesday, November 15, 2016 1:10 PM To: edk2-devel@lists.01.org Cc: Bi, Dandan Subject: [edk2] [patch] MdeModulePkg/Emmc: coding style update to not use p= ointer as boolean Non-Boolean comparisons should use a compare operator. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c b/MdeModulePkg/Bus/S= d/EmmcDxe/EmmcBlockIo.c index fc705e1..80e3d9a 100644 --- a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c +++ b/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c @@ -1,7 +1,7 @@ /** @file The helper functions for BlockIo and BlockIo2 protocol. =20 - Copyright (c) 2015, Intel Corporation. All rights reserved.
+ Copyright (c) 2015 - 2016, Intel Corporation. All rights=20 + reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BS= D License which accompanies this distribution. The full text of the license may b= e found at @@ -901,7 +901,7 @@ EmmcReadWrite ( if (EFI_ERROR (Status)) { return Status; } - DEBUG ((EFI_D_INFO, "Emmc%a(): Part %d Lba 0x%x BlkNo 0x%x Event %p wi= th %r\n", IsRead ? "Read " : "Write", Partition->PartitionType, Lba, BlockN= um, Token ? Token->Event : NULL, Status)); + DEBUG ((EFI_D_INFO, "Emmc%a(): Part %d Lba 0x%x BlkNo 0x%x Event %p=20 + with %r\n", IsRead ? "Read " : "Write", Partition->PartitionType, Lba,=20 + BlockNum, (Token !=3D NULL) ? Token->Event : NULL, Status)); =20 Lba +=3D BlockNum; Buffer =3D (UINT8*)Buffer + BufferSize; -- 2.7.1.windows.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel