From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3619381F08 for ; Thu, 8 Dec 2016 01:26:00 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 08 Dec 2016 01:25:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,318,1477983600"; d="scan'208";a="1096324933" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 08 Dec 2016 01:25:59 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 8 Dec 2016 01:25:58 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 8 Dec 2016 01:25:58 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.37]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0248.002; Thu, 8 Dec 2016 17:25:55 +0800 From: "Bi, Dandan" To: Ard Biesheuvel , "edk2-devel@lists.01.org" , "Ni, Ruiyu" Thread-Topic: [edk2] [PATCH] MdeModulePkg/NonDiscoverablePciDevice: add missing cast and EFIAPI modifiers Thread-Index: AQHSUSuZ4Mvkd+l+vUG0K6pI4wHgI6D9x4Rg Date: Thu, 8 Dec 2016 09:25:54 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB39678AD9@shsmsx102.ccr.corp.intel.com> References: <1481185042-23873-1-git-send-email-ard.biesheuvel@linaro.org> In-Reply-To: <1481185042-23873-1-git-send-email-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg/NonDiscoverablePciDevice: add missing cast and EFIAPI modifiers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Dec 2016 09:26:00 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Dandan Bi -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard = Biesheuvel Sent: Thursday, December 8, 2016 4:17 PM To: edk2-devel@lists.01.org; Ni, Ruiyu Cc: Ard Biesheuvel Subject: [edk2] [PATCH] MdeModulePkg/NonDiscoverablePciDevice: add missing = cast and EFIAPI modifiers Add missing EFIAPI modifiers to the functions that are exposed via the PCI = I/O protocol. At the same time, add a missing UINT8 cast which breaks the build on Visual= Studio. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- Apologies for the breakage. MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceI= o.c | 21 +++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverab= lePciDeviceIo.c b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDisco= verablePciDeviceIo.c index 1e7244a129ae..56482e3353c0 100644 --- a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDe= viceIo.c +++ b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePc +++ iDeviceIo.c @@ -43,7 +43,7 @@ GetBarResource ( return EFI_NOT_FOUND; } =20 - BarIndex -=3D Dev->BarOffset; + BarIndex -=3D (UINT8)Dev->BarOffset; =20 for (Desc =3D Dev->Device->Resources; Desc->Desc !=3D ACPI_END_TAG_DESCRIPTOR; @@ -61,6 +61,7 @@ GetBarRe= source ( =20 STATIC EFI_STATUS +EFIAPI PciIoPollMem ( IN EFI_PCI_IO_PROTOCOL *This, IN EFI_PCI_IO_PROTOCOL_WIDTH Width, @@ -78,6 +79,7 @@ PciIoPollMem ( =20 STATIC EFI_STATUS +EFIAPI PciIoPollIo ( IN EFI_PCI_IO_PROTOCOL *This, IN EFI_PCI_IO_PROTOCOL_WIDTH Width, @@ -95,6 +97,7 @@ PciIoPollIo ( =20 STATIC EFI_STATUS +EFIAPI PciIoMemRW ( IN EFI_PCI_IO_PROTOCOL_WIDTH Width, IN UINTN Count, @@ -145,6 +148,7 @@ PciIoMemRW ( =20 STATIC EFI_STATUS +EFIAPI PciIoMemRead ( IN EFI_PCI_IO_PROTOCOL *This, IN EFI_PCI_IO_PROTOCOL_WIDTH Width, @@ -211,6 +215,7 @@ PciIoMemRead ( =20 STATIC EFI_STATUS +EFIAPI PciIoMemWrite ( IN EFI_PCI_IO_PROTOCOL *This, IN EFI_PCI_IO_PROTOCOL_WIDTH Width, @@ -277,6 +282,7 @@ PciIoMemWrite ( =20 STATIC EFI_STATUS +EFIAPI PciIoIoRead ( IN EFI_PCI_IO_PROTOCOL *This, IN EFI_PCI_IO_PROTOCOL_WIDTH Width, @@ -292,6 +298,7 @@ PciIoIoRead ( =20 STATIC EFI_STATUS +EFIAPI PciIoIoWrite ( IN EFI_PCI_IO_PROTOCOL *This, IN EFI_PCI_IO_PROTOCOL_WIDTH Width, @@ -307,6 +314,7 @@ PciIoIoWrite ( =20 STATIC EFI_STATUS +EFIAPI PciIoPciRead ( IN EFI_PCI_IO_PROTOCOL *This, IN EFI_PCI_IO_PROTOCOL_WIDTH Width, @@ -342,6 +350,7 @@ PciIoPciRead ( =20 STATIC EFI_STATUS +EFIAPI PciIoPciWrite ( IN EFI_PCI_IO_PROTOCOL *This, IN EFI_PCI_IO_PROTOCOL_WIDTH Width, @@ -369,6 +378,7 @@ PciIoPciWrite ( =20 STATIC EFI_STATUS +EFIAPI PciIoCopyMem ( IN EFI_PCI_IO_PROTOCOL *This, IN EFI_PCI_IO_PROTOCOL_WIDTH Width, @@ -385,6 +395,7 @@ PciIoCopyMem ( =20 STATIC EFI_STATUS +EFIAPI CoherentPciIoMap ( IN EFI_PCI_IO_PROTOCOL *This, IN EFI_PCI_IO_PROTOCOL_OPERATION Operation, @@ -450,6 +461,7 @@ CoherentPciIoMap ( =20 STATIC EFI_STATUS +EFIAPI CoherentPciIoUnmap ( IN EFI_PCI_IO_PROTOCOL *This, IN VOID *Mapping @@ -472,6 +484,7 @@ CoherentPciIoUnmap ( =20 STATIC EFI_STATUS +EFIAPI CoherentPciIoAllocateBuffer ( IN EFI_PCI_IO_PROTOCOL *This, IN EFI_ALLOCATE_TYPE Type, @@ -513,6 +526,7 @@ CoherentPciIoAllocateBuffer ( =20 STATIC EFI_STATUS +EFIAPI CoherentPciIoFreeBuffer ( IN EFI_PCI_IO_PROTOCOL *This, IN UINTN Pages, @@ -526,6 +540,7 @@ CoherentPciIoFreeBuffer ( =20 STATIC EFI_STATUS +EFIAPI PciIoFlush ( IN EFI_PCI_IO_PROTOCOL *This ) @@ -535,6 +550,7 @@ PciIoFlush ( =20 STATIC EFI_STATUS +EFIAPI PciIoGetLocation ( IN EFI_PCI_IO_PROTOCOL *This, OUT UINTN *SegmentNumber, @@ -560,6 +576,7 @@ PciIoGetLocation ( =20 STATIC EFI_STATUS +EFIAPI PciIoAttributes ( IN EFI_PCI_IO_PROTOCOL *This, IN EFI_PCI_IO_PROTOCOL_ATTRIBUTE_OPERATION Operation, @@ -616,6 +633,7= @@ PciIoAttributes ( =20 STATIC EFI_STATUS +EFIAPI PciIoGetBarAttributes ( IN EFI_PCI_IO_PROTOCOL *This, IN UINT8 BarIndex, @@ -666,6 +684,7 @@ PciIoGetBarAttributes ( =20 STATIC EFI_STATUS +EFIAPI PciIoSetBarAttributes ( IN EFI_PCI_IO_PROTOCOL *This, IN UINT64 Attributes, -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel