Re: [patch 2/2] MdeModulePkg/NonDiscoverablePciDevice: Make variable definition follow rule

["Bi, Dandan" <dandan.bi@intel.com>]

Hi Ard,

The rule we are talking about here is :
For variable name,  it should be 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters  4 Global variable name should start with a 'g'...etc.
The EDK II C Coding Standards Specification establishes a set of  coding rules, you can refer to it.
We also have codes scan tool  Ecc.exe in edk2-BaseTools-win32 to check the coding style issues.
You can run below commands to run ECC scan: 
ecc -c config.ini -e exception.xml -t directory you want to scan  -r reportresult.csv
such as: ecc -c config.ini -e exception.xml  -t  edk2\MdeModulePkg\Bus\Pci\NonDiscoverablePciDeviceDxe  -r NonDiscoverablePciDeviceDxe.csv
Then you will find some coding style issues list in the NonDiscoverablePciDeviceDxe.csv.


Thanks,
Dandan

-----Original Message-----
From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] 
Sent: Thursday, December 15, 2016 7:41 PM
To: Bi, Dandan <dandan.bi@intel.com>
Cc: edk2-devel@lists.01.org; Ni, Ruiyu <ruiyu.ni@intel.com>
Subject: Re: [patch 2/2] MdeModulePkg/NonDiscoverablePciDevice: Make variable definition follow rule

On 15 December 2016 at 07:11, Dandan Bi <dandan.bi@intel.com> wrote:
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>

I have no objections to this patch, but which rule are we talking about here?

> ---
>  .../Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c  | 2 +-
>  .../Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c   | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git 
> a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciD
> eviceDxe.c 
> b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciD
> eviceDxe.c
> index a868ea2..921225b 100644
> --- 
> a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciD
> eviceDxe.c
> +++ b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable
> +++ PciDeviceDxe.c
> @@ -19,11 +19,11 @@
>  //
>  // We only support the following device types  //  STATIC  CONST 
> EFI_GUID * CONST -SupportedNonDiscoverableDevices [] = {
> +SupportedNonDiscoverableDevices[] = {
>    &gEdkiiNonDiscoverableAhciDeviceGuid,
>    &gEdkiiNonDiscoverableEhciDeviceGuid,
>    &gEdkiiNonDiscoverableNvmeDeviceGuid,
>    &gEdkiiNonDiscoverableOhciDeviceGuid,
>    &gEdkiiNonDiscoverableSdhciDeviceGuid,
> diff --git 
> a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciD
> eviceIo.c 
> b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciD
> eviceIo.c
> index 59b6076..a54313f 100644
> --- 
> a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciD
> eviceIo.c
> +++ b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable
> +++ PciDeviceIo.c
> @@ -913,11 +913,12 @@ PciIoGetBarAttributes (
>    OUT UINT64                         *Supports OPTIONAL,
>    OUT VOID                           **Resources OPTIONAL
>    )
>  {
>    NON_DISCOVERABLE_PCI_DEVICE       *Dev;
> -  EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *Descriptor, *BarDesc;
> +  EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *Descriptor;  
> + EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *BarDesc;
>    EFI_ACPI_END_TAG_DESCRIPTOR       *End;
>    EFI_STATUS                        Status;
>
>    if (Supports == NULL && Resources == NULL) {
>      return EFI_INVALID_PARAMETER;
> --
> 1.9.5.msysgit.1
>