public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bi, Dandan" <dandan.bi@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"Zhang, Chao B" <chao.b.zhang@intel.com>
Subject: Re: [PATCH] SecurityPkg Tcg2ConfigDxe: Typecast to (CHAR8*) as para of AsciiStrSize
Date: Mon, 9 Jan 2017 03:06:45 +0000	[thread overview]
Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3B88BE3F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1483927559-137948-1-git-send-email-star.zeng@intel.com>

Reviewed-by: Dandan Bi <dandan.bi@intel.com>

Thanks,
Dandan

-----Original Message-----
From: Zeng, Star 
Sent: Monday, January 9, 2017 10:06 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>
Subject: [PATCH] SecurityPkg Tcg2ConfigDxe: Typecast to (CHAR8*) as para of AsciiStrSize

Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c | 4 ++--
 SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c
index ad7cd54e6cb0..34828eed7d64 100644
--- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c
+++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c
@@ -90,7 +90,7 @@ InitializeTcg2VersionInfo (
   CopyMem (
     &PcdTcg2PpiVersion,
     PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer),
-    AsciiStrSize (PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer))
+    AsciiStrSize ((CHAR8 *) PcdGetPtr 
+ (PcdTcgPhysicalPresenceInterfaceVer))
     );
 
   //
@@ -188,7 +188,7 @@ InitializeTcg2VersionInfo (
   CopyMem (
     &PcdTcg2PpiVersion,
     PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer),
-    AsciiStrSize (PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer))
+    AsciiStrSize ((CHAR8 *) PcdGetPtr 
+ (PcdTcgPhysicalPresenceInterfaceVer))
     );
   if (PcdTcg2PpiVersion != Tcg2Version.PpiVersion) {
     DEBUG ((DEBUG_WARN, "WARNING: PcdTcgPhysicalPresenceInterfaceVer is not DynamicHii type and maps to TCG2_VERSION.PpiVersion\n")); diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c
index ecd7ab981a3d..4432daea81b6 100644
--- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c
+++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c
@@ -495,7 +495,7 @@ Tcg2VersionInfoCallback (
     CopyMem (
       &PcdTcg2PpiVersion,
       PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer),
-      AsciiStrSize (PcdGetPtr (PcdTcgPhysicalPresenceInterfaceVer))
+      AsciiStrSize ((CHAR8 *) PcdGetPtr 
+ (PcdTcgPhysicalPresenceInterfaceVer))
       );
     if (PcdTcg2PpiVersion != Value->u64) {
       CreatePopUp (
--
2.7.0.windows.1



      parent reply	other threads:[~2017-01-09  3:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09  2:05 [PATCH] SecurityPkg Tcg2ConfigDxe: Typecast to (CHAR8*) as para of AsciiStrSize Star Zeng
2017-01-09  2:26 ` Zhang, Chao B
2017-01-09  3:06 ` Bi, Dandan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C0D5C461C9E904E8F62152F6274C0BB3B88BE3F@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox