From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5612A81787 for ; Tue, 7 Feb 2017 23:15:21 -0800 (PST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP; 07 Feb 2017 23:15:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="scan'208";a="63179139" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 07 Feb 2017 23:15:20 -0800 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 7 Feb 2017 23:15:20 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 7 Feb 2017 23:15:20 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.88]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0248.002; Wed, 8 Feb 2017 15:15:18 +0800 From: "Bi, Dandan" To: "Justen, Jordan L" , "edk2-devel@lists.01.org" CC: Laszlo Ersek , "Gao, Liming" Thread-Topic: [edk2] [patch] OvmfPkg/QemuBootOrderLib: Fix NOOPT build failure Thread-Index: AQHSgdA1nVKeLO5IWE2x4zv6I3NvzqFeJQKAgACLrlA= Date: Wed, 8 Feb 2017 07:15:18 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3B894002@shsmsx102.ccr.corp.intel.com> References: <1486533352-214148-1-git-send-email-dandan.bi@intel.com> <148653651702.19501.2422588150276024393@jljusten-ivb> In-Reply-To: <148653651702.19501.2422588150276024393@jljusten-ivb> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] OvmfPkg/QemuBootOrderLib: Fix NOOPT build failure X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Feb 2017 07:15:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jordan, Yes, it fails on IA32. As far as I know, it impacts VS2012/2013/2015.=20 I will create a new patch and add the impacted toolchain and arch info to t= he commit message. Thanks, Dandan -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jord= an Justen Sent: Wednesday, February 8, 2017 2:49 PM To: Bi, Dandan ; edk2-devel@lists.01.org Cc: Laszlo Ersek ; Gao, Liming Subject: Re: [edk2] [patch] OvmfPkg/QemuBootOrderLib: Fix NOOPT build failu= re On 2017-02-07 21:55:52, Dandan Bi wrote: > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > OvmfPkg/Library/QemuBootOrderLib/ExtraRootBusMap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/OvmfPkg/Library/QemuBootOrderLib/ExtraRootBusMap.c=20 > b/OvmfPkg/Library/QemuBootOrderLib/ExtraRootBusMap.c > index ec42214..1bb89d4 100644 > --- a/OvmfPkg/Library/QemuBootOrderLib/ExtraRootBusMap.c > +++ b/OvmfPkg/Library/QemuBootOrderLib/ExtraRootBusMap.c > @@ -306,8 +306,8 @@ MapRootBusPosToBusNr ( > return EFI_INVALID_PARAMETER; > } > if (RootBusPos > ExtraRootBusMap->Count) { > return EFI_NOT_FOUND; > } > - *RootBusNr =3D ExtraRootBusMap->BusNumbers[RootBusPos - 1]; > + *RootBusNr =3D ExtraRootBusMap->BusNumbers[(UINT32)RootBusPos - 1]; Is this failing on IA32? If so, think UINTN would be better. You might also want to add the impacted toolchain and arch to the commit me= ssage. -Jordan _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel