From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AF26321C8F608 for ; Sun, 18 Jun 2017 19:55:43 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 18 Jun 2017 19:57:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,359,1493708400"; d="scan'208";a="1184129472" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 18 Jun 2017 19:57:04 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 18 Jun 2017 19:57:03 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 18 Jun 2017 19:57:03 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.197]) with mapi id 14.03.0319.002; Mon, 19 Jun 2017 10:57:01 +0800 From: "Bi, Dandan" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" Thread-Topic: [patch 3/8] MdeModulePkg: Update comments in SimpleTextInEx according to UEFI 2.7 Thread-Index: AQHS6KWIRVqL0e0DuUatDPz3L0lsFqIrfKAg Date: Mon, 19 Jun 2017 02:57:01 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3B92CEA9@shsmsx102.ccr.corp.intel.com> References: <1497835292-34476-1-git-send-email-dandan.bi@intel.com> <1497835292-34476-4-git-send-email-dandan.bi@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B8E8D8E@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B8E8D8E@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 3/8] MdeModulePkg: Update comments in SimpleTextInEx according to UEFI 2.7 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 02:55:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Star, Yes. That's right. I missed the Ps2KeyboardDxe in MdeModulePkg. I will send new patch to cover this driver. Thank you for your comments.=20 Regards, Dandan -----Original Message----- From: Zeng, Star=20 Sent: Monday, June 19, 2017 10:41 AM To: Bi, Dandan ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Zeng, Star Subject: RE: [patch 3/8] MdeModulePkg: Update comments in SimpleTextInEx ac= cording to UEFI 2.7 Dandan, The change also needs to be in Ps2KeyboardDxe in MdeModulePkg, right? Please double confirm that. Thanks, Star -----Original Message----- From: Bi, Dandan=20 Sent: Monday, June 19, 2017 9:21 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Ni, Ruiyu Subject: [patch 3/8] MdeModulePkg: Update comments in SimpleTextInEx accord= ing to UEFI 2.7 Cc: Star Zeng Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c | 12 ++++++++-= --- MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h | 12 ++++++++-= --- MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 11 +++++++--= -- MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.h | 11 ++++++= +---- MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h | 7 +++++-- MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c | 11 +++++++--= -- 6 files changed, 42 insertions(+), 22 deletions(-) diff --git a/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c b/MdeModulePkg/Bus/Usb/= UsbKbDxe/EfiKey.c index cdd1684..da61ef2 100644 --- a/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c +++ b/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.c @@ -1,10 +1,10 @@ /** @file USB Keyboard Driver that manages USB keyboard and produces Simple Text I= nput Protocol and Simple Text Input Ex Protocol. =20 -Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.
+Copyright (c) 2004 - 2017, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availab= le under the terms and conditions of the BSD License which accompanies thi= s distribution. The full text of the license may be found at http://opens= ource.org/licenses/bsd-license.php =20 @@ -1053,14 +1053,18 @@ USBKeyboardSetState ( =20 /** Register a notification function for a particular keystroke for the inpu= t device. =20 @param This Protocol instance pointer. - @param KeyData A pointer to a buffer that is filled= in with the keystroke - information data for the key that wa= s pressed. + @param KeyData A pointer to a buffer that is filled= in with + the keystroke information for the ke= y that was + pressed.If KeyData.Key, KeyData.KeyS= tate.KeyToggleState + and KeyData.KeyState.KeyShiftState a= re 0, then any incomplete + keystroke will trigger a notificatio= n of the KeyNotificationFunction. @param KeyNotificationFunction Points to the function to be called = when the key - sequence is typed specified by KeyDa= ta. + sequence is typed specified by KeyDa= ta.This notification function + should be called at <=3DTPL_CALLBACK= . @param NotifyHandle Points to the unique handle assigned= to the registered notification. =20 @retval EFI_SUCCESS The notification function was regist= ered successfully. @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for nec= essary data structures. @retval EFI_INVALID_PARAMETER KeyData or NotifyHandle or KeyNotifi= cationFunction is NULL. diff --git a/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h b/MdeModulePkg/Bus/Usb/= UsbKbDxe/EfiKey.h index 089f113..c727c73 100644 --- a/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h +++ b/MdeModulePkg/Bus/Usb/UsbKbDxe/EfiKey.h @@ -1,9 +1,9 @@ /** @file Header file for USB Keyboard Driver's Data Structures. =20 -Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.
+Copyright (c) 2004 - 2017, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availab= le under the terms and conditions of the BSD License which accompanies thi= s distribution. The full text of the license may be found at http://opens= ource.org/licenses/bsd-license.php =20 @@ -500,14 +500,18 @@ USBKeyboardSetState ( =20 /** Register a notification function for a particular keystroke for the inpu= t device. =20 @param This Protocol instance pointer. - @param KeyData A pointer to a buffer that is filled= in with the keystroke - information data for the key that wa= s pressed. + @param KeyData A pointer to a buffer that is filled= in with + the keystroke information for the ke= y that was + pressed.If KeyData.Key, KeyData.KeyS= tate.KeyToggleState + and KeyData.KeyState.KeyShiftState a= re 0, then any incomplete + keystroke will trigger a notificatio= n of the KeyNotificationFunction. @param KeyNotificationFunction Points to the function to be called = when the key - sequence is typed specified by KeyDa= ta. + sequence is typed specified by KeyDa= ta.This notification function + should be called at <=3DTPL_CALLBACK= . @param NotifyHandle Points to the unique handle assigned= to the registered notification. =20 @retval EFI_SUCCESS The notification function was regist= ered successfully. @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for nec= esssary data structures. @retval EFI_INVALID_PARAMETER KeyData or NotifyHandle or KeyNotifi= cationFunction is NULL. diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c b/= MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c index b230f5e..0ebef09 100644 --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c @@ -3840,15 +3840,18 @@ ConSplitterTextInSetState ( =20 /** Register a notification function for a particular keystroke for the inpu= t device. =20 @param This Protocol instance pointer. - @param KeyData A pointer to a buffer that is filled in= with the - keystroke information data for the key = that was - pressed. + @param KeyData A pointer to a buffer that is filled in= with + the keystroke information for the key t= hat was + pressed.If KeyData.Key, KeyData.KeyStat= e.KeyToggleState + and KeyData.KeyState.KeyShiftState are = 0, then any incomplete + keystroke will trigger a notification o= f the KeyNotificationFunction. @param KeyNotificationFunction Points to the function to be called whe= n the key - sequence is typed specified by KeyData. + sequence is typed specified by KeyData.= This notification function + should be called at <=3DTPL_CALLBACK. @param NotifyHandle Points to the unique handle assigned to= the registered notification. =20 @retval EFI_SUCCESS The notification function was registere= d successfully. diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.h b/= MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.h index eeea061..2b79b4b 100644 --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.h +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.h @@ -1394,15 +1394,18 @@ ConSplitterTextInSetState ( =20 /** Register a notification function for a particular keystroke for the inpu= t device. =20 @param This Protocol instance pointer. - @param KeyData A pointer to a buffer that is filled in= with the - keystroke information data for the key = that was - pressed. + @param KeyData A pointer to a buffer that is filled in= with + the keystroke information for the key t= hat was + pressed.If KeyData.Key, KeyData.KeyStat= e.KeyToggleState + and KeyData.KeyState.KeyShiftState are = 0, then any incomplete + keystroke will trigger a notification o= f the KeyNotificationFunction. @param KeyNotificationFunction Points to the function to be called whe= n the key - sequence is typed specified by KeyData. + sequence is typed specified by KeyData.= This notification function + should be called at <=3DTPL_CALLBACK. @param NotifyHandle Points to the unique handle assigned to= the registered notification. =20 @retval EFI_SUCCESS The notification function was registere= d successfully. diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h b/MdeMod= ulePkg/Universal/Console/TerminalDxe/Terminal.h index c15d17c..8c805ea 100644 --- a/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h +++ b/MdeModulePkg/Universal/Console/TerminalDxe/Terminal.h @@ -341,13 +341,16 @@ TerminalConInSetState ( Register a notification function for a particular keystroke for the inpu= t device. =20 @param This Protocol instance pointer. @param KeyData A pointer to a buffer that is filled in= with the keystroke information data for the key = that was - pressed. + pressed.If KeyData.Key, KeyData.KeyStat= e.KeyToggleState + and KeyData.KeyState.KeyShiftState are = 0, then any incomplete + keystroke will trigger a notification o= f the KeyNotificationFunction. @param KeyNotificationFunction Points to the function to be called whe= n the key - sequence is typed specified by KeyData. + sequence is typed specified by KeyData.= This notification function + should be called at <=3DTPL_CALLBACK. @param NotifyHandle Points to the unique handle assigned to= the registered notification. =20 @retval EFI_SUCCESS The notification function was registere= d successfully. diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c b/M= deModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c index 1392f16..6508f26 100644 --- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c +++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c @@ -308,15 +308,18 @@ TerminalConInSetState ( =20 /** Register a notification function for a particular keystroke for the inpu= t device. =20 @param This Protocol instance pointer. - @param KeyData A pointer to a buffer that is filled in= with the - keystroke information data for the key = that was - pressed. + @param KeyData A pointer to a buffer that is filled in= with + the keystroke information for the key t= hat was + pressed.If KeyData.Key, KeyData.KeyStat= e.KeyToggleState + and KeyData.KeyState.KeyShiftState are = 0, then any incomplete + keystroke will trigger a notification o= f the KeyNotificationFunction. @param KeyNotificationFunction Points to the function to be called whe= n the key - sequence is typed specified by KeyData. + sequence is typed specified by KeyData.= This notification function + should be called at <=3DTPL_CALLBACK. @param NotifyHandle Points to the unique handle assigned to= the registered notification. =20 @retval EFI_SUCCESS The notification function was registere= d successfully. -- 1.9.5.msysgit.1