From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0146821C8F618 for ; Sun, 18 Jun 2017 21:57:29 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jun 2017 21:58:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,359,1493708400"; d="scan'208";a="100989281" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 18 Jun 2017 21:58:50 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 18 Jun 2017 21:58:50 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 18 Jun 2017 21:58:49 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.56]) with mapi id 14.03.0319.002; Mon, 19 Jun 2017 12:58:47 +0800 From: "Bi, Dandan" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Gao, Liming" Thread-Topic: [edk2] [PATCH v2 4/8] MdePkg/HiiImageDecoder.h: Remove the unnecessary comments Thread-Index: AQHS6Lcr6xipxZfafE2/lhTjOY9RAqIrGLoAgACGibA= Date: Mon, 19 Jun 2017 04:58:47 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3B92CF5D@shsmsx102.ccr.corp.intel.com> References: <1497847586-18144-1-git-send-email-dandan.bi@intel.com> <1497847586-18144-5-git-send-email-dandan.bi@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B8E8F8F@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B8E8F8F@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 4/8] MdePkg/HiiImageDecoder.h: Remove the unnecessary comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 04:57:30 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes. I will remove it before checking in the codes. Thanks. Regards, Dandan -----Original Message----- From: Zeng, Star=20 Sent: Monday, June 19, 2017 12:55 PM To: Bi, Dandan ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Gao, Liming ; Zen= g, Star Subject: RE: [edk2] [PATCH v2 4/8] MdePkg/HiiImageDecoder.h: Remove the unn= ecessary comments Just found below comments in MdePkg.dec, should it be removed also? ## ## In UEFI 2.6 spec,this guid value is duplicate with ## EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL_GUID. Now update this guid value to ## avoid the duplicate guid issue. So its value is not consistent with ## UEFI spec definition now. We have proposed to update UEFI spec to ## use this new guid. After new spec released, we will remove this ## comments. ## Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Dand= an Bi Sent: Monday, June 19, 2017 12:46 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Gao, Liming Subject: [edk2] [PATCH v2 4/8] MdePkg/HiiImageDecoder.h: Remove the unneces= sary comments Cc: Liming Gao Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdePkg/Include/Protocol/HiiImageDecoder.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/MdePkg/Include/Protocol/HiiImageDecoder.h b/MdePkg/Include/Pro= tocol/HiiImageDecoder.h index 48a1a97..34eb5e1 100644 --- a/MdePkg/Include/Protocol/HiiImageDecoder.h +++ b/MdePkg/Include/Protocol/HiiImageDecoder.h @@ -16,19 +16,10 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITH= ER EXPRESS OR IMPLIED. #ifndef __HII_IMAGE_DECODER_H__ #define __HII_IMAGE_DECODER_H__ =20 #include =20 - -// -// In UEFI 2.6 spec,this guid value is duplicate with -// EFI_PCI_ROOT_BRI= DGE_IO_PROTOCOL_GUID. Now update this guid value to -// avoid the duplicate= guid issue. So its value is not consistent with -// UEFI spec definition n= ow. We have proposed to update UEFI spec to -// use this new guid. After ne= w spec released, we will remove this -// comments. -// #define EFI_HII_IMAGE_DECODER_PROTOCOL_GUID \ {0x9e66f251, 0x727c, 0x418c, { 0xbf, 0xd6, 0xc2, 0xb4, 0x25, 0x28, 0x18,= 0xea }} =20 =20 #define EFI_HII_IMAGE_DECODER_NAME_JPEG_GUID \ -- 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel