From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AACD721CB57A2 for ; Thu, 29 Jun 2017 17:30:32 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jun 2017 17:32:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,283,1496127600"; d="scan'208";a="873255375" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 29 Jun 2017 17:32:05 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 29 Jun 2017 17:32:04 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 29 Jun 2017 17:32:04 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.146]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.197]) with mapi id 14.03.0319.002; Fri, 30 Jun 2017 08:32:02 +0800 From: "Bi, Dandan" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Zeng, Star" Thread-Topic: [edk2] [PATCH] MdeModulePkg ResetSystem: Update the comments of ResetSystem() Thread-Index: AQHS8OZV1UXMCIFKfUGyhmeyVEiOP6I8jeKg Date: Fri, 30 Jun 2017 00:32:02 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3B9317DB@shsmsx102.ccr.corp.intel.com> References: <1498747506-26720-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1498747506-26720-1-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg ResetSystem: Update the comments of ResetSystem() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2017 00:30:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Star, thanks for detecting that. Reviewed-by: Dandan Bi Thanks, Dandan -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Star= Zeng Sent: Thursday, June 29, 2017 10:45 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Bi, Dandan ; Zeng,= Star Subject: [edk2] [PATCH] MdeModulePkg ResetSystem: Update the comments of Re= setSystem() Update the comments of ResetSystem() that was missed by 37078045d717 and 28426918f0ea. Cc: Ruiyu Ni Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c | 3 +++ MdeMo= dulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h | 10 +++++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c b/M= deModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c index f61e65e151ab..ba839eef39b2 100644 --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.c @@ -95,6 +95,9 @@ DoS3 ( valid if ResetStatus is something other th= an EFI_SUCCESS unless the ResetType is EfiResetPlatformSp= ecific where a minimum amount of ResetData is alw= ays required. + For a ResetType of EfiResetPlatformSpecifi= c the data buffer + also starts with a Null-terminated string = that is followed + by an EFI_GUID that describes the specific= type of reset to perform. **/ VOID EFIAPI diff --git a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h b/M= deModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h index c3a2a7f1279a..e007d118e53f 100644 --- a/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h +++ b/MdeModulePkg/Universal/ResetSystemRuntimeDxe/ResetSystem.h @@ -56,10 +56,18 @@ InitializeResetSystem ( =20 @param[in] ResetType The type of reset to perform. @param[in] ResetStatus The status code for the reset. - @param[in] DataSize The size, in bytes, of WatchdogData. + @param[in] DataSize The size, in bytes, of ResetData. @param[in] ResetData For a ResetType of EfiResetCold, EfiResetW= arm, or EfiResetShutdown the data buffer starts wi= th a Null-terminated string, optionally followed by additional = binary data. + The string is a description that the calle= r may use to further + indicate the reason for the system reset. = ResetData is only + valid if ResetStatus is something other th= an EFI_SUCCESS + unless the ResetType is EfiResetPlatformSp= ecific + where a minimum amount of ResetData is alw= ays required. + For a ResetType of EfiResetPlatformSpecifi= c the data buffer + also starts with a Null-terminated string = that is followed + by an EFI_GUID that describes the specific= type of reset to perform. =20 **/ VOID -- 2.7.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel