* [PATCH] IntelFrameworkModulePkg/LegacyBiosDxe: Fix GCC5 build warning
@ 2017-10-12 1:04 Jian J Wang
2017-10-12 2:00 ` Bi, Dandan
0 siblings, 1 reply; 3+ messages in thread
From: Jian J Wang @ 2017-10-12 1:04 UTC (permalink / raw)
To: edk2-devel; +Cc: Laszlo Ersek, Liming Gao, Dandan Bi
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
index f42c13cd89..d249479c56 100644
--- a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
+++ b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
@@ -59,9 +59,6 @@ LegacyBiosInt86 (
{
UINT16 Segment;
UINT16 Offset;
- LEGACY_BIOS_INSTANCE *Private;
-
- Private = LEGACY_BIOS_INSTANCE_FROM_THIS (This);
Regs->X.Flags.Reserved1 = 1;
Regs->X.Flags.Reserved2 = 0;
--
2.14.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] IntelFrameworkModulePkg/LegacyBiosDxe: Fix GCC5 build warning
2017-10-12 1:04 [PATCH] IntelFrameworkModulePkg/LegacyBiosDxe: Fix GCC5 build warning Jian J Wang
@ 2017-10-12 2:00 ` Bi, Dandan
2017-10-12 7:13 ` Laszlo Ersek
0 siblings, 1 reply; 3+ messages in thread
From: Bi, Dandan @ 2017-10-12 2:00 UTC (permalink / raw)
To: Wang, Jian J, edk2-devel@lists.01.org; +Cc: Laszlo Ersek, Gao, Liming
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
-----Original Message-----
From: Wang, Jian J
Sent: Thursday, October 12, 2017 9:04 AM
To: edk2-devel@lists.01.org
Cc: Laszlo Ersek <lersek@redhat.com>; Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>
Subject: [PATCH] IntelFrameworkModulePkg/LegacyBiosDxe: Fix GCC5 build warning
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
index f42c13cd89..d249479c56 100644
--- a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
+++ b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
@@ -59,9 +59,6 @@ LegacyBiosInt86 (
{
UINT16 Segment;
UINT16 Offset;
- LEGACY_BIOS_INSTANCE *Private;
-
- Private = LEGACY_BIOS_INSTANCE_FROM_THIS (This);
Regs->X.Flags.Reserved1 = 1;
Regs->X.Flags.Reserved2 = 0;
--
2.14.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] IntelFrameworkModulePkg/LegacyBiosDxe: Fix GCC5 build warning
2017-10-12 2:00 ` Bi, Dandan
@ 2017-10-12 7:13 ` Laszlo Ersek
0 siblings, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2017-10-12 7:13 UTC (permalink / raw)
To: Bi, Dandan, Wang, Jian J, edk2-devel@lists.01.org; +Cc: Gao, Liming
On 10/12/17 04:00, Bi, Dandan wrote:
> Reviewed-by: Dandan Bi <dandan.bi@intel.com>
>
> -----Original Message-----
> From: Wang, Jian J
> Sent: Thursday, October 12, 2017 9:04 AM
> To: edk2-devel@lists.01.org
> Cc: Laszlo Ersek <lersek@redhat.com>; Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>
> Subject: [PATCH] IntelFrameworkModulePkg/LegacyBiosDxe: Fix GCC5 build warning
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> ---
> IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
> index f42c13cd89..d249479c56 100644
> --- a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
> +++ b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/Thunk.c
> @@ -59,9 +59,6 @@ LegacyBiosInt86 (
> {
> UINT16 Segment;
> UINT16 Offset;
> - LEGACY_BIOS_INSTANCE *Private;
> -
> - Private = LEGACY_BIOS_INSTANCE_FROM_THIS (This);
>
> Regs->X.Flags.Reserved1 = 1;
> Regs->X.Flags.Reserved2 = 0;
>
Looks like this has been committed already; thank you guys for the quick
action!
Laszlo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-12 7:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-12 1:04 [PATCH] IntelFrameworkModulePkg/LegacyBiosDxe: Fix GCC5 build warning Jian J Wang
2017-10-12 2:00 ` Bi, Dandan
2017-10-12 7:13 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox