From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Permerror (SPF Permanent Error: More than 10 MX records returned) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=dandan.bi@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AD1C7220EE104 for ; Tue, 12 Dec 2017 00:45:41 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2017 00:50:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,394,1508828400"; d="scan'208";a="157989420" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 12 Dec 2017 00:50:19 -0800 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 12 Dec 2017 00:50:19 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 12 Dec 2017 00:50:18 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.175]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Tue, 12 Dec 2017 16:50:14 +0800 From: "Bi, Dandan" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" Thread-Topic: [PATCH] MdeModulePkg PiSmmIpl: Add missing update to the prototype Thread-Index: AQHTcyF1vmk2JNdSykyTfCj25h1N+qM/ZaCA Date: Tue, 12 Dec 2017 08:50:14 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3B9DB38D@shsmsx102.ccr.corp.intel.com> References: <1513066550-9912-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1513066550-9912-1-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg PiSmmIpl: Add missing update to the prototype X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 08:45:41 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Dandan Bi Thanks, Dandan -----Original Message----- From: Zeng, Star=20 Sent: Tuesday, December 12, 2017 4:16 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Bi, Dandan ; Yao= , Jiewen Subject: [PATCH] MdeModulePkg PiSmmIpl: Add missing update to the prototype It is missing to update the prototype of SmmCommunicationCommunicate() in d= 1632f694be027dee87dd18fa8172d674221face. This patch is to add it. Cc: Dandan Bi Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c b/MdeModulePkg/Core/PiS= mmCore/PiSmmIpl.c index 31d2c9e45e1f..a7663ca291c4 100644 --- a/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c @@ -90,20 +90,30 @@ SmmBase2GetSmstLocation ( be called in physical mode prior to SetVirtualAddressMap() and in virtua= l mode=20 after SetVirtualAddressMap(). =20 - @param[in] This The EFI_SMM_COMMUNICATION_PROTOCOL in= stance. - @param[in, out] CommBuffer A pointer to the buffer to convey in= to SMRAM. - @param[in, out] CommSize The size of the data buffer being pa= ssed in.On exit, the size of data - being returned. Zero if the handler d= oes not wish to reply with any data. + @param[in] This The EFI_SMM_COMMUNICATION_PROTOCOL instan= ce. + @param[in, out] CommBuffer A pointer to the buffer to convey into SM= RAM. + @param[in, out] CommSize The size of the data buffer being passed = in. On exit, the size of data + being returned. Zero if the handler does = not wish to reply with any data. + This parameter is optional and may be NUL= L. + + @retval EFI_SUCCESS The message was successfully posted. + @retval EFI_INVALID_PARAMETER The CommBuffer was NULL. + @retval EFI_BAD_BUFFER_SIZE The buffer is too large for the MM implem= entation. + If this error is returned, the MessageLen= gth field + in the CommBuffer header or the integer p= ointed by + CommSize, are updated to reflect the maxi= mum payload + size the implementation can accommodate. + @retval EFI_ACCESS_DENIED The CommunicateBuffer parameter or CommSi= ze parameter, + if not omitted, are in address range that= cannot be + accessed by the MM environment. =20 - @retval EFI_SUCCESS The message was successfully posted. - @retval EFI_INVALID_PARAMETER The CommBuffer was NULL. **/ EFI_STATUS EFIAPI SmmCommunicationCommunicate ( IN CONST EFI_SMM_COMMUNICATION_PROTOCOL *This, IN OUT VOID *CommBuffer, - IN OUT UINTN *CommSize + IN OUT UINTN *CommSize OPTIONAL ); =20 /** -- 2.7.0.windows.1