Re: [PATCH 3/4] UefiCpuPkg/UefiCpuPkg.uni: Add missing string definition for new PCDs

["Bi, Dandan" <dandan.bi@intel.com>]

Hi Jian,

Could you add the "string" keyword before the string token when you commit the patch. You can refer to other codes in the uni file.
With this update, Reviewed-by: Dandan Bi <dandan.bi@intel.com>

Thanks,
Dandan
-----Original Message-----
From: Wang, Jian J 
Sent: Monday, December 25, 2017 9:07 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>; Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>
Subject: [PATCH 3/4] UefiCpuPkg/UefiCpuPkg.uni: Add missing string definition for new PCDs

Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
 UefiCpuPkg/UefiCpuPkg.uni | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni index a7073b10c8..6fcfc6e7f2 100644
--- a/UefiCpuPkg/UefiCpuPkg.uni
+++ b/UefiCpuPkg/UefiCpuPkg.uni
@@ -230,5 +230,17 @@
                                                                                         "Processor trace is enabled through set BIT44(CPU_FEATURE_PROC_TRACE) in PcdCpuFeaturesSetting.<BR><BR>\n"
                                                                                         "This PCD is ignored if CPU processor trace is disabled.<BR><BR>\n"
                                                                                         "Default value is 0 which means single range output scheme will be used if CPU processor trace is enabled.<BR>\n"
-                                                                                        "0 - Single Range output scheme.<BR>\n"

-                                                                                        "1 - ToPA(Table of physical address) scheme.<BR>\n"
\ No newline at end of file
+                                                                                        "0 - Single Range output scheme.<BR>\n"
+                                                                                        "1 - ToPA(Table of physical address) scheme.<BR>\n"
+
+#STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuStackSwitchExceptionList_PROMPT  #language en-US "Specify exception vectors which need switching stack."
+
+#STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuStackSwitchExceptionList_HELP  #language en-US "List of exception vectors which need switching stack.\n"
+                                                                                    "This PCD will only take into effect if PcdCpuStackGuard is enabled.n"
+                                                                                    "By default exception #DD(8), #PF(14) are supported.n"
+
+#STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuKnownGoodStackSize_PROMPT  #language en-US "Specify size of good stack of exception which need switching stack."
+
+#STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuKnownGoodStackSize_HELP  #language en-US "Size of good stack for an exception.\n"
+                                                                              "This PCD will only take into effect if PcdCpuStackGuard is enabled.\n"
+
--
2.15.1.windows.2