From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=dandan.bi@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DC59621CB87A7 for ; Sun, 24 Dec 2017 17:54:00 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Dec 2017 17:58:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,452,1508828400"; d="scan'208";a="14373418" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 24 Dec 2017 17:58:52 -0800 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Dec 2017 17:58:52 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 24 Dec 2017 17:58:52 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Mon, 25 Dec 2017 09:58:50 +0800 From: "Bi, Dandan" To: "Wang, Jian J" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , Laszlo Ersek Thread-Topic: [PATCH 3/4] UefiCpuPkg/UefiCpuPkg.uni: Add missing string definition for new PCDs Thread-Index: AQHTfRyv+lNkU2LUhEKUmClJINd5/6NTTIKA Date: Mon, 25 Dec 2017 01:58:50 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3B9F051C@SHSMSX103.ccr.corp.intel.com> References: <20171225010659.13428-1-jian.j.wang@intel.com> <20171225010659.13428-4-jian.j.wang@intel.com> In-Reply-To: <20171225010659.13428-4-jian.j.wang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 3/4] UefiCpuPkg/UefiCpuPkg.uni: Add missing string definition for new PCDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Dec 2017 01:54:01 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jian, Could you add the "string" keyword before the string token when you commit = the patch. You can refer to other codes in the uni file. With this update, Reviewed-by: Dandan Bi Thanks, Dandan -----Original Message----- From: Wang, Jian J=20 Sent: Monday, December 25, 2017 9:07 AM To: edk2-devel@lists.01.org Cc: Bi, Dandan ; Dong, Eric ; Las= zlo Ersek Subject: [PATCH 3/4] UefiCpuPkg/UefiCpuPkg.uni: Add missing string definiti= on for new PCDs Cc: Dandan Bi Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jian J Wang --- UefiCpuPkg/UefiCpuPkg.uni | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni index a7= 073b10c8..6fcfc6e7f2 100644 --- a/UefiCpuPkg/UefiCpuPkg.uni +++ b/UefiCpuPkg/UefiCpuPkg.uni @@ -230,5 +230,17 @@ = "Processor trace is enabled through set BIT44(CPU_FEATURE_PRO= C_TRACE) in PcdCpuFeaturesSetting.

\n" = "This PCD is ignored if CPU processor trace is disabled.
<= BR>\n" = "Default value is 0 which means single range output scheme wi= ll be used if CPU processor trace is enabled.
\n" - = "0 - Single Range output scheme.
\n" - = "1 - ToPA(Table of physical address) scheme.
\n" \ No newline at end of file + = "0 - Single Range output scheme.
\n" + = "1 - ToPA(Table of physical address) scheme.
\n" + +#STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuStackSwitchExceptionList_PROMPT #lan= guage en-US "Specify exception vectors which need switching stack." + +#STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuStackSwitchExceptionList_HELP #langu= age en-US "List of exception vectors which need switching stack.\n" + = "This PCD will only take into effect if PcdCpuStackGuard is enabl= ed.n" + = "By default exception #DD(8), #PF(14) are supported.n" + +#STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuKnownGoodStackSize_PROMPT #language = en-US "Specify size of good stack of exception which need switching stack." + +#STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuKnownGoodStackSize_HELP #language en= -US "Size of good stack for an exception.\n" + = "This PCD will only take into effect if PcdCpuStackGuard is enabled.\n" + -- 2.15.1.windows.2