public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bi, Dandan" <dandan.bi@intel.com>
To: "Wang, Jian J" <jian.j.wang@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zeng, Star" <star.zeng@intel.com>, "Dong, Eric" <eric.dong@intel.com>
Subject: Re: [PATCH 2/4] MdeModulePkg/Core: Coding style clean-up
Date: Mon, 25 Dec 2017 02:01:43 +0000	[thread overview]
Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3B9F0544@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20171225010659.13428-3-jian.j.wang@intel.com>

Reviewed-by: Dandan Bi <dandan.bi@intel.com>

Thanks,
Dandan
-----Original Message-----
From: Wang, Jian J 
Sent: Monday, December 25, 2017 9:07 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>
Subject: [PATCH 2/4] MdeModulePkg/Core: Coding style clean-up

Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
---
 MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c
index bbdfa2bb8e..d7a86c0d30 100644
--- a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c
+++ b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c
@@ -126,6 +126,11 @@ EnableExecuteDisableBit (
   The function will check if page table entry should be splitted to smaller
   granularity.
 
+  @param Address      Physical memory address.
+  @param Size         Size of the given physical memory.
+  @param StackBase    Base address of stack.
+  @param StackSize    Size of stack.
+
   @retval TRUE      Page table should be split.
   @retval FALSE     Page table should not be split.
 **/
-- 
2.15.1.windows.2



  parent reply	other threads:[~2017-12-25  1:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-25  1:06 [PATCH 0/4] Coding style clean-up Jian J Wang
2017-12-25  1:06 ` [PATCH 1/4] MdePkg/BaseLib.h: " Jian J Wang
2017-12-25  1:51   ` Bi, Dandan
2017-12-25  2:23     ` Wang, Jian J
2017-12-25  1:06 ` [PATCH 2/4] MdeModulePkg/Core: " Jian J Wang
2017-12-25  1:19   ` Zeng, Star
2017-12-25  2:01   ` Bi, Dandan [this message]
2017-12-25  1:06 ` [PATCH 3/4] UefiCpuPkg/UefiCpuPkg.uni: Add missing string definition for new PCDs Jian J Wang
2017-12-25  1:58   ` Bi, Dandan
2017-12-25  2:28     ` Wang, Jian J
2017-12-25  1:06 ` [PATCH 4/4] UefiCpuPkg: Update code to use new structure field names Jian J Wang
2017-12-25  2:01   ` Bi, Dandan
2017-12-26 16:47 ` [PATCH 0/4] Coding style clean-up Kinney, Michael D
2017-12-27  0:40   ` Wang, Jian J
2017-12-27  9:29     ` Gao, Liming
2017-12-27 16:35     ` Kinney, Michael D
2017-12-28  0:27       ` Wang, Jian J
2017-12-28  0:37         ` Kinney, Michael D
2017-12-28  0:53           ` Wang, Jian J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C0D5C461C9E904E8F62152F6274C0BB3B9F0544@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox