From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=dandan.bi@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6ED1721E256B6 for ; Wed, 24 Jan 2018 21:46:30 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2018 21:51:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,409,1511856000"; d="scan'208";a="198479439" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 24 Jan 2018 21:51:58 -0800 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Jan 2018 21:51:58 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 24 Jan 2018 21:51:58 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.189]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Thu, 25 Jan 2018 13:51:56 +0800 From: "Bi, Dandan" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , Laszlo Ersek , "Dong, Eric" , "Gao, Liming" Thread-Topic: [edk2] [patch 0/3] Remove the useless pref codes Thread-Index: AQHTlOu6E0f+PG/Trki6skPXWUStiqODgmyAgACN/iA= Date: Thu, 25 Jan 2018 05:51:56 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3BA100FC@shsmsx102.ccr.corp.intel.com> References: <1516780916-6364-1-git-send-email-dandan.bi@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BA02099@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BA02099@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 0/3] Remove the useless pref codes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 05:46:30 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Star, I am not sure. Since these definitions are still used in other packages suc= h as Intelframeworkmodulepkg. If we want to remove them, we must clean up a= ll the old perf related codes in Edk2 code base to avoid build block issues= . Thanks, Dandan -----Original Message----- From: Zeng, Star=20 Sent: Thursday, January 25, 2018 12:59 PM To: Bi, Dandan ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Laszlo Ersek ; Dong,= Eric ; Gao, Liming ; Zeng, Star= Subject: RE: [edk2] [patch 0/3] Remove the useless pref codes Could we also remove the related definitions in MdeModulePkg\Include\Guid\P= erformance.h? // // The data structure for performance data in ACPI memory. // #define PERFORMANCE_SIGNATURE SIGNATURE_32 ('P', 'e', 'r', 'f') #define PERF_TOKEN_SIZE 28 #define PERF_TOKEN_LENGTH (PERF_TOKEN_SIZE - 1) #define PERF_PEI_ENTRY_MAX_NUM 50 #define PERF_DATA_MAX_LENGTH 0x4000 typedef struct { CHAR8 Token[PERF_TOKEN_SIZE]; UINT32 Duration; } PERF_DATA; typedef struct { UINT64 BootToOs; UINT64 S3Resume; UINT32 S3EntryNum; PERF_DATA S3Entry[PERF_PEI_ENTRY_MAX_NUM]; UINT64 CpuFreq; UINT64 BDSRaw; UINT32 Count; UINT32 Signiture; } PERF_HEADER; Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Dand= an Bi Sent: Wednesday, January 24, 2018 4:02 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Zeng, Star ; Laszl= o Ersek ; Dong, Eric ; Gao, Liming = Subject: [edk2] [patch 0/3] Remove the useless pref codes Our new performance infrastructure can support to dump performance date for= m ACPI table in OS. So we can remove the old pref code to write performance= data to OS. Cc: Eric Dong Cc: Laszlo Ersek Cc: Liming Gao Cc: Ruiyu Ni Cc: Star Zeng Dandan Bi (3): UefiCpuPkg/S3Resume: Remove useless pref code MdeModulePkg/BdsDxe: Remove useless Pref Code MdeModulePkg/UefiBootManagerLib: Remove the useless pref codes MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 30 +- .../Library/UefiBootManagerLib/BmPerformance.c | 317 -----------------= ---- .../Library/UefiBootManagerLib/InternalBm.h | 1 - .../UefiBootManagerLib/UefiBootManagerLib.inf | 4 +- MdeModulePkg/Universal/BdsDxe/Bds.h | 3 +- MdeModulePkg/Universal/BdsDxe/BdsDxe.inf | 3 +- MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 57 +--- UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 131 --------- .../Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf | 3 +- 9 files changed, 32 insertions(+), 517 deletions(-) delete mode 100644 Md= eModulePkg/Library/UefiBootManagerLib/BmPerformance.c -- 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel