From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=dandan.bi@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0FD17223972DF for ; Tue, 6 Feb 2018 17:52:35 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2018 17:58:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,471,1511856000"; d="scan'208";a="16100636" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga008.fm.intel.com with ESMTP; 06 Feb 2018 17:58:18 -0800 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 6 Feb 2018 17:58:18 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 6 Feb 2018 17:58:18 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.116]) with mapi id 14.03.0319.002; Wed, 7 Feb 2018 09:58:16 +0800 From: "Bi, Dandan" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Laszlo Ersek (lersek@redhat.com)" Thread-Topic: [patch] MdeModulePkg/PciBusDxe: Fix VS2012 build failure Thread-Index: AQHTn7UzR91yIFTlGU6Ry+RZ8plGVqOYLoEA Date: Wed, 7 Feb 2018 01:58:16 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3BA43A6D@shsmsx102.ccr.corp.intel.com> References: <1517967056-18112-1-git-send-email-dandan.bi@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BA3BB8B@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BA3BB8B@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] MdeModulePkg/PciBusDxe: Fix VS2012 build failure X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 01:52:36 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you star. I will add comment before commit the patch.=20 Regards, Dandan -----Original Message----- From: Zeng, Star=20 Sent: Wednesday, February 7, 2018 9:45 AM To: Bi, Dandan ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Laszlo Ersek (lersek@redhat.com) ; Zeng, Star Subject: RE: [patch] MdeModulePkg/PciBusDxe: Fix VS2012 build failure Reviewed-by: Star Zeng Cc Laszlo. You can add similar comment like 1ea53108f6c1010a00a828d1d59ea28934025415 a= s recommended by https://bugzilla.tianocore.org/show_bug.cgi?id=3D607. Thanks, Star -----Original Message----- From: Bi, Dandan=20 Sent: Wednesday, February 7, 2018 9:31 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Ni, Ruiyu Subject: [patch] MdeModulePkg/PciBusDxe: Fix VS2012 build failure Initialize local variable to suppress warning C4703: potentially uninitialized local pointer variable. Cc: Star Zeng Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Dandan Bi --- MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c b/MdeModulePkg/Bus/Pci= /PciBusDxe/PciBus.c index c48e3bb..13221b9 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c @@ -242,10 +242,12 @@ PciBusDriverBindingStart ( { EFI_STATUS Status; EFI_DEVICE_PATH_PROTOCOL *ParentDevicePath; EFI_PCI_ROOT_BRIDGE_IO_PROTOCOL *PciRootBridgeIo; =20 + PciRootBridgeIo =3D NULL; + // // Check RemainingDevicePath validation // if (RemainingDevicePath !=3D NULL) { // -- 1.9.5.msysgit.1