From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=dandan.bi@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6D1DF223DB786 for ; Fri, 9 Feb 2018 00:37:55 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Feb 2018 00:43:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,482,1511856000"; d="scan'208";a="28674013" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 09 Feb 2018 00:43:40 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 9 Feb 2018 00:43:40 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 9 Feb 2018 00:43:40 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.124]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0319.002; Fri, 9 Feb 2018 16:43:38 +0800 From: "Bi, Dandan" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Dong, Eric" , "Gao, Liming" , Laszlo Ersek , "Wei, David" Thread-Topic: [edk2] [PATCH v2 0/7] Remove the useless pref codes Thread-Index: AQHToXzSI/a1oHes1EOY8+NVOwpC56ObN2qAgACJcYA= Date: Fri, 9 Feb 2018 08:43:38 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3BA46AF5@shsmsx102.ccr.corp.intel.com> References: <1518163522-23144-1-git-send-email-dandan.bi@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BA3E142@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BA3E142@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v2 0/7] Remove the useless pref codes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2018 08:37:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you star. I will update them before committing the patches. Thanks, Dandan -----Original Message----- From: Zeng, Star=20 Sent: Friday, February 9, 2018 4:31 PM To: Bi, Dandan ; edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Dong, Eric ; Gao, = Liming ; Laszlo Ersek ; Wei, David= ; Zeng, Star Subject: RE: [edk2] [PATCH v2 0/7] Remove the useless pref codes Hi Dandan, Two minor comments, with them handled, Reviewed-by: Star Zeng to the patch series. :) 1. Put the first patch to the last patch a= s it is to remove the definition and should be done at last. 2. Fix typo 'pref' to 'perf', and 'new new' to 'new'. Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Dand= an Bi Sent: Friday, February 9, 2018 4:05 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu ; Dong, Eric ; Gao, = Liming ; Laszlo Ersek ; Zeng, Star= ; Wei, David Subject: [edk2] [PATCH v2 0/7] Remove the useless pref codes V2: a. Remove defintions related to old perf code and clean all useless perf co= des in edk2 code base. b.Update commit message. Our new performance infrastructure (edk2 trunk commit hash value: SHA-1: 73fef64f14d1b97ae9bd4705df3becc022391eba ~ SHA-1: 115eae650bfd2be2c2bc37360f4a755065e774c4) can support to dump perfor= mance date form ACPI table in OS. So we can remove the old pref code to wri= te performance data to OS and related definitions. Cc: Star Zeng Cc: Liming Gao Cc: Ruiyu Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: David Wei Cc: Mang Guo Dandan Bi (7): MdeModulePkg/Performance.h: Remove the useless definition UefiCpuPkg/S3Resume: Remove useless pref code MdeModulePkg/BdsDxe: Remove useless Pref Code MdeModulePkg/UefiBootManagerLib: Remove the useless pref codes IntelFrameworkModulePkg/BdsDxe: Remove the useless Perf codes IntelFrameworkModulePkg/GenericBdsLib: Remove the useless Perf codes Vlv2TbltDevicePkg/Override/GenericBdsLib:Remove useless Perf code .../Library/GenericBdsLib/BdsBoot.c | 29 +- .../Library/GenericBdsLib/GenericBdsLib.inf | 4 +- .../Library/GenericBdsLib/InternalBdsLib.h | 19 +- .../Library/GenericBdsLib/Performance.c | 313 -----------------= - IntelFrameworkModulePkg/Universal/BdsDxe/Bds.h | 3 +- .../Universal/BdsDxe/BdsDxe.inf | 3 +- .../Universal/BdsDxe/BdsEntry.c | 57 +--- MdeModulePkg/Include/Guid/Performance.h | 27 +- MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 27 +- .../Library/UefiBootManagerLib/BmPerformance.c | 317 -----------------= - .../Library/UefiBootManagerLib/InternalBm.h | 17 - .../UefiBootManagerLib/UefiBootManagerLib.inf | 4 +- MdeModulePkg/Universal/BdsDxe/Bds.h | 3 +- MdeModulePkg/Universal/BdsDxe/BdsDxe.inf | 3 +- MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 57 +--- UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume.c | 131 -------- .../Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf | 3 +- .../Library/GenericBdsLib/BdsBoot.c | 29 +- .../Library/GenericBdsLib/GenericBdsLib.inf | 4 +- .../Library/GenericBdsLib/InternalBdsLib.h | 19 +- .../Library/GenericBdsLib/Performance.c | 358 -----------------= ---- 21 files changed, 90 insertions(+), 1337 deletions(-) delete mode 100644 = IntelFrameworkModulePkg/Library/GenericBdsLib/Performance.c delete mode 100644 MdeModulePkg/Library/UefiBootManagerLib/BmPerformance.c delete mode 100644 Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Libr= ary/GenericBdsLib/Performance.c -- 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel