From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=dandan.bi@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D619222742A9A for ; Wed, 11 Apr 2018 20:46:37 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2018 20:46:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,439,1517904000"; d="scan'208";a="219762388" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 11 Apr 2018 20:46:36 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 11 Apr 2018 20:46:36 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 11 Apr 2018 20:46:35 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.184]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.239]) with mapi id 14.03.0319.002; Thu, 12 Apr 2018 11:46:34 +0800 From: "Bi, Dandan" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Dong, Eric" , "Gao, Liming" , "Bi, Dandan" Thread-Topic: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu Thread-Index: AQHT0f40w66puzRUtkmQxJuJxKdA2qP71WuAgACc+OCAAAZZwA== Date: Thu, 12 Apr 2018 03:46:32 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3BAA4E2B@shsmsx102.ccr.corp.intel.com> References: <20180412013138.113904-1-dandan.bi@intel.com> <3C0D5C461C9E904E8F62152F6274C0BB3BAA4DFF@shsmsx102.ccr.corp.intel.com> In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB3BAA4DFF@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 03:46:38 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi all, All setup menu enter/exit cases includes: a. UiApp entry point is called and then setup menu is shown = (enter setup menu)=20 b. User select Continue menu in setup menu to exit. = (exit setup menu) c. User select Reset menu in setup page to leave exit. = (exit setup menu) d. User boot from file to exit setup page. = (exit setup menu) e. Exit from boot from file and return to UiApp. = (enter setup menu) f. User boot from boot manager to exit setup page. = (exit setup menu) g. Exit the boot option in boot manager and return to UiApp. = (enter setup menu) I didn't describe it in details in the commit messages. I am sorry that if= it make you confused. I will add them in the commit messages of V2 patches. Thanks, Dandan -----Original Message----- From: Bi, Dandan=20 Sent: Thursday, April 12, 2018 11:17 AM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Dong, Eric ; Gao, Liming ; B= i, Dandan Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter= /exit setup menu Hi Mike, We can't move the enter/exit event signaling into the FormBrowwer SendForm(= ) function. Because we can't decide whether enter/exit setup through SendForm() is call= ed or not. Some examples: 1. SendForm() is not called when exit setup menu and re-enter setup menu. S= uch as, SendForm() is only called when enter front page firstly. But when = go to Boot Manager menu to select an option to boot and exit setup menu, th= en exit the option and return to setup menu, SendForm() is not called in th= is case. 2. SendForm () may be also called more than one time even if we don't leav= e setup menu. Such as, if we want to add an boot option in setup menu, when= choose file to add boot option, SendForm() will be called to show files. B= ut we don't think we leave setup menu in this case. So if we signal setup enter/exit event in SendForm(), may cause less/more n= otifications. Which is not a correct behavior. Thanks, Dandan -----Original Message----- From: Kinney, Michael D Sent: Thursday, April 12, 2018 9:44 AM To: Bi, Dandan ; edk2-devel@lists.01.org; Kinney, Mich= ael D Cc: Dong, Eric ; Gao, Liming Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter= /exit setup menu Dandan Bi, Is it possible to move the enter/exit event signaling into the FormBrowwer = SendForm() function? The current patch set adds these signal calls in all = the places that SendForm() is called and if one of these is missed, a notification will be = missed. Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel- > bounces@lists.01.org] On Behalf Of Dandan Bi > Sent: Wednesday, April 11, 2018 6:32 PM > To: edk2-devel@lists.01.org > Cc: Dong, Eric ; Gao, Liming=20 > > Subject: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when=20 > enter/exit setup menu >=20 > These changes are to support notify callbacks when enter/exit setup=20 > menu, since some driver may need to hook setup enter/exit points to do=20 > something. >=20 > We will signal setup enter/exit events for all setup menu enter/exit=20 > cases.Then the module which pay attention to these events can execute=20 > the callback. >=20 > Cc: Eric Dong > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi >=20 > Dandan Bi (3): > MdeModulePkg/UiApp: Signal event when enter/exit setup menu > MdeModulePkg/BMMUiLib: Signal event when enter/exit setup menu > MdeModulePkg/BMUiLib: Signal event when enter/exit setup menu >=20 > MdeModulePkg/Application/UiApp/FrontPage.c > | 4 +++- >=20 > MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupp > ort.c | 3 ++- > MdeModulePkg/Application/UiApp/UiApp.inf > | 4 +++- >=20 > .../BootMaintenanceManagerUiLib/BootMaintenanceManagerUi > Lib.inf | 4 +++- >=20 > MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOpt > ion.c | 8 +++++++- > MdeModulePkg/Library/BootManagerUiLib/BootManager.c > | 7 ++++++- >=20 > MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.i > nf | 4 +++- > MdeModulePkg/MdeModulePkg.dec > | 6 ++++++ > 8 files changed, 33 insertions(+), 7 deletions(-) >=20 > -- > 2.14.3.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel