[patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

[patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

[Dandan Bi]

These changes are to support notify callbacks when enter/exit
setup menu, since some driver may need to hook setup enter/exit
points to do something.

We will signal setup enter/exit events for all setup menu
enter/exit cases.Then the module which pay attention to these
events can execute the callback.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>

Dandan Bi (3):
  MdeModulePkg/UiApp: Signal event when enter/exit setup menu
  MdeModulePkg/BMMUiLib: Signal event when enter/exit setup menu
  MdeModulePkg/BMUiLib: Signal event when enter/exit setup menu

 MdeModulePkg/Application/UiApp/FrontPage.c                        | 4 +++-
 MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c     | 3 ++-
 MdeModulePkg/Application/UiApp/UiApp.inf                          | 4 +++-
 .../BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf   | 4 +++-
 MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOption.c     | 8 +++++++-
 MdeModulePkg/Library/BootManagerUiLib/BootManager.c               | 7 ++++++-
 MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf        | 4 +++-
 MdeModulePkg/MdeModulePkg.dec                                     | 6 ++++++
 8 files changed, 33 insertions(+), 7 deletions(-)

-- 
2.14.3.windows.1

[patch 1/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

[Dandan Bi]

These changes are to support notify callbacks when enter/exit
setup menu, since some driver may need to hook setup enter/exit
points to do something.

We will signal setup enter/exit events for all setup menu
enter/exit cases.Then the module which pay attention to these
events can execute the callback.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 MdeModulePkg/Application/UiApp/FrontPage.c                    | 4 +++-
 MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c | 3 ++-
 MdeModulePkg/Application/UiApp/UiApp.inf                      | 4 +++-
 MdeModulePkg/MdeModulePkg.dec                                 | 6 ++++++
 4 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c b/MdeModulePkg/Application/UiApp/FrontPage.c
index adee67a8ac1..e5d2cb00c62 100644
--- a/MdeModulePkg/Application/UiApp/FrontPage.c
+++ b/MdeModulePkg/Application/UiApp/FrontPage.c
@@ -1,9 +1,9 @@
 /** @file
   FrontPage routines to handle the callbacks and browser calls
 
-Copyright (c) 2004 - 2017, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
 which accompanies this distribution.  The full text of the license may be found at
 http://opensource.org/licenses/bsd-license.php
 
@@ -992,10 +992,11 @@ UiEntry (
   REPORT_STATUS_CODE (
     EFI_PROGRESS_CODE,
     (EFI_SOFTWARE_DXE_BS_DRIVER | EFI_SW_PC_USER_SETUP)
     );
 
+  EfiEventGroupSignal(&gEdkiiSetupEnterGuid);
   //
   // Indicate if the connect all has been performed before.
   // If has not been performed before, do here.
   //
   if (!ConnectAllHappened) {
@@ -1024,10 +1025,11 @@ UiEntry (
   if (mLanguageString != NULL) {
     FreePool (mLanguageString);
     mLanguageString = NULL;
   }
 
+  EfiEventGroupSignal(&gEdkiiSetupExitGuid);
   //
   //Will leave browser, check any reset required change is applied? if yes, reset system
   //
   SetupResetReminder ();
 }
diff --git a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
index 17fc3db507d..2c5f9d24204 100644
--- a/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
+++ b/MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c
@@ -1,10 +1,10 @@
 /** @file
 
   This library class defines a set of interfaces to customize Ui module
 
-Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials are licensed and made available under
 the terms and conditions of the BSD License that accompanies this distribution.
 The full text of the license may be found at
 http://opensource.org/licenses/bsd-license.php.
 
@@ -232,10 +232,11 @@ UiSupportLibCallbackHandler (
 
     case FRONT_PAGE_KEY_RESET:
       //
       // Reset
       //
+      EfiEventGroupSignal(&gEdkiiSetupExitGuid);
       gRT->ResetSystem (EfiResetCold, EFI_SUCCESS, 0, NULL);
       *Status = EFI_UNSUPPORTED;
 
     default:
       break;
diff --git a/MdeModulePkg/Application/UiApp/UiApp.inf b/MdeModulePkg/Application/UiApp/UiApp.inf
index d144462ce46..c212387e5be 100644
--- a/MdeModulePkg/Application/UiApp/UiApp.inf
+++ b/MdeModulePkg/Application/UiApp/UiApp.inf
@@ -1,9 +1,9 @@
 ## @file
 #  UiApp module is driver for BDS phase.
 #
-#  Copyright (c) 2011 - 2016, Intel Corporation. All rights reserved.<BR>
+#  Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.<BR>
 #  This program and the accompanying materials
 #  are licensed and made available under the terms and conditions of the BSD License
 #  which accompanies this distribution.  The full text of the license may be found at
 #  http://opensource.org/licenses/bsd-license.php
 #  
@@ -62,10 +62,12 @@
   UefiBootManagerLib
   
 [Guids]
   gEfiIfrTianoGuid                              ## CONSUMES ## GUID (Extended IFR Guid Opcode)
   gEfiIfrFrontPageGuid                          ## CONSUMES ## GUID
+  gEdkiiSetupEnterGuid                          ## CONSUMES ## GUID
+  gEdkiiSetupExitGuid                           ## CONSUMES ## GUID
 
 [Protocols]
   gEfiSmbiosProtocolGuid                        ## CONSUMES
   gEfiHiiConfigAccessProtocolGuid               ## CONSUMES
 
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index cc397185f7b..e0bdf5ecdf3 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -407,10 +407,16 @@
   gEdkiiEndOfS3ResumeGuid = { 0x96f5296d, 0x05f7, 0x4f3c, {0x84, 0x67, 0xe4, 0x56, 0x89, 0x0e, 0x0c, 0xb5 } }
 
   ## Include/Guid/S3SmmInitDone.h
   gEdkiiS3SmmInitDoneGuid = { 0x8f9d4825, 0x797d, 0x48fc, { 0x84, 0x71, 0x84, 0x50, 0x25, 0x79, 0x2e, 0xf6 } }
 
+  ## Guid used to create/signal the event of entering Setup.
+  gEdkiiSetupEnterGuid  = { 0xcb9f5b38, 0x1729, 0x4bc0, { 0x87, 0xfe, 0xf7, 0x67, 0x92, 0x56, 0xb6, 0xc5 } }
+
+  ## Guid used to create/signal the event of exiting Setup.
+  gEdkiiSetupExitGuid   = { 0x2729f07f, 0x2f8b, 0x44b2, { 0xb8, 0xc1, 0xc9, 0x8e, 0xcf, 0xba, 0x8d, 0x3f } }
+
 [Ppis]
   ## Include/Ppi/AtaController.h
   gPeiAtaControllerPpiGuid       = { 0xa45e60d1, 0xc719, 0x44aa, { 0xb0, 0x7a, 0xaa, 0x77, 0x7f, 0x85, 0x90, 0x6d }}
 
   ## Include/Ppi/UsbHostController.h
-- 
2.14.3.windows.1

[patch 2/3] MdeModulePkg/BMMUiLib: Signal event when enter/exit setup menu

[Dandan Bi]

These changes are to support notify callbacks when enter/exit
setup menu, since some driver may need to hook setup enter/exit
points to do something.

We will signal setup enter/exit events for all setup menu
enter/exit cases.Then the module which pay attention to these
events can execute the callback.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 .../BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf   | 4 +++-
 MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOption.c     | 8 +++++++-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
index def923b977d..e716e053777 100644
--- a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
+++ b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootMaintenanceManagerUiLib.inf
@@ -1,9 +1,9 @@
 ## @file
 #  Boot Maintenance Manager Library used by UiApp.
 #
-#  Copyright (c) 2011 - 2017, Intel Corporation. All rights reserved.<BR>
+#  Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.<BR>
 #  This program and the accompanying materials are licensed and made available under
 #  the terms and conditions of the BSD License that accompanies this distribution.
 #  The full text of the license may be found at
 #  http://opensource.org/licenses/bsd-license.php.
 #  
@@ -80,10 +80,12 @@
                                                 ## SOMETIMES_CONSUMES ## Variable:L"ConOut" (The device path of console out device)
                                                 ## SOMETIMES_CONSUMES ## Variable:L"ErrOut" (The device path of error out device)
   gEfiIfrTianoGuid                              ## SOMETIMES_CONSUMES ## GUID (Extended IFR Guid Opcode)
   gEfiIfrFrontPageGuid                          ## CONSUMES ## GUID
   gEfiIfrBootMaintenanceGuid                    ## CONSUMES ## GUID
+  gEdkiiSetupEnterGuid                          ## CONSUMES ## GUID
+  gEdkiiSetupExitGuid                           ## CONSUMES ## GUID
  
 [Protocols]
   gEfiSimpleFileSystemProtocolGuid              ## CONSUMES
   gEfiLoadFileProtocolGuid                      ## CONSUMES
   gEfiHiiConfigAccessProtocolGuid               ## CONSUMES
diff --git a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOption.c b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOption.c
index 8680a51d78c..e3363b469ce 100644
--- a/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOption.c
+++ b/MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOption.c
@@ -3,11 +3,11 @@
 
   Include file system navigation, system handle selection
 
   Boot option manipulation
 
-Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
 which accompanies this distribution.  The full text of the license may be found at
 http://opensource.org/licenses/bsd-license.php
 
@@ -926,18 +926,24 @@ BootFromFile (
       );
     //
     // Since current no boot from removable media directly is allowed */
     //
     gST->ConOut->ClearScreen (gST->ConOut);
+
+    //
+    // Signal exit setup event berfore reset the system or boot to another boot option.
+    //
+    EfiEventGroupSignal(&gEdkiiSetupExitGuid);
     //
     // Check whether need to reset system.
     //
     BmmSetupResetReminder ();
 
     BmmSetConsoleMode (FALSE);
     EfiBootManagerBoot (&BootOption);
     BmmSetConsoleMode (TRUE);
+    EfiEventGroupSignal(&gEdkiiSetupEnterGuid);
 
     FreePool(FileName);
 
     EfiBootManagerFreeLoadOption (&BootOption);
   }
-- 
2.14.3.windows.1

[patch 3/3] MdeModulePkg/BMUiLib: Signal event when enter/exit setup menu

[Dandan Bi]

These changes are to support notify callbacks when enter/exit
setup menu, since some driver may need to hook setup enter/exit
points to do something.

We will signal setup enter/exit events for all setup menu
enter/exit cases.Then the module which pay attention to these
events can execute the callback.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
 MdeModulePkg/Library/BootManagerUiLib/BootManager.c        | 7 ++++++-
 MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf | 4 +++-
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Library/BootManagerUiLib/BootManager.c b/MdeModulePkg/Library/BootManagerUiLib/BootManager.c
index 8e776327883..3dd4de06b16 100644
--- a/MdeModulePkg/Library/BootManagerUiLib/BootManager.c
+++ b/MdeModulePkg/Library/BootManagerUiLib/BootManager.c
@@ -1,9 +1,9 @@
 /** @file
   The boot manager reference implementation
 
-Copyright (c) 2004 - 2017, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials are licensed and made available under
 the terms and conditions of the BSD License that accompanies this distribution.
 The full text of the license may be found at
 http://opensource.org/licenses/bsd-license.php.
 
@@ -823,10 +823,14 @@ BootManagerCallback (
   // Clear  the  screen  before.
   //
   gST->ConOut->SetAttribute (gST->ConOut, EFI_TEXT_ATTR (EFI_LIGHTGRAY, EFI_BLACK));
   gST->ConOut->ClearScreen (gST->ConOut);
 
+  //
+  // Signal the exit setup event before reset the system or boot to another boot option.
+  //
+  EfiEventGroupSignal(&gEdkiiSetupExitGuid);
   //
   //check any reset required change is applied? if yes, reset system
   //
   BmSetupResetReminder ();
 
@@ -834,10 +838,11 @@ BootManagerCallback (
   // parse the selected option
   //
   BmSetConsoleMode (FALSE);
   EfiBootManagerBoot (&BootOption[QuestionId - 1]);
   BmSetConsoleMode (TRUE);
+  EfiEventGroupSignal(&gEdkiiSetupEnterGuid);
 
   if (EFI_ERROR (BootOption[QuestionId - 1].Status)) {
     gST->ConOut->OutputString (
                   gST->ConOut,
                   HiiGetString (gBootManagerPrivate.HiiHandle, STRING_TOKEN (STR_ANY_KEY_CONTINUE), NULL)
diff --git a/MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf b/MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
index 7983b079493..dbe99ca7018 100644
--- a/MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
+++ b/MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.inf
@@ -1,9 +1,9 @@
 ## @file
 #  Boot Manager Library used by UiApp.
 #
-#  Copyright (c) 2011 - 2017, Intel Corporation. All rights reserved.<BR>
+#  Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.<BR>
 #  This program and the accompanying materials are licensed and made available under
 #  the terms and conditions of the BSD License that accompanies this distribution.
 #  The full text of the license may be found at
 #  http://opensource.org/licenses/bsd-license.php.
 #  
@@ -50,10 +50,12 @@
   UefiBootManagerLib
 
 [Guids]
   gEfiIfrTianoGuid                              ## CONSUMES ## GUID (Extended IFR Guid Opcode)
   gEfiIfrFrontPageGuid                          ## CONSUMES ## GUID
+  gEdkiiSetupEnterGuid                          ## CONSUMES ## GUID
+  gEdkiiSetupExitGuid                           ## CONSUMES ## GUID
 
 [Protocols]
   gEfiHiiConfigAccessProtocolGuid               ## CONSUMES
   gEfiDevicePathToTextProtocolGuid              ## CONSUMES
   gEdkiiFormBrowserEx2ProtocolGuid              ## CONSUMES
-- 
2.14.3.windows.1

Re: [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

[Kinney, Michael D]

Dandan Bi,

Is it possible to move the enter/exit event signaling
into the FormBrowwer SendForm() function?  The current
patch set adds these signal calls in all the places that
SendForm() is called and if one of these is missed, 
a notification will be missed.

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Dandan Bi
> Sent: Wednesday, April 11, 2018 6:32 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal
> event when enter/exit setup menu
> 
> These changes are to support notify callbacks when
> enter/exit
> setup menu, since some driver may need to hook setup
> enter/exit
> points to do something.
> 
> We will signal setup enter/exit events for all setup
> menu
> enter/exit cases.Then the module which pay attention to
> these
> events can execute the callback.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> 
> Dandan Bi (3):
>   MdeModulePkg/UiApp: Signal event when enter/exit setup
> menu
>   MdeModulePkg/BMMUiLib: Signal event when enter/exit
> setup menu
>   MdeModulePkg/BMUiLib: Signal event when enter/exit
> setup menu
> 
>  MdeModulePkg/Application/UiApp/FrontPage.c
> | 4 +++-
> 
> MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupp
> ort.c     | 3 ++-
>  MdeModulePkg/Application/UiApp/UiApp.inf
> | 4 +++-
> 
> .../BootMaintenanceManagerUiLib/BootMaintenanceManagerUi
> Lib.inf   | 4 +++-
> 
> MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOpt
> ion.c     | 8 +++++++-
>  MdeModulePkg/Library/BootManagerUiLib/BootManager.c
> | 7 ++++++-
> 
> MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.i
> nf        | 4 +++-
>  MdeModulePkg/MdeModulePkg.dec
> | 6 ++++++
>  8 files changed, 33 insertions(+), 7 deletions(-)
> 
> --
> 2.14.3.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

[Bi, Dandan]

Hi Mike,

We can't move the enter/exit event signaling into the FormBrowwer SendForm() function.

Because we can't decide whether enter/exit setup through SendForm() is called or not.  Some examples:

1. SendForm() is not called when exit setup menu and re-enter setup menu. Such as, SendForm() is only called when enter front page firstly. But when  go to Boot Manager menu to select an option to boot and exit setup menu, then exit the option and return to setup menu, SendForm() is not called in this case.

2. SendForm () may be also called more than one time even if we don't  leave setup menu. Such as, if we want to add an boot option in setup menu, when choose file to add boot option, SendForm() will be called to show files. But we don't  think we leave setup menu in this case.

So if we signal setup enter/exit event in SendForm(), may cause less/more notifications. Which is not a correct behavior.


Thanks,
Dandan

-----Original Message-----
From: Kinney, Michael D 
Sent: Thursday, April 12, 2018 9:44 AM
To: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

Dandan Bi,

Is it possible to move the enter/exit event signaling into the FormBrowwer SendForm() function?  The current patch set adds these signal calls in all the places that
SendForm() is called and if one of these is missed, a notification will be missed.

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Dandan Bi
> Sent: Wednesday, April 11, 2018 6:32 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming 
> <liming.gao@intel.com>
> Subject: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when 
> enter/exit setup menu
> 
> These changes are to support notify callbacks when enter/exit setup 
> menu, since some driver may need to hook setup enter/exit points to do 
> something.
> 
> We will signal setup enter/exit events for all setup menu enter/exit 
> cases.Then the module which pay attention to these events can execute 
> the callback.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> 
> Dandan Bi (3):
>   MdeModulePkg/UiApp: Signal event when enter/exit setup menu
>   MdeModulePkg/BMMUiLib: Signal event when enter/exit setup menu
>   MdeModulePkg/BMUiLib: Signal event when enter/exit setup menu
> 
>  MdeModulePkg/Application/UiApp/FrontPage.c
> | 4 +++-
> 
> MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupp
> ort.c     | 3 ++-
>  MdeModulePkg/Application/UiApp/UiApp.inf
> | 4 +++-
> 
> .../BootMaintenanceManagerUiLib/BootMaintenanceManagerUi
> Lib.inf   | 4 +++-
> 
> MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOpt
> ion.c     | 8 +++++++-
>  MdeModulePkg/Library/BootManagerUiLib/BootManager.c
> | 7 ++++++-
> 
> MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.i
> nf        | 4 +++-
>  MdeModulePkg/MdeModulePkg.dec
> | 6 ++++++
>  8 files changed, 33 insertions(+), 7 deletions(-)
> 
> --
> 2.14.3.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

[Bi, Dandan]

Hi all,

All setup menu enter/exit cases includes:
a.	UiApp entry point is called and then setup menu is shown                (enter setup menu) 
b.	User select Continue menu in setup menu to exit.                                (exit setup menu)
c.	User select Reset menu in setup page to leave exit.                             (exit setup menu)
d.	User boot from file to exit setup page.                                                        (exit setup menu)
e.	Exit from boot from file and return to UiApp.                                           (enter setup menu)
f.	User boot from boot manager to exit setup page.                                  (exit setup menu)
g.            Exit the boot option in boot manager and return to UiApp.                (enter setup menu)

I didn't describe it in details in the commit messages.  I am sorry that if it make you confused.
I will add them in the commit messages of V2 patches.


Thanks,
Dandan

-----Original Message-----
From: Bi, Dandan 
Sent: Thursday, April 12, 2018 11:17 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

Hi Mike,

We can't move the enter/exit event signaling into the FormBrowwer SendForm() function.

Because we can't decide whether enter/exit setup through SendForm() is called or not.  Some examples:

1. SendForm() is not called when exit setup menu and re-enter setup menu. Such as, SendForm() is only called when enter front page firstly. But when  go to Boot Manager menu to select an option to boot and exit setup menu, then exit the option and return to setup menu, SendForm() is not called in this case.

2. SendForm () may be also called more than one time even if we don't  leave setup menu. Such as, if we want to add an boot option in setup menu, when choose file to add boot option, SendForm() will be called to show files. But we don't  think we leave setup menu in this case.

So if we signal setup enter/exit event in SendForm(), may cause less/more notifications. Which is not a correct behavior.


Thanks,
Dandan

-----Original Message-----
From: Kinney, Michael D
Sent: Thursday, April 12, 2018 9:44 AM
To: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

Dandan Bi,

Is it possible to move the enter/exit event signaling into the FormBrowwer SendForm() function?  The current patch set adds these signal calls in all the places that
SendForm() is called and if one of these is missed, a notification will be missed.

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Dandan Bi
> Sent: Wednesday, April 11, 2018 6:32 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming 
> <liming.gao@intel.com>
> Subject: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when 
> enter/exit setup menu
> 
> These changes are to support notify callbacks when enter/exit setup 
> menu, since some driver may need to hook setup enter/exit points to do 
> something.
> 
> We will signal setup enter/exit events for all setup menu enter/exit 
> cases.Then the module which pay attention to these events can execute 
> the callback.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> 
> Dandan Bi (3):
>   MdeModulePkg/UiApp: Signal event when enter/exit setup menu
>   MdeModulePkg/BMMUiLib: Signal event when enter/exit setup menu
>   MdeModulePkg/BMUiLib: Signal event when enter/exit setup menu
> 
>  MdeModulePkg/Application/UiApp/FrontPage.c
> | 4 +++-
> 
> MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupp
> ort.c     | 3 ++-
>  MdeModulePkg/Application/UiApp/UiApp.inf
> | 4 +++-
> 
> .../BootMaintenanceManagerUiLib/BootMaintenanceManagerUi
> Lib.inf   | 4 +++-
> 
> MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOpt
> ion.c     | 8 +++++++-
>  MdeModulePkg/Library/BootManagerUiLib/BootManager.c
> | 7 ++++++-
> 
> MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.i
> nf        | 4 +++-
>  MdeModulePkg/MdeModulePkg.dec
> | 6 ++++++
>  8 files changed, 33 insertions(+), 7 deletions(-)
> 
> --
> 2.14.3.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

[Tim Lewis]

This is starting to sound like something that requires a UEFI spec update.
Tim

-----Original Message-----
From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Bi, Dandan
Sent: Wednesday, April 11, 2018 8:47 PM
To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>; Dong, Eric <eric.dong@intel.com>; Gao,
Liming <liming.gao@intel.com>
Subject: Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when
enter/exit setup menu

Hi all,

All setup menu enter/exit cases includes:
a.	UiApp entry point is called and then setup menu is shown
(enter setup menu) 
b.	User select Continue menu in setup menu to exit.
(exit setup menu)
c.	User select Reset menu in setup page to leave exit.
(exit setup menu)
d.	User boot from file to exit setup page.
(exit setup menu)
e.	Exit from boot from file and return to UiApp.
(enter setup menu)
f.	User boot from boot manager to exit setup page.
(exit setup menu)
g.            Exit the boot option in boot manager and return to UiApp.
(enter setup menu)

I didn't describe it in details in the commit messages.  I am sorry that if
it make you confused.
I will add them in the commit messages of V2 patches.


Thanks,
Dandan

-----Original Message-----
From: Bi, Dandan
Sent: Thursday, April 12, 2018 11:17 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>;
Bi, Dandan <dandan.bi@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when
enter/exit setup menu

Hi Mike,

We can't move the enter/exit event signaling into the FormBrowwer SendForm()
function.

Because we can't decide whether enter/exit setup through SendForm() is
called or not.  Some examples:

1. SendForm() is not called when exit setup menu and re-enter setup menu.
Such as, SendForm() is only called when enter front page firstly. But when
go to Boot Manager menu to select an option to boot and exit setup menu,
then exit the option and return to setup menu, SendForm() is not called in
this case.

2. SendForm () may be also called more than one time even if we don't  leave
setup menu. Such as, if we want to add an boot option in setup menu, when
choose file to add boot option, SendForm() will be called to show files. But
we don't  think we leave setup menu in this case.

So if we signal setup enter/exit event in SendForm(), may cause less/more
notifications. Which is not a correct behavior.


Thanks,
Dandan

-----Original Message-----
From: Kinney, Michael D
Sent: Thursday, April 12, 2018 9:44 AM
To: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org; Kinney,
Michael D <michael.d.kinney@intel.com>
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when
enter/exit setup menu

Dandan Bi,

Is it possible to move the enter/exit event signaling into the FormBrowwer
SendForm() function?  The current patch set adds these signal calls in all
the places that
SendForm() is called and if one of these is missed, a notification will be
missed.

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Dandan Bi
> Sent: Wednesday, April 11, 2018 6:32 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming 
> <liming.gao@intel.com>
> Subject: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when 
> enter/exit setup menu
> 
> These changes are to support notify callbacks when enter/exit setup 
> menu, since some driver may need to hook setup enter/exit points to do 
> something.
> 
> We will signal setup enter/exit events for all setup menu enter/exit 
> cases.Then the module which pay attention to these events can execute 
> the callback.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> 
> Dandan Bi (3):
>   MdeModulePkg/UiApp: Signal event when enter/exit setup menu
>   MdeModulePkg/BMMUiLib: Signal event when enter/exit setup menu
>   MdeModulePkg/BMUiLib: Signal event when enter/exit setup menu
> 
>  MdeModulePkg/Application/UiApp/FrontPage.c
> | 4 +++-
> 
> MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupp
> ort.c     | 3 ++-
>  MdeModulePkg/Application/UiApp/UiApp.inf
> | 4 +++-
> 
> .../BootMaintenanceManagerUiLib/BootMaintenanceManagerUi
> Lib.inf   | 4 +++-
> 
> MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOpt
> ion.c     | 8 +++++++-
>  MdeModulePkg/Library/BootManagerUiLib/BootManager.c
> | 7 ++++++-
> 
> MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.i
> nf        | 4 +++-
>  MdeModulePkg/MdeModulePkg.dec
> | 6 ++++++
>  8 files changed, 33 insertions(+), 7 deletions(-)
> 
> --
> 2.14.3.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

[Bi, Dandan]

There is no need to update UEFI spec, just implementation related. It has no impact to the modules which do not care these two events.

Thanks,
Dandan

-----Original Message-----
From: Tim Lewis [mailto:tim.lewis@insyde.com] 
Sent: Thursday, April 12, 2018 11:49 AM
To: Bi, Dandan <dandan.bi@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

This is starting to sound like something that requires a UEFI spec update.
Tim

-----Original Message-----
From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Bi, Dandan
Sent: Wednesday, April 11, 2018 8:47 PM
To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>; Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

Hi all,

All setup menu enter/exit cases includes:
a.	UiApp entry point is called and then setup menu is shown
(enter setup menu) 
b.	User select Continue menu in setup menu to exit.
(exit setup menu)
c.	User select Reset menu in setup page to leave exit.
(exit setup menu)
d.	User boot from file to exit setup page.
(exit setup menu)
e.	Exit from boot from file and return to UiApp.
(enter setup menu)
f.	User boot from boot manager to exit setup page.
(exit setup menu)
g.            Exit the boot option in boot manager and return to UiApp.
(enter setup menu)

I didn't describe it in details in the commit messages.  I am sorry that if it make you confused.
I will add them in the commit messages of V2 patches.


Thanks,
Dandan

-----Original Message-----
From: Bi, Dandan
Sent: Thursday, April 12, 2018 11:17 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

Hi Mike,

We can't move the enter/exit event signaling into the FormBrowwer SendForm() function.

Because we can't decide whether enter/exit setup through SendForm() is called or not.  Some examples:

1. SendForm() is not called when exit setup menu and re-enter setup menu.
Such as, SendForm() is only called when enter front page firstly. But when go to Boot Manager menu to select an option to boot and exit setup menu, then exit the option and return to setup menu, SendForm() is not called in this case.

2. SendForm () may be also called more than one time even if we don't  leave setup menu. Such as, if we want to add an boot option in setup menu, when choose file to add boot option, SendForm() will be called to show files. But we don't  think we leave setup menu in this case.

So if we signal setup enter/exit event in SendForm(), may cause less/more notifications. Which is not a correct behavior.


Thanks,
Dandan

-----Original Message-----
From: Kinney, Michael D
Sent: Thursday, April 12, 2018 9:44 AM
To: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

Dandan Bi,

Is it possible to move the enter/exit event signaling into the FormBrowwer
SendForm() function?  The current patch set adds these signal calls in all the places that
SendForm() is called and if one of these is missed, a notification will be missed.

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Dandan Bi
> Sent: Wednesday, April 11, 2018 6:32 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming 
> <liming.gao@intel.com>
> Subject: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when 
> enter/exit setup menu
> 
> These changes are to support notify callbacks when enter/exit setup 
> menu, since some driver may need to hook setup enter/exit points to do 
> something.
> 
> We will signal setup enter/exit events for all setup menu enter/exit 
> cases.Then the module which pay attention to these events can execute 
> the callback.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> 
> Dandan Bi (3):
>   MdeModulePkg/UiApp: Signal event when enter/exit setup menu
>   MdeModulePkg/BMMUiLib: Signal event when enter/exit setup menu
>   MdeModulePkg/BMUiLib: Signal event when enter/exit setup menu
> 
>  MdeModulePkg/Application/UiApp/FrontPage.c
> | 4 +++-
> 
> MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupp
> ort.c     | 3 ++-
>  MdeModulePkg/Application/UiApp/UiApp.inf
> | 4 +++-
> 
> .../BootMaintenanceManagerUiLib/BootMaintenanceManagerUi
> Lib.inf   | 4 +++-
> 
> MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOpt
> ion.c     | 8 +++++++-
>  MdeModulePkg/Library/BootManagerUiLib/BootManager.c
> | 7 ++++++-
> 
> MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.i
> nf        | 4 +++-
>  MdeModulePkg/MdeModulePkg.dec
> | 6 ++++++
>  8 files changed, 33 insertions(+), 7 deletions(-)
> 
> --
> 2.14.3.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

[Tim Lewis]

If we start to see UEFI drivers that are using this, then it is a spec
issue, because it means that systems which do not implement the event will
not function correctly.

Tim

-----Original Message-----
From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Bi, Dandan
Sent: Wednesday, April 11, 2018 9:53 PM
To: Tim Lewis <tim.lewis@insyde.com>; Kinney, Michael D
<michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>; Dong, Eric <eric.dong@intel.com>; Gao,
Liming <liming.gao@intel.com>
Subject: Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when
enter/exit setup menu

There is no need to update UEFI spec, just implementation related. It has no
impact to the modules which do not care these two events.

Thanks,
Dandan

-----Original Message-----
From: Tim Lewis [mailto:tim.lewis@insyde.com]
Sent: Thursday, April 12, 2018 11:49 AM
To: Bi, Dandan <dandan.bi@intel.com>; Kinney, Michael D
<michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when
enter/exit setup menu

This is starting to sound like something that requires a UEFI spec update.
Tim

-----Original Message-----
From: edk2-devel <edk2-devel-bounces@lists.01.org> On Behalf Of Bi, Dandan
Sent: Wednesday, April 11, 2018 8:47 PM
To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>; Dong, Eric <eric.dong@intel.com>; Gao,
Liming <liming.gao@intel.com>
Subject: Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when
enter/exit setup menu

Hi all,

All setup menu enter/exit cases includes:
a.	UiApp entry point is called and then setup menu is shown
(enter setup menu) 
b.	User select Continue menu in setup menu to exit.
(exit setup menu)
c.	User select Reset menu in setup page to leave exit.
(exit setup menu)
d.	User boot from file to exit setup page.
(exit setup menu)
e.	Exit from boot from file and return to UiApp.
(enter setup menu)
f.	User boot from boot manager to exit setup page.
(exit setup menu)
g.            Exit the boot option in boot manager and return to UiApp.
(enter setup menu)

I didn't describe it in details in the commit messages.  I am sorry that if
it make you confused.
I will add them in the commit messages of V2 patches.


Thanks,
Dandan

-----Original Message-----
From: Bi, Dandan
Sent: Thursday, April 12, 2018 11:17 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>;
Bi, Dandan <dandan.bi@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when
enter/exit setup menu

Hi Mike,

We can't move the enter/exit event signaling into the FormBrowwer SendForm()
function.

Because we can't decide whether enter/exit setup through SendForm() is
called or not.  Some examples:

1. SendForm() is not called when exit setup menu and re-enter setup menu.
Such as, SendForm() is only called when enter front page firstly. But when
go to Boot Manager menu to select an option to boot and exit setup menu,
then exit the option and return to setup menu, SendForm() is not called in
this case.

2. SendForm () may be also called more than one time even if we don't  leave
setup menu. Such as, if we want to add an boot option in setup menu, when
choose file to add boot option, SendForm() will be called to show files. But
we don't  think we leave setup menu in this case.

So if we signal setup enter/exit event in SendForm(), may cause less/more
notifications. Which is not a correct behavior.


Thanks,
Dandan

-----Original Message-----
From: Kinney, Michael D
Sent: Thursday, April 12, 2018 9:44 AM
To: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org; Kinney,
Michael D <michael.d.kinney@intel.com>
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when
enter/exit setup menu

Dandan Bi,

Is it possible to move the enter/exit event signaling into the FormBrowwer
SendForm() function?  The current patch set adds these signal calls in all
the places that
SendForm() is called and if one of these is missed, a notification will be
missed.

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Dandan Bi
> Sent: Wednesday, April 11, 2018 6:32 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming 
> <liming.gao@intel.com>
> Subject: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when 
> enter/exit setup menu
> 
> These changes are to support notify callbacks when enter/exit setup 
> menu, since some driver may need to hook setup enter/exit points to do 
> something.
> 
> We will signal setup enter/exit events for all setup menu enter/exit 
> cases.Then the module which pay attention to these events can execute 
> the callback.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> 
> Dandan Bi (3):
>   MdeModulePkg/UiApp: Signal event when enter/exit setup menu
>   MdeModulePkg/BMMUiLib: Signal event when enter/exit setup menu
>   MdeModulePkg/BMUiLib: Signal event when enter/exit setup menu
> 
>  MdeModulePkg/Application/UiApp/FrontPage.c
> | 4 +++-
> 
> MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupp
> ort.c     | 3 ++-
>  MdeModulePkg/Application/UiApp/UiApp.inf
> | 4 +++-
> 
> .../BootMaintenanceManagerUiLib/BootMaintenanceManagerUi
> Lib.inf   | 4 +++-
> 
> MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOpt
> ion.c     | 8 +++++++-
>  MdeModulePkg/Library/BootManagerUiLib/BootManager.c
> | 7 ++++++-
> 
> MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.i
> nf        | 4 +++-
>  MdeModulePkg/MdeModulePkg.dec
> | 6 ++++++
>  8 files changed, 33 insertions(+), 7 deletions(-)
> 
> --
> 2.14.3.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

[Zeng, Star]

If the cases can be listed completely, then it will be better to also add them in the comments for the two GUIDs, then consumer can easily know them.


Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Bi, Dandan
Sent: Thursday, April 12, 2018 11:47 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>; Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

Hi all,

All setup menu enter/exit cases includes:
a.	UiApp entry point is called and then setup menu is shown                (enter setup menu) 
b.	User select Continue menu in setup menu to exit.                                (exit setup menu)
c.	User select Reset menu in setup page to leave exit.                             (exit setup menu)
d.	User boot from file to exit setup page.                                                        (exit setup menu)
e.	Exit from boot from file and return to UiApp.                                           (enter setup menu)
f.	User boot from boot manager to exit setup page.                                  (exit setup menu)
g.            Exit the boot option in boot manager and return to UiApp.                (enter setup menu)

I didn't describe it in details in the commit messages.  I am sorry that if it make you confused.
I will add them in the commit messages of V2 patches.


Thanks,
Dandan

-----Original Message-----
From: Bi, Dandan
Sent: Thursday, April 12, 2018 11:17 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

Hi Mike,

We can't move the enter/exit event signaling into the FormBrowwer SendForm() function.

Because we can't decide whether enter/exit setup through SendForm() is called or not.  Some examples:

1. SendForm() is not called when exit setup menu and re-enter setup menu. Such as, SendForm() is only called when enter front page firstly. But when  go to Boot Manager menu to select an option to boot and exit setup menu, then exit the option and return to setup menu, SendForm() is not called in this case.

2. SendForm () may be also called more than one time even if we don't  leave setup menu. Such as, if we want to add an boot option in setup menu, when choose file to add boot option, SendForm() will be called to show files. But we don't  think we leave setup menu in this case.

So if we signal setup enter/exit event in SendForm(), may cause less/more notifications. Which is not a correct behavior.


Thanks,
Dandan

-----Original Message-----
From: Kinney, Michael D
Sent: Thursday, April 12, 2018 9:44 AM
To: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

Dandan Bi,

Is it possible to move the enter/exit event signaling into the FormBrowwer SendForm() function?  The current patch set adds these signal calls in all the places that
SendForm() is called and if one of these is missed, a notification will be missed.

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Dandan Bi
> Sent: Wednesday, April 11, 2018 6:32 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming 
> <liming.gao@intel.com>
> Subject: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when 
> enter/exit setup menu
> 
> These changes are to support notify callbacks when enter/exit setup 
> menu, since some driver may need to hook setup enter/exit points to do 
> something.
> 
> We will signal setup enter/exit events for all setup menu enter/exit 
> cases.Then the module which pay attention to these events can execute 
> the callback.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> 
> Dandan Bi (3):
>   MdeModulePkg/UiApp: Signal event when enter/exit setup menu
>   MdeModulePkg/BMMUiLib: Signal event when enter/exit setup menu
>   MdeModulePkg/BMUiLib: Signal event when enter/exit setup menu
> 
>  MdeModulePkg/Application/UiApp/FrontPage.c
> | 4 +++-
> 
> MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupp
> ort.c     | 3 ++-
>  MdeModulePkg/Application/UiApp/UiApp.inf
> | 4 +++-
> 
> .../BootMaintenanceManagerUiLib/BootMaintenanceManagerUi
> Lib.inf   | 4 +++-
> 
> MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOpt
> ion.c     | 8 +++++++-
>  MdeModulePkg/Library/BootManagerUiLib/BootManager.c
> | 7 ++++++-
> 
> MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.i
> nf        | 4 +++-
>  MdeModulePkg/MdeModulePkg.dec
> | 6 ++++++
>  8 files changed, 33 insertions(+), 7 deletions(-)
> 
> --
> 2.14.3.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Re: [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

[Bi, Dandan]

Good suggestion. Thanks Star.
 I will cover them in V2 patches.

Thanks,
Dandan
-----Original Message-----
From: Zeng, Star 
Sent: Thursday, April 12, 2018 2:03 PM
To: Bi, Dandan <dandan.bi@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

If the cases can be listed completely, then it will be better to also add them in the comments for the two GUIDs, then consumer can easily know them.


Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Bi, Dandan
Sent: Thursday, April 12, 2018 11:47 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>; Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

Hi all,

All setup menu enter/exit cases includes:
a.	UiApp entry point is called and then setup menu is shown                (enter setup menu) 
b.	User select Continue menu in setup menu to exit.                                (exit setup menu)
c.	User select Reset menu in setup page to leave exit.                             (exit setup menu)
d.	User boot from file to exit setup page.                                                        (exit setup menu)
e.	Exit from boot from file and return to UiApp.                                           (enter setup menu)
f.	User boot from boot manager to exit setup page.                                  (exit setup menu)
g.            Exit the boot option in boot manager and return to UiApp.                (enter setup menu)

I didn't describe it in details in the commit messages.  I am sorry that if it make you confused.
I will add them in the commit messages of V2 patches.


Thanks,
Dandan

-----Original Message-----
From: Bi, Dandan
Sent: Thursday, April 12, 2018 11:17 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

Hi Mike,

We can't move the enter/exit event signaling into the FormBrowwer SendForm() function.

Because we can't decide whether enter/exit setup through SendForm() is called or not.  Some examples:

1. SendForm() is not called when exit setup menu and re-enter setup menu. Such as, SendForm() is only called when enter front page firstly. But when  go to Boot Manager menu to select an option to boot and exit setup menu, then exit the option and return to setup menu, SendForm() is not called in this case.

2. SendForm () may be also called more than one time even if we don't  leave setup menu. Such as, if we want to add an boot option in setup menu, when choose file to add boot option, SendForm() will be called to show files. But we don't  think we leave setup menu in this case.

So if we signal setup enter/exit event in SendForm(), may cause less/more notifications. Which is not a correct behavior.


Thanks,
Dandan

-----Original Message-----
From: Kinney, Michael D
Sent: Thursday, April 12, 2018 9:44 AM
To: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

Dandan Bi,

Is it possible to move the enter/exit event signaling into the FormBrowwer SendForm() function?  The current patch set adds these signal calls in all the places that
SendForm() is called and if one of these is missed, a notification will be missed.

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Dandan Bi
> Sent: Wednesday, April 11, 2018 6:32 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming 
> <liming.gao@intel.com>
> Subject: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when 
> enter/exit setup menu
> 
> These changes are to support notify callbacks when enter/exit setup 
> menu, since some driver may need to hook setup enter/exit points to do 
> something.
> 
> We will signal setup enter/exit events for all setup menu enter/exit 
> cases.Then the module which pay attention to these events can execute 
> the callback.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> 
> Dandan Bi (3):
>   MdeModulePkg/UiApp: Signal event when enter/exit setup menu
>   MdeModulePkg/BMMUiLib: Signal event when enter/exit setup menu
>   MdeModulePkg/BMUiLib: Signal event when enter/exit setup menu
> 
>  MdeModulePkg/Application/UiApp/FrontPage.c
> | 4 +++-
> 
> MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupp
> ort.c     | 3 ++-
>  MdeModulePkg/Application/UiApp/UiApp.inf
> | 4 +++-
> 
> .../BootMaintenanceManagerUiLib/BootMaintenanceManagerUi
> Lib.inf   | 4 +++-
> 
> MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOpt
> ion.c     | 8 +++++++-
>  MdeModulePkg/Library/BootManagerUiLib/BootManager.c
> | 7 ++++++-
> 
> MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.i
> nf        | 4 +++-
>  MdeModulePkg/MdeModulePkg.dec
> | 6 ++++++
>  8 files changed, 33 insertions(+), 7 deletions(-)
> 
> --
> 2.14.3.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel