Re: [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

["Bi, Dandan" <dandan.bi@intel.com>]

Good suggestion. Thanks Star.
 I will cover them in V2 patches.

Thanks,
Dandan
-----Original Message-----
From: Zeng, Star 
Sent: Thursday, April 12, 2018 2:03 PM
To: Bi, Dandan <dandan.bi@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

If the cases can be listed completely, then it will be better to also add them in the comments for the two GUIDs, then consumer can easily know them.


Thanks,
Star
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Bi, Dandan
Sent: Thursday, April 12, 2018 11:47 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>; Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: Re: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

Hi all,

All setup menu enter/exit cases includes:
a.	UiApp entry point is called and then setup menu is shown                (enter setup menu) 
b.	User select Continue menu in setup menu to exit.                                (exit setup menu)
c.	User select Reset menu in setup page to leave exit.                             (exit setup menu)
d.	User boot from file to exit setup page.                                                        (exit setup menu)
e.	Exit from boot from file and return to UiApp.                                           (enter setup menu)
f.	User boot from boot manager to exit setup page.                                  (exit setup menu)
g.            Exit the boot option in boot manager and return to UiApp.                (enter setup menu)

I didn't describe it in details in the commit messages.  I am sorry that if it make you confused.
I will add them in the commit messages of V2 patches.


Thanks,
Dandan

-----Original Message-----
From: Bi, Dandan
Sent: Thursday, April 12, 2018 11:17 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>; Bi, Dandan <dandan.bi@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

Hi Mike,

We can't move the enter/exit event signaling into the FormBrowwer SendForm() function.

Because we can't decide whether enter/exit setup through SendForm() is called or not.  Some examples:

1. SendForm() is not called when exit setup menu and re-enter setup menu. Such as, SendForm() is only called when enter front page firstly. But when  go to Boot Manager menu to select an option to boot and exit setup menu, then exit the option and return to setup menu, SendForm() is not called in this case.

2. SendForm () may be also called more than one time even if we don't  leave setup menu. Such as, if we want to add an boot option in setup menu, when choose file to add boot option, SendForm() will be called to show files. But we don't  think we leave setup menu in this case.

So if we signal setup enter/exit event in SendForm(), may cause less/more notifications. Which is not a correct behavior.


Thanks,
Dandan

-----Original Message-----
From: Kinney, Michael D
Sent: Thursday, April 12, 2018 9:44 AM
To: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu

Dandan Bi,

Is it possible to move the enter/exit event signaling into the FormBrowwer SendForm() function?  The current patch set adds these signal calls in all the places that
SendForm() is called and if one of these is missed, a notification will be missed.

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Dandan Bi
> Sent: Wednesday, April 11, 2018 6:32 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming 
> <liming.gao@intel.com>
> Subject: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal event when 
> enter/exit setup menu
> 
> These changes are to support notify callbacks when enter/exit setup 
> menu, since some driver may need to hook setup enter/exit points to do 
> something.
> 
> We will signal setup enter/exit events for all setup menu enter/exit 
> cases.Then the module which pay attention to these events can execute 
> the callback.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> 
> Dandan Bi (3):
>   MdeModulePkg/UiApp: Signal event when enter/exit setup menu
>   MdeModulePkg/BMMUiLib: Signal event when enter/exit setup menu
>   MdeModulePkg/BMUiLib: Signal event when enter/exit setup menu
> 
>  MdeModulePkg/Application/UiApp/FrontPage.c
> | 4 +++-
> 
> MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupp
> ort.c     | 3 ++-
>  MdeModulePkg/Application/UiApp/UiApp.inf
> | 4 +++-
> 
> .../BootMaintenanceManagerUiLib/BootMaintenanceManagerUi
> Lib.inf   | 4 +++-
> 
> MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOpt
> ion.c     | 8 +++++++-
>  MdeModulePkg/Library/BootManagerUiLib/BootManager.c
> | 7 ++++++-
> 
> MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.i
> nf        | 4 +++-
>  MdeModulePkg/MdeModulePkg.dec
> | 6 ++++++
>  8 files changed, 33 insertions(+), 7 deletions(-)
> 
> --
> 2.14.3.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel