From: "Bi, Dandan" <dandan.bi@intel.com>
To: "Dong, Eric" <eric.dong@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch 2/2] MdePkg/TcgStorage*.h: Fix ECC reported issues.
Date: Wed, 23 May 2018 01:31:48 +0000 [thread overview]
Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3BAD8C20@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20180522055111.4108-3-eric.dong@intel.com>
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
And these changes are in SecurityPkg not MdePkg.
Please update the package name in the subject of the patch before commit.
Thanks,
Dandan
-----Original Message-----
From: Dong, Eric
Sent: Tuesday, May 22, 2018 1:51 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>
Subject: [Patch 2/2] MdePkg/TcgStorage*.h: Fix ECC reported issues.
Cc: Dandan Bi <dandan.bi@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Eric Dong <eric.dong@intel.com>
---
SecurityPkg/Include/Library/TcgStorageCoreLib.h | 2 +-
SecurityPkg/Include/Library/TcgStorageOpalLib.h | 12 ++++++------
SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c | 2 +-
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/SecurityPkg/Include/Library/TcgStorageCoreLib.h b/SecurityPkg/Include/Library/TcgStorageCoreLib.h
index 97f9a9f968..6e178c968f 100644
--- a/SecurityPkg/Include/Library/TcgStorageCoreLib.h
+++ b/SecurityPkg/Include/Library/TcgStorageCoreLib.h
@@ -2,7 +2,7 @@
Public API for the Tcg Core library to perform the lowest level TCG Data encoding.
(TCG Storage Architecture Core Specification, Version 2.01, Revision 1.00,
- @https://trustedcomputinggroup.org/tcg-storage-architecture-core-specification/)
+ https://trustedcomputinggroup.org/tcg-storage-architecture-core-specification/)
Check http://trustedcomputinggroup.org for latest specification updates.
diff --git a/SecurityPkg/Include/Library/TcgStorageOpalLib.h b/SecurityPkg/Include/Library/TcgStorageOpalLib.h
index b3092eb5cd..33f8fee183 100644
--- a/SecurityPkg/Include/Library/TcgStorageOpalLib.h
+++ b/SecurityPkg/Include/Library/TcgStorageOpalLib.h
@@ -2,22 +2,22 @@
Public API for Opal Core library.
(TCG Storage Architecture Core Specification, Version 2.01, Revision 1.00,
- @https://trustedcomputinggroup.org/tcg-storage-architecture-core-specification/
+ https://trustedcomputinggroup.org/tcg-storage-architecture-core-specification/
Storage Work Group Storage Security Subsystem Class: Pyrite, Version 1.00 Final, Revision 1.00,
- @https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class-pyrite/
+ https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class-pyrite/
Storage Work Group Storage Security Subsystem Class: Opal, Version 2.01 Final, Revision 1.00,
- @https://trustedcomputinggroup.org/storage-work-group-storage-security-subsystem-class-opal/
+ https://trustedcomputinggroup.org/storage-work-group-storage-security-subsystem-class-opal/
TCG Storage Security Subsystem Class: Opalite Version 1.00 Revision 1.00,
- @https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class-opalite/
+ https://trustedcomputinggroup.org/tcg-storage-security-subsystem-class-opalite/
TCG Storage Feature Set: Block SID Authentication, Version 1.00 Final, Revision 1.00,
- @https://trustedcomputinggroup.org/tcg-storage-feature-set-block-sid-authentication-specification/
+ https://trustedcomputinggroup.org/tcg-storage-feature-set-block-sid-authentication-specification/
TCG Storage Opal SSC Feature Set: PSID Version 1.00, Revision 1.00,
- @https://trustedcomputinggroup.org/tcg-storage-opal-feature-set-psid/)
+ https://trustedcomputinggroup.org/tcg-storage-opal-feature-set-psid/)
Check http://trustedcomputinggroup.org for latest specification updates.
diff --git a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c
index a8bf3a9160..ca8e7fbbdf 100644
--- a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c
+++ b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalUtil.c
@@ -981,7 +981,7 @@ OpalUtilGetActiveDataRemovalMechanism (
/**
Calculate the estimated time.
- @param[in] IsMinite Whether the input time value is minute type or second type.
+ @param[in] IsMinute Whether the input time value is minute type or second type.
@param[in] Time The input time value.
**/
--
2.15.0.windows.1
prev parent reply other threads:[~2018-05-23 1:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 5:51 [Patch 0/2] Fix ECC reported issues Eric Dong
2018-05-22 5:51 ` [Patch 1/2] MdePkg/TcgStorage*.h: Fixed " Eric Dong
2018-05-23 1:25 ` Bi, Dandan
2018-05-22 5:51 ` [Patch 2/2] MdePkg/TcgStorage*.h: Fix " Eric Dong
2018-05-23 1:31 ` Bi, Dandan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C0D5C461C9E904E8F62152F6274C0BB3BAD8C20@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox