public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bi, Dandan" <dandan.bi@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] MdeModulePkg/AtaAtapiPassThru: Fix VS2010/VS2012 build failure
Date: Tue, 12 Jun 2018 08:18:02 +0000	[thread overview]
Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3BB2ACF8@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20180611023708.31668-1-ruiyu.ni@intel.com>

Reviewed-by: Dandan Bi <dandan.bi@intel.com>

Thanks,
Dandan

-----Original Message-----
From: Ni, Ruiyu 
Sent: Monday, June 11, 2018 10:37 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>
Subject: [PATCH] MdeModulePkg/AtaAtapiPassThru: Fix VS2010/VS2012 build failure

The patch doesn't have functionality impact. It is just to make
VS2010/VS2012 happy.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
---
 MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
index 1bae1e8e0c..5da5018345 100644
--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
@@ -2381,7 +2381,7 @@ AhciEnableDevSlp (
     //
     // Assume DEVSLP TIMING VARIABLES is not supported if the Identify Device Data log (30h, 8) fails
     //
-    DevSlpTiming.Supported = 0;
+    ZeroMem (&DevSlpTiming, sizeof (DevSlpTiming));
   } else {
     CopyMem (&DevSlpTiming, &LogData[48], sizeof (DevSlpTiming));
     DEBUG ((DEBUG_INFO, "DevSlpTiming: Supported(%d), Deto(%d), Madt(%d)\n",
-- 
2.16.1.windows.1



      reply	other threads:[~2018-06-12  8:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11  2:37 [PATCH] MdeModulePkg/AtaAtapiPassThru: Fix VS2010/VS2012 build failure Ruiyu Ni
2018-06-12  8:18 ` Bi, Dandan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C0D5C461C9E904E8F62152F6274C0BB3BB2ACF8@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox