public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] MdeModulePkg/AtaAtapiPassThru: Fix VS2010/VS2012 build failure
@ 2018-06-11  2:37 Ruiyu Ni
  2018-06-12  8:18 ` Bi, Dandan
  0 siblings, 1 reply; 2+ messages in thread
From: Ruiyu Ni @ 2018-06-11  2:37 UTC (permalink / raw)
  To: edk2-devel; +Cc: Dandan Bi

The patch doesn't have functionality impact. It is just to make
VS2010/VS2012 happy.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
---
 MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
index 1bae1e8e0c..5da5018345 100644
--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
@@ -2381,7 +2381,7 @@ AhciEnableDevSlp (
     //
     // Assume DEVSLP TIMING VARIABLES is not supported if the Identify Device Data log (30h, 8) fails
     //
-    DevSlpTiming.Supported = 0;
+    ZeroMem (&DevSlpTiming, sizeof (DevSlpTiming));
   } else {
     CopyMem (&DevSlpTiming, &LogData[48], sizeof (DevSlpTiming));
     DEBUG ((DEBUG_INFO, "DevSlpTiming: Supported(%d), Deto(%d), Madt(%d)\n",
-- 
2.16.1.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] MdeModulePkg/AtaAtapiPassThru: Fix VS2010/VS2012 build failure
  2018-06-11  2:37 [PATCH] MdeModulePkg/AtaAtapiPassThru: Fix VS2010/VS2012 build failure Ruiyu Ni
@ 2018-06-12  8:18 ` Bi, Dandan
  0 siblings, 0 replies; 2+ messages in thread
From: Bi, Dandan @ 2018-06-12  8:18 UTC (permalink / raw)
  To: Ni, Ruiyu, edk2-devel@lists.01.org

Reviewed-by: Dandan Bi <dandan.bi@intel.com>

Thanks,
Dandan

-----Original Message-----
From: Ni, Ruiyu 
Sent: Monday, June 11, 2018 10:37 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>
Subject: [PATCH] MdeModulePkg/AtaAtapiPassThru: Fix VS2010/VS2012 build failure

The patch doesn't have functionality impact. It is just to make
VS2010/VS2012 happy.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
---
 MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
index 1bae1e8e0c..5da5018345 100644
--- a/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
+++ b/MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AhciMode.c
@@ -2381,7 +2381,7 @@ AhciEnableDevSlp (
     //
     // Assume DEVSLP TIMING VARIABLES is not supported if the Identify Device Data log (30h, 8) fails
     //
-    DevSlpTiming.Supported = 0;
+    ZeroMem (&DevSlpTiming, sizeof (DevSlpTiming));
   } else {
     CopyMem (&DevSlpTiming, &LogData[48], sizeof (DevSlpTiming));
     DEBUG ((DEBUG_INFO, "DevSlpTiming: Supported(%d), Deto(%d), Madt(%d)\n",
-- 
2.16.1.windows.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-06-12  8:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-11  2:37 [PATCH] MdeModulePkg/AtaAtapiPassThru: Fix VS2010/VS2012 build failure Ruiyu Ni
2018-06-12  8:18 ` Bi, Dandan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox