From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=dandan.bi@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6E2DC21109FE9 for ; Tue, 4 Sep 2018 22:06:58 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2018 22:06:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,332,1531810800"; d="scan'208";a="87265081" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 04 Sep 2018 22:06:47 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 4 Sep 2018 22:06:42 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 4 Sep 2018 22:06:42 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0319.002; Wed, 5 Sep 2018 13:06:40 +0800 From: "Bi, Dandan" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Gao, Liming" , "Wang, Jian J" , "Fu, Siyuan" , "Wu, Jiaxin" Thread-Topic: [PATCH] MdeModulePkg: Remove trailing white space Thread-Index: AQHURLxHU7OjiiBqIUiMCIsE45PVcKThItRA Date: Wed, 5 Sep 2018 05:06:39 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3BB71D09@shsmsx102.ccr.corp.intel.com> References: <1536112832-12224-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1536112832-12224-1-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg: Remove trailing white space X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Sep 2018 05:06:58 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Dandan Bi Thanks, Dandan -----Original Message----- From: Zeng, Star=20 Sent: Wednesday, September 5, 2018 10:01 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Bi, Dandan ; Gao= , Liming ; Wang, Jian J ; Fu, = Siyuan ; Wu, Jiaxin Subject: [PATCH] MdeModulePkg: Remove trailing white space REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1144 Cc: Dandan Bi Cc: Liming Gao Cc: Jian J Wang Cc: Siyuan Fu Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- MdeModulePkg/Core/Pei/Ppi/Ppi.c | 4 +-- MdeModulePkg/Include/Library/NetLib.h | 2 +- .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 2 +- MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 4 +-- MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c | 2 +- MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c | 14 +++++----- MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c | 30 +++++++++++-------= ---- 7 files changed, 29 insertions(+), 29 deletions(-) diff --git a/MdeModulePkg/Core/Pei/Ppi/Ppi.c b/MdeModulePkg/Core/Pei/Ppi/Pp= i.c index d8ba2dd42b59..6f03858b8a94 100644 --- a/MdeModulePkg/Core/Pei/Ppi/Ppi.c +++ b/MdeModulePkg/Core/Pei/Ppi/Ppi.c @@ -143,7 +143,7 @@ ConvertPointerInRanges ( =20 Migrate Single PPI Pointer from the temporary memory to PEI installed me= mory. =20 - @param SecCoreData Points to a data structure containing SEC to PEI = handoff data, such as the size=20 + @param SecCoreData Points to a data structure containing SEC to PEI = handoff data, such as the size and location of temporary RAM, the stack location= and the BFV location. @param PrivateData Pointer to PeiCore's private data structure. @param PpiPointer Pointer to Ppi @@ -179,7 +179,7 @@ ConvertSinglePpiPointer ( =20 Migrate PPI Pointers from the temporary memory to PEI installed memory. =20 - @param SecCoreData Points to a data structure containing SEC to PEI = handoff data, such as the size=20 + @param SecCoreData Points to a data structure containing SEC to PEI = handoff data, such as the size and location of temporary RAM, the stack location= and the BFV location. @param PrivateData Pointer to PeiCore's private data structure. =20 diff --git a/MdeModulePkg/Include/Library/NetLib.h b/MdeModulePkg/Include/L= ibrary/NetLib.h index b7ef99c7b568..09779739213e 100644 --- a/MdeModulePkg/Include/Library/NetLib.h +++ b/MdeModulePkg/Include/Library/NetLib.h @@ -424,7 +424,7 @@ NetGetIpClass ( except when the originator is one of the endpoints of a point-to-point l= ink with a 31-bit mask (RFC3021), or a 32bit NetMask (all 0xFF) is used for special networ= k environment (e.g. PPP link). - =20 + @param[in] Ip The IP to check against. @param[in] NetMask The mask of the IP. =20 diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c b/MdeMod= ulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c index 91c6849a4658..20fd29a3a87f 100644 --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c @@ -765,7 +765,7 @@ GetFmpHandleBufferByType ( MatchedHandleBuffer[MatchedNumberOfHandles] =3D HandleBuffer[I= ndex]; } if (MatchedResetRequiredBuffer !=3D NULL) { - MatchedResetRequiredBuffer[MatchedNumberOfHandles] =3D (((Temp= FmpImageInfo->AttributesSupported &=20 + MatchedResetRequiredBuffer[MatchedNumberOfHandles] =3D=20 + (((TempFmpImageInfo->AttributesSupported & IMAGE_ATT= RIBUTE_RESET_REQUIRED) !=3D 0) && ((TempFmp= ImageInfo->AttributesSetting & IMAGE_ATT= RIBUTE_RESET_REQUIRED) !=3D 0)); diff --git a/MdeModulePkg/Library/DxeNetLi= b/DxeNetLib.c b/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c index 63f4724062e9..9e3ea2490928 100644 --- a/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c +++ b/MdeModulePkg/Library/DxeNetLib/DxeNetLib.c @@ -656,7 +656,7 @@ NetGetIpClass ( except when the originator is one of the endpoints of a point-to-point l= ink with a 31-bit mask (RFC3021), or a 32bit NetMask (all 0xFF) is used for special networ= k environment (e.g. PPP link). - =20 + @param[in] Ip The IP to check against. @param[in] NetMask The mask of the IP. =20 @@ -671,7 +671,7 @@ NetIp4IsUnicast ( ) { INTN MaskLength; - =20 + ASSERT (NetMask !=3D 0); =20 if (Ip =3D=3D 0 || IP4_IS_LOCAL_BROADCAST (Ip)) { diff --git a/MdeModule= Pkg/Universal/EsrtFmpDxe/EsrtFmp.c b/MdeModulePkg/Universal/EsrtFmpDxe/Esrt= Fmp.c index 219059760e97..129e90ca11b4 100644 --- a/MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c +++ b/MdeModulePkg/Universal/EsrtFmpDxe/EsrtFmp.c @@ -296,7 +296,7 @@ CreateFmpBasedEsrt ( =20 Table->FwResourceCount =3D 0; Table->FwResourceCountMax =3D GROWTH_STEP; - Table->FwResourceVersion =3D EFI_SYSTEM_RESOURCE_TABLE_FIRMWARE_RESOURC= E_VERSION;=20 + Table->FwResourceVersion =3D=20 + EFI_SYSTEM_RESOURCE_TABLE_FIRMWARE_RESOURCE_VERSION; =20 for (Index =3D 0; Index < NoProtocols; Index++) { Fmp =3D (EFI_FIRMWARE_MANAGEMENT_PROTOCOL *) Buffer[Index]; diff --git= a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c b/MdeModulePkg/Universal/N= etwork/Ip4Dxe/Ip4If.c index 499a486a8b5d..4e3988132d6b 100644 --- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c +++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4If.c @@ -796,14 +796,14 @@ Ip4FreeInterface ( } =20 /** - This function tries to send all the queued frames in ArpQue to the defau= lt gateway if=20 + This function tries to send all the queued frames in ArpQue to the=20 + default gateway if the ARP resolve for direct destination address is failed when using /32 = subnet mask. =20 @param[in] ArpQue The ARP queue of a failed request. - =20 + @retval EFI_SUCCESS All the queued frames have been send to th= e default route. @retval Others Failed to send the queued frames. - =20 + **/ EFI_STATUS Ip4SendFrameToDefaultRoute ( @@ -817,7 +817,7 @@ Ip4SendFrameToDefaultRoute ( IP4_ADDR Gateway; EFI_STATUS Status; IP4_ROUTE_ENTRY *DefaultRoute; - =20 + // // ARP resolve failed when using /32 subnet mask. // @@ -850,7 +850,7 @@ Ip4SendFrameToDefaultRoute ( Gateway =3D DefaultRoute->NextHop; if (ArpQue->Ip =3D=3D Gateway) { // - // ARP resolve for the default route is failed, return error to call= er.=20 + // ARP resolve for the default route is failed, return error to call= er. // Status=3D EFI_NO_MAPPING; goto ON_ERROR; @@ -865,7 +865,7 @@ Ip4SendFrameToDefaultRoute ( } =20 return EFI_SUCCESS; - =20 + ON_ERROR: if (RtCacheEntry !=3D NULL) { Ip4FreeRouteCacheEntry (RtCacheEntry); @@ -905,7 +905,7 @@ Ip4OnArpRes= olvedDpc ( RemoveEntryList (&ArpQue->Link); =20 // - // ARP resolve failed for some reason.=20 + // ARP resolve failed for some reason. // if (NET_MAC_EQUAL (&ArpQue->Mac, &mZeroMacAddress, ArpQue->Interface->Hw= addrLen)) { if (ArpQue->Interface->SubnetMask !=3D IP4_ALLONE_ADDRESS) { diff --gi= t a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c b/MdeModulePkg/Universa= l/Network/Ip4Dxe/Ip4Impl.c index 7c27db6753d0..87aadf13e470 100644 --- a/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c +++ b/MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Impl.c @@ -682,7 +682,7 @@ Ip4ConfigProtocol ( // if (IpSb->State =3D=3D IP4_SERVICE_UNSTARTED) { // - // Trigger the EFI_IP4_CONFIG2_PROTOCOL to retrieve the=20 + // Trigger the EFI_IP4_CONFIG2_PROTOCOL to retrieve the // default IPv4 address if it is not available yet. // Policy =3D IpSb->Ip4Config2Instance.Policy; @@ -1660,7 +1660,7 @@ Ef= iIp4Transmit ( } =20 RawHdrLen =3D (UINT8) (RawHdrLen << 2); - =20 + CopyMem (&Head, FirstFragment, IP4_MIN_HEADLEN); =20 Ip4NtohHead (&Head); @@ -2250,8 +2250,8 @@ Ip4SentPacketTicking ( } =20 /** - This heart beat timer of IP4 service instance times out all of its IP4 c= hildren's - received-but-not-delivered and transmitted-but-not-recycle packets, and = provides=20 + This heart beat timer of IP4 service instance times out all of its=20 + IP4 children's received-but-not-delivered and=20 + transmitted-but-not-recycle packets, and provides time input for its IGMP protocol. =20 @param[in] Event The IP4 service instance's heart beat= timer. @@ -2269,17 +2269,17 @@ Ip4TimerTicking ( =20 IpSb =3D (IP4_SERVICE *) Context; NET_CHECK_SIGNATURE (IpSb, IP4_SERVICE_SIGNATURE); - =20 + Ip4PacketTimerTicking (IpSb); Ip4IgmpTicking (IpSb); } =20 /** - This dedicated timer is used to poll underlying network media status. In= case - of cable swap or wireless network switch, a new round auto configuration= will - be initiated. The timer will signal the IP4 to run DHCP configuration ag= ain.=20 - IP4 driver will free old IP address related resource, such as route tabl= e and - Interface, then initiate a DHCP process to acquire new IP, eventually cr= eate=20 + This dedicated timer is used to poll underlying network media status.=20 + In case of cable swap or wireless network switch, a new round auto=20 + configuration will be initiated. The timer will signal the IP4 to run DH= CP configuration again. + IP4 driver will free old IP address related resource, such as route=20 + table and Interface, then initiate a DHCP process to acquire new IP,=20 + eventually create route table for new IP address. =20 @param[in] Event The IP4 service instance's heart beat= timer. @@ -2300,12 +2300,12 @@ Ip4TimerReconfigChecking ( =20 IpSb =3D (IP4_SERVICE *) Context; NET_CHECK_SIGNATURE (IpSb, IP4_SERVICE_SIGNATURE); - =20 + OldMediaPresent =3D IpSb->MediaPresent; =20 // - // Get fresh mode data from MNP, since underlying media status may chang= e.=20 - // Here, it needs to mention that the MediaPresent can also be checked e= ven if=20 + // Get fresh mode data from MNP, since underlying media status may chang= e. + // Here, it needs to mention that the MediaPresent can also be=20 + checked even if // EFI_NOT_STARTED returned while this MNP child driver instance isn't c= onfigured. // Status =3D IpSb->Mnp->GetModeData (IpSb->Mnp, NULL, &SnpModeData); @@ -2= 320,8 +2320,8 @@ Ip4TimerReconfigChecking ( if (!OldMediaPresent && IpSb->MediaPresent && (IpSb->Ip4Config2Instance.= Policy =3D=3D Ip4Config2PolicyDhcp)) { // // Signal the IP4 to run the dhcp configuration again. IP4 driver will= free - // old IP address related resource, such as route table and Interface,= then=20 - // initiate a DHCP round to acquire new IP, eventually=20 + // old IP address related resource, such as route table and Interface,= then + // initiate a DHCP round to acquire new IP, eventually // create route table for new IP address. // if (IpSb->ReconfigEvent !=3D NULL) { -- 2.7.0.windows.1