From: "Bi, Dandan" <dandan.bi@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue
Date: Sat, 8 Sep 2018 04:03:06 +0000 [thread overview]
Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3BB72B75@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20180907101323.50584-1-ruiyu.ni@intel.com>
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
Thanks,
Dandan
-----Original Message-----
From: Ni, Ruiyu
Sent: Friday, September 7, 2018 6:13 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>
Subject: [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
---
UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
index 5dd8423d2f..8f4d5b5e0a 100644
--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c
@@ -45,7 +45,7 @@ GetExceptionHandlerData (
AsmReadIdtr (&IdtDescriptor);
IdtTable = (IA32_IDT_GATE_DESCRIPTOR *)IdtDescriptor.Base;
-
+
Exception0StubHeader = (EXCEPTION0_STUB_HEADER *)ArchGetIdtHandler (&IdtTable[0]);
return Exception0StubHeader->ExceptionHandlerData;
}
@@ -57,7 +57,7 @@ GetExceptionHandlerData (
exception handler data. The new allocated memory layout follows structure EXCEPTION0_STUB_HEADER.
The code assumes that all processors uses the same exception handler for #0 exception.
- @param pointer to exception handler data.
+ @param ExceptionHandlerData pointer to exception handler data.
**/
VOID
SetExceptionHandlerData (
@@ -73,7 +73,7 @@ SetExceptionHandlerData (
//
AsmReadIdtr (&IdtDescriptor);
IdtTable = (IA32_IDT_GATE_DESCRIPTOR *)IdtDescriptor.Base;
-
+
Exception0StubHeader = AllocatePool (sizeof (*Exception0StubHeader));
ASSERT (Exception0StubHeader != NULL);
CopyMem (
--
2.16.1.windows.1
prev parent reply other threads:[~2018-09-08 4:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 10:13 [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue Ruiyu Ni
2018-09-07 10:31 ` Laszlo Ersek
2018-09-10 2:26 ` Ni, Ruiyu
2018-09-08 4:03 ` Bi, Dandan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C0D5C461C9E904E8F62152F6274C0BB3BB72B75@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox