From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=dandan.bi@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 28ABC21125487 for ; Fri, 7 Sep 2018 21:03:37 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Sep 2018 21:03:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,344,1531810800"; d="scan'208";a="260867642" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 07 Sep 2018 21:03:09 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 7 Sep 2018 21:03:09 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.226]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.240]) with mapi id 14.03.0319.002; Sat, 8 Sep 2018 12:03:07 +0800 From: "Bi, Dandan" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue Thread-Index: AQHURpNYHQo4VgmxekK9QFcRbCMwYqTlxHqA Date: Sat, 8 Sep 2018 04:03:06 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3BB72B75@shsmsx102.ccr.corp.intel.com> References: <20180907101323.50584-1-ruiyu.ni@intel.com> In-Reply-To: <20180907101323.50584-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Sep 2018 04:03:38 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Dandan Bi Thanks, Dandan -----Original Message----- From: Ni, Ruiyu=20 Sent: Friday, September 7, 2018 6:13 PM To: edk2-devel@lists.01.org Cc: Bi, Dandan Subject: [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni Cc: Dandan Bi --- UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c b/= UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c index 5dd8423d2f..8f4d5b5e0a 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuException.c @@ -45,7 +45,7 @@ GetExceptionHandlerData ( =20 AsmReadIdtr (&IdtDescriptor); IdtTable =3D (IA32_IDT_GATE_DESCRIPTOR *)IdtDescriptor.Base; - =20 + Exception0StubHeader =3D (EXCEPTION0_STUB_HEADER *)ArchGetIdtHandler (&I= dtTable[0]); return Exception0StubHeader->ExceptionHandlerData; } @@ -57,7 +57,7 @@ GetExceptionHandlerData ( exception handler data. The new allocated memory layout follows structur= e EXCEPTION0_STUB_HEADER. The code assumes that all processors uses the same exception handler for= #0 exception. =20 - @param pointer to exception handler data. + @param ExceptionHandlerData pointer to exception handler data. **/ VOID SetExceptionHandlerData ( @@ -73,7 +73,7 @@ SetExceptionHandlerData ( // AsmReadIdtr (&IdtDescriptor); IdtTable =3D (IA32_IDT_GATE_DESCRIPTOR *)IdtDescriptor.Base; - =20 + Exception0StubHeader =3D AllocatePool (sizeof (*Exception0StubHeader)); ASSERT (Exception0StubHeader !=3D NULL); CopyMem ( --=20 2.16.1.windows.1