From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=dandan.bi@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0076821163714 for ; Mon, 8 Oct 2018 07:36:40 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Oct 2018 07:36:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,357,1534834800"; d="scan'208";a="93282613" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 08 Oct 2018 07:36:11 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 8 Oct 2018 07:36:11 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 8 Oct 2018 07:36:10 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.217]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.183]) with mapi id 14.03.0319.002; Mon, 8 Oct 2018 22:36:09 +0800 From: "Bi, Dandan" To: Laszlo Ersek , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Kinney, Michael D" , "Gao, Liming" , "Bi, Dandan" Thread-Topic: [edk2] [patch 1/5] MdePkg: Correct the string expression of UTF8 vendor device path Thread-Index: AQHUXrePzOtDnsvaXUeCEmgckuKiWqUUt82AgACyhWA= Date: Mon, 8 Oct 2018 14:36:08 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3BBC2141@shsmsx102.ccr.corp.intel.com> References: <20181008033158.10652-1-dandan.bi@intel.com> <9a04f184-3411-3e1c-26c5-fdb38b750198@redhat.com> In-Reply-To: <9a04f184-3411-3e1c-26c5-fdb38b750198@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjI5ZDQ2M2MtMTBmYS00OTE0LTg4ZDYtMjljOGMyNTJmOWE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSTAra3lJVW5qdjRrZlJFSldic1RKYTlXNzlIRlwvVXVKUExIc1lxbkYzWWx6ak01M2FwSytaMVpcL245TlhMenJTIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 1/5] MdePkg: Correct the string expression of UTF8 vendor device path X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 14:36:41 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Laszlo, > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Monday, October 08, 2018 7:55 PM > To: Bi, Dandan ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Kinney, Michael D > ; Gao, Liming > Subject: Re: [edk2] [patch 1/5] MdePkg: Correct the string expression of > UTF8 vendor device path >=20 > Hi Dandan, >=20 > On 10/08/18 05:31, Dandan Bi wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1225 > > > > According to UEFI spec, the string expression of UTF8 vendor device > > node should be displayed as: VenUtf8(). Current code display it as: > > VenUft8() by mistake when convert device path node to text. > > > > This commit is to fix this bug. > > > > Cc: Ruiyu Ni > > Cc: Michael D Kinney > > Cc: Liming Gao > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Dandan Bi > > --- > > MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > > b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > > index 7d8d304f6f..85f5e97131 100644 > > --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > > +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > > @@ -193,11 +193,11 @@ DevPathToTextVendor ( > > return ; > > } else if (CompareGuid (&Vendor->Guid, &gEfiVT100PlusGuid)) { > > UefiDevicePathLibCatPrint (Str, L"VenVt100Plus()"); > > return ; > > } else if (CompareGuid (&Vendor->Guid, &gEfiVTUTF8Guid)) { > > - UefiDevicePathLibCatPrint (Str, L"VenUft8()"); > > + UefiDevicePathLibCatPrint (Str, L"VenUtf8()"); > > return ; > > } else if (CompareGuid (&Vendor->Guid, &gEfiUartDevicePathGuid))= { > > FlowControlMap =3D (((UART_FLOW_CONTROL_DEVICE_PATH *) > Vendor)->FlowControlMap); > > switch (FlowControlMap & 0x00000003) { > > case 0: > > >=20 > it makes sense to send a set of patches that are correlated in some fashi= on, > even if they individually address different BZs and don't form a coherent > "feature" or larger "bugfix". However, even in such cases, please send a > common cover letter (0/5 in this case). Seeing a unified diffstat, and a = few > intro words (about the common theme of the patch > set) is helpful. >=20 > (no need to repost, just for the future) >=20 Thanks for the reminder, I will pay more attention in the future. Thanks, Dandan > Thanks > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel