From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=dandan.bi@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 39D5821163DE9 for ; Fri, 26 Oct 2018 19:16:24 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Oct 2018 19:16:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,430,1534834800"; d="scan'208";a="81273042" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 26 Oct 2018 19:16:23 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 26 Oct 2018 19:16:23 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 26 Oct 2018 19:16:23 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.84]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.214]) with mapi id 14.03.0415.000; Sat, 27 Oct 2018 10:16:21 +0800 From: "Bi, Dandan" To: "Wang, Jian J" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [PATCH] MdeModulePkg/Core: correct one coding style Thread-Index: AQHUbZqoQCv4350A9EWtA7UGE4ZNVKUyWpYQ Date: Sat, 27 Oct 2018 02:16:20 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB3BBFA54B@shsmsx102.ccr.corp.intel.com> References: <20181027021324.18528-1-jian.j.wang@intel.com> In-Reply-To: <20181027021324.18528-1-jian.j.wang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg/Core: correct one coding style X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2018 02:16:24 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bi Dandan Thanks, Dandan > -----Original Message----- > From: Wang, Jian J > Sent: Saturday, October 27, 2018 10:13 AM > To: edk2-devel@lists.01.org > Cc: Bi, Dandan ; Zeng, Star > Subject: [PATCH] MdeModulePkg/Core: correct one coding style >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1284 >=20 > Non-Boolean comparisons should use a compare operator (=3D=3D, !=3D, >, <= >=3D, <=3D) >=20 > Cc: Dandan Bi > Cc: Star Zeng > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang > --- > MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c > b/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c > index 521e0d7b2a..9f89df8d8f 100644 > --- a/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c > +++ b/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c > @@ -1559,7 +1559,7 @@ PromoteGuardedFreePages ( > } > } >=20 > - if (AvailablePages) { > + if (AvailablePages !=3D 0) { > DEBUG ((DEBUG_INFO, "Promoted pages: %lX (%lx)\r\n", Start, > (UINT64)AvailablePages)); > ClearGuardedMemoryBits (Start, AvailablePages); >=20 > -- > 2.19.0.windows.1