From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=dandan.bi@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B411A21959CB2 for ; Thu, 8 Nov 2018 19:34:28 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Nov 2018 19:34:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,481,1534834800"; d="scan'208";a="85108139" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga008.fm.intel.com with ESMTP; 08 Nov 2018 19:34:28 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 8 Nov 2018 19:34:27 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 8 Nov 2018 19:34:27 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.84]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.117]) with mapi id 14.03.0415.000; Fri, 9 Nov 2018 11:34:27 +0800 From: "Bi, Dandan" To: "Gao, Liming" , "edk2-devel@lists.01.org" , "afish@apple.com" , Laszlo Ersek , Leif Lindholm CC: "Ni, Ruiyu" , "Kinney, Michael D" , "Bi, Dandan" Thread-Topic: [patch] MdePkg: Fix incorrect check for DisplayOnly text format in AcpiEx Thread-Index: AQHUd2rKNVuSB31rDEyt8TViX4fTIaVGvy2Q Date: Fri, 9 Nov 2018 03:34:25 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40183185@shsmsx102.ccr.corp.intel.com> References: <20181108134935.51312-1-dandan.bi@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E367885@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E367885@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch] MdePkg: Fix incorrect check for DisplayOnly text format in AcpiEx X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2018 03:34:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Stewards and package maintainers: Since this is a clear bug. And the risk for this release is small. So I plan to push this patch before edk2-stable201811 tag is created. If you have any concern, please raise here.=20 Thanks, Dandan > -----Original Message----- > From: Gao, Liming > Sent: Thursday, November 8, 2018 9:56 PM > To: Bi, Dandan ; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Kinney, Michael D > > Subject: RE: [patch] MdePkg: Fix incorrect check for DisplayOnly text for= mat > in AcpiEx >=20 > Reviewed-by: Liming Gao >=20 > > -----Original Message----- > > From: Bi, Dandan > > Sent: Thursday, November 8, 2018 9:50 PM > > To: edk2-devel@lists.01.org > > Cc: Ni, Ruiyu ; Kinney, Michael D > > ; Gao, Liming > > Subject: [patch] MdePkg: Fix incorrect check for DisplayOnly text > > format in AcpiEx > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1312 > > > > Text format for AcpiEx device path in UEFI Spec: > > AcpiEx(HID,CID,UID,HIDSTR,CIDSTR,UIDSTR) > > AcpiEx(HID|HIDSTR,(CID|CIDSTR,UID|UIDSTR))(Display Only) > > > > When convert device path to text for ACPI device path, current code > > check AllowShortcuts parameter to convert the device path to > > DisplayOnly text format(shorter text > > representation) by mistake. > > It should check DisplayOnly parameter. > > > > This commit is to fix this issue. > > > > Cc: Ruiyu Ni > > Cc: Michael D Kinney > > Cc: Liming Gao > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Dandan Bi > > --- > > MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > > b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > > index cdcdb3623a..97d279eeb2 100644 > > --- a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > > +++ b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c > > @@ -495,11 +495,11 @@ DevPathToTextAcpiEx ( > > CIDText, > > UIDStr > > ); > > } > > } else { > > - if (AllowShortcuts) { > > + if (DisplayOnly) { > > // > > // display only > > // > > if (AcpiEx->HID =3D=3D 0) { > > UefiDevicePathLibCatPrint (Str, L"AcpiEx(%a,", HIDStr); > > -- > > 2.18.0.windows.1