From: "Bi, Dandan" <dandan.bi@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [Patch] MdeModulePkg: Correct PCD name in MdeModulePkg.uni
Date: Thu, 29 Nov 2018 01:36:15 +0000 [thread overview]
Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB4019764A@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1543454259-12220-1-git-send-email-liming.gao@intel.com>
Reviewed-by: Bi Dandan <dandan.bi@intel.com>
Thanks,
Dandan
> -----Original Message-----
> From: Gao, Liming
> Sent: Thursday, November 29, 2018 9:18 AM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [Patch] MdeModulePkg: Correct PCD name in MdeModulePkg.uni
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=1363
> New PCD PcdVpdBaseAddress64 is added in MdeModulePkg.dec.
> Its string token in MdeModulePkg.uni should match to its name.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Bi Dandan <dandan.bi@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
> MdeModulePkg/MdeModulePkg.uni | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/MdeModulePkg.uni
> b/MdeModulePkg/MdeModulePkg.uni index 9b1766b36a..c754d7bb15
> 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -1261,9 +1261,9 @@
> "On TRUE, the string FPDT
> record will be used to store every performance entry.\n"
> "On FALSE, the different
> FPDT record will be used to store the different performance entries."
>
> -#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress_PROMPT
> #language en-US "64bit VPD base address"
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress64_PROMPT
> #language en-US "64bit VPD base address"
>
> -#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress_HELP
> #language en-US "VPD type PCD allows a developer to point to an absolute
> physical address PcdVpdBaseAddress64"
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress64_HELP
> #language en-US "VPD type PCD allows a developer to point to an absolute
> physical address PcdVpdBaseAddress64"
> "to store PCD value. It will be
> DynamicExDefault only."
> "It is used to set VPD region base
> address. So, it can't be DynamicExVpd PCD. Its value is"
> "required to be accessed in PcdDxe
> driver entry point. So, its value must be set in PEI phase."
> --
> 2.13.0.windows.1
prev parent reply other threads:[~2018-11-29 1:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 1:17 [Patch] MdeModulePkg: Correct PCD name in MdeModulePkg.uni Liming Gao
2018-11-29 1:31 ` Zeng, Star
2018-11-29 1:36 ` Bi, Dandan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C0D5C461C9E904E8F62152F6274C0BB4019764A@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox