From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=dandan.bi@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E716821B02822 for ; Wed, 28 Nov 2018 17:36:18 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2018 17:36:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,292,1539673200"; d="scan'208";a="113387364" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 28 Nov 2018 17:36:18 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 28 Nov 2018 17:36:17 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 28 Nov 2018 17:36:17 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.182]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.46]) with mapi id 14.03.0415.000; Thu, 29 Nov 2018 09:36:15 +0800 From: "Bi, Dandan" To: "Gao, Liming" , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [Patch] MdeModulePkg: Correct PCD name in MdeModulePkg.uni Thread-Index: AQHUh4FkYLTAH7XUNUCMB0oWNdfv86Vl+IjA Date: Thu, 29 Nov 2018 01:36:15 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB4019764A@shsmsx102.ccr.corp.intel.com> References: <1543454259-12220-1-git-send-email-liming.gao@intel.com> In-Reply-To: <1543454259-12220-1-git-send-email-liming.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] MdeModulePkg: Correct PCD name in MdeModulePkg.uni X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 01:36:19 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bi Dandan Thanks, Dandan > -----Original Message----- > From: Gao, Liming > Sent: Thursday, November 29, 2018 9:18 AM > To: edk2-devel@lists.01.org > Cc: Bi, Dandan ; Zeng, Star > Subject: [Patch] MdeModulePkg: Correct PCD name in MdeModulePkg.uni >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1363 > New PCD PcdVpdBaseAddress64 is added in MdeModulePkg.dec. > Its string token in MdeModulePkg.uni should match to its name. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Cc: Bi Dandan > Cc: Star Zeng > --- > MdeModulePkg/MdeModulePkg.uni | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.uni > b/MdeModulePkg/MdeModulePkg.uni index 9b1766b36a..c754d7bb15 > 100644 > --- a/MdeModulePkg/MdeModulePkg.uni > +++ b/MdeModulePkg/MdeModulePkg.uni > @@ -1261,9 +1261,9 @@ > = "On TRUE, the string FPDT > record will be used to store every performance entry.\n" > = "On FALSE, the different > FPDT record will be used to store the different performance entries." >=20 > -#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress_PROMPT > #language en-US "64bit VPD base address" > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress64_PROMPT > #language en-US "64bit VPD base address" >=20 > -#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress_HELP > #language en-US "VPD type PCD allows a developer to point to an absolute > physical address PcdVpdBaseAddress64" > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress64_HELP > #language en-US "VPD type PCD allows a developer to point to an absolute > physical address PcdVpdBaseAddress64" > = "to store PCD value. It will be > DynamicExDefault only." > = "It is used to set VPD region base > address. So, it can't be DynamicExVpd PCD. Its value is" > = "required to be accessed in PcdDxe > driver entry point. So, its value must be set in PEI phase." > -- > 2.13.0.windows.1