[Patch] MdeModulePkg: Correct PCD name in MdeModulePkg.uni

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [Patch] MdeModulePkg: Correct PCD name in MdeModulePkg.uni
@ 2018-11-29  1:17 Liming Gao
  2018-11-29  1:31 ` Zeng, Star
  2018-11-29  1:36 ` Bi, Dandan
  0 siblings, 2 replies; 3+ messages in thread
From: Liming Gao @ 2018-11-29  1:17 UTC (permalink / raw)
  To: edk2-devel; +Cc: Bi Dandan, Star Zeng

https://bugzilla.tianocore.org/show_bug.cgi?id=1363
New PCD PcdVpdBaseAddress64 is added in MdeModulePkg.dec.
Its string token in MdeModulePkg.uni should match to its name.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Bi Dandan <dandan.bi@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
---
 MdeModulePkg/MdeModulePkg.uni | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
index 9b1766b36a..c754d7bb15 100644
--- a/MdeModulePkg/MdeModulePkg.uni
+++ b/MdeModulePkg/MdeModulePkg.uni
@@ -1261,9 +1261,9 @@
                                                                                                       "On TRUE, the string FPDT record will be used to store every performance entry.\n"
                                                                                                       "On FALSE, the different FPDT record will be used to store the different performance entries."
 
-#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress_PROMPT  #language en-US "64bit VPD base address"
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress64_PROMPT  #language en-US "64bit VPD base address"
 
-#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress_HELP  #language en-US "VPD type PCD allows a developer to point to an absolute physical address PcdVpdBaseAddress64"
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress64_HELP  #language en-US "VPD type PCD allows a developer to point to an absolute physical address PcdVpdBaseAddress64"
                                                                                    "to store PCD value. It will be DynamicExDefault only."
                                                                                    "It is used to set VPD region base address. So, it can't be DynamicExVpd PCD. Its value is"
                                                                                    "required to be accessed in PcdDxe driver entry point. So, its value must be set in PEI phase."
-- 
2.13.0.windows.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Patch] MdeModulePkg: Correct PCD name in MdeModulePkg.uni
  2018-11-29  1:17 [Patch] MdeModulePkg: Correct PCD name in MdeModulePkg.uni Liming Gao
@ 2018-11-29  1:31 ` Zeng, Star
  2018-11-29  1:36 ` Bi, Dandan
  1 sibling, 0 replies; 3+ messages in thread
From: Zeng, Star @ 2018-11-29  1:31 UTC (permalink / raw)
  To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Bi, Dandan, Zeng, Star

Reviewed-by: Star Zeng <star.zeng@intel.com>

-----Original Message-----
From: Gao, Liming 
Sent: Thursday, November 29, 2018 9:18 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [Patch] MdeModulePkg: Correct PCD name in MdeModulePkg.uni

https://bugzilla.tianocore.org/show_bug.cgi?id=1363
New PCD PcdVpdBaseAddress64 is added in MdeModulePkg.dec.
Its string token in MdeModulePkg.uni should match to its name.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Bi Dandan <dandan.bi@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
---
 MdeModulePkg/MdeModulePkg.uni | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni index 9b1766b36a..c754d7bb15 100644
--- a/MdeModulePkg/MdeModulePkg.uni
+++ b/MdeModulePkg/MdeModulePkg.uni
@@ -1261,9 +1261,9 @@
                                                                                                       "On TRUE, the string FPDT record will be used to store every performance entry.\n"
                                                                                                       "On FALSE, the different FPDT record will be used to store the different performance entries."
 
-#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress_PROMPT  #language en-US "64bit VPD base address"
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress64_PROMPT  #language en-US "64bit VPD base address"
 
-#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress_HELP  #language en-US "VPD type PCD allows a developer to point to an absolute physical address PcdVpdBaseAddress64"
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress64_HELP  #language en-US "VPD type PCD allows a developer to point to an absolute physical address PcdVpdBaseAddress64"
                                                                                    "to store PCD value. It will be DynamicExDefault only."
                                                                                    "It is used to set VPD region base address. So, it can't be DynamicExVpd PCD. Its value is"
                                                                                    "required to be accessed in PcdDxe driver entry point. So, its value must be set in PEI phase."
--
2.13.0.windows.1



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Patch] MdeModulePkg: Correct PCD name in MdeModulePkg.uni
  2018-11-29  1:17 [Patch] MdeModulePkg: Correct PCD name in MdeModulePkg.uni Liming Gao
  2018-11-29  1:31 ` Zeng, Star
@ 2018-11-29  1:36 ` Bi, Dandan
  1 sibling, 0 replies; 3+ messages in thread
From: Bi, Dandan @ 2018-11-29  1:36 UTC (permalink / raw)
  To: Gao, Liming, edk2-devel@lists.01.org; +Cc: Zeng, Star

Reviewed-by: Bi Dandan <dandan.bi@intel.com>

Thanks,
Dandan

> -----Original Message-----
> From: Gao, Liming
> Sent: Thursday, November 29, 2018 9:18 AM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan <dandan.bi@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [Patch] MdeModulePkg: Correct PCD name in MdeModulePkg.uni
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=1363
> New PCD PcdVpdBaseAddress64 is added in MdeModulePkg.dec.
> Its string token in MdeModulePkg.uni should match to its name.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Bi Dandan <dandan.bi@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> ---
>  MdeModulePkg/MdeModulePkg.uni | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.uni
> b/MdeModulePkg/MdeModulePkg.uni index 9b1766b36a..c754d7bb15
> 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -1261,9 +1261,9 @@
>                                                                                                        "On TRUE, the string FPDT
> record will be used to store every performance entry.\n"
>                                                                                                        "On FALSE, the different
> FPDT record will be used to store the different performance entries."
> 
> -#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress_PROMPT
> #language en-US "64bit VPD base address"
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress64_PROMPT
> #language en-US "64bit VPD base address"
> 
> -#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress_HELP
> #language en-US "VPD type PCD allows a developer to point to an absolute
> physical address PcdVpdBaseAddress64"
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdVpdBaseAddress64_HELP
> #language en-US "VPD type PCD allows a developer to point to an absolute
> physical address PcdVpdBaseAddress64"
>                                                                                     "to store PCD value. It will be
> DynamicExDefault only."
>                                                                                     "It is used to set VPD region base
> address. So, it can't be DynamicExVpd PCD. Its value is"
>                                                                                     "required to be accessed in PcdDxe
> driver entry point. So, its value must be set in PEI phase."
> --
> 2.13.0.windows.1



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-11-29  1:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-29  1:17 [Patch] MdeModulePkg: Correct PCD name in MdeModulePkg.uni Liming Gao
2018-11-29  1:31 ` Zeng, Star
2018-11-29  1:36 ` Bi, Dandan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox