Re: [patch] MdeModulePkg/NonDiscoverable: Use compare operator for comparison

["Bi, Dandan" <dandan.bi@intel.com>]

Hi Star,

Thank you for your suggestion. 
I will send a new patch with your suggestion.


Thanks,
Dandan

> -----Original Message-----
> From: Zeng, Star
> Sent: Tuesday, January 1, 2019 9:17 PM
> To: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Vladimir Olovyannikov
> <vladimir.olovyannikov@broadcom.com>; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>; Zeng, Star <star.zeng@intel.com>
> Subject: RE: [edk2] [patch] MdeModulePkg/NonDiscoverable: Use compare
> operator for comparison
> 
>   if (Attributes) {
>       if ((Attributes & (~(DEV_SUPPORTED_ATTRIBUTES))) != 0) {
>         return EFI_UNSUPPORTED;
>       }
>     }
> 
> If ((Attributes & (~(DEV_SUPPORTED_ATTRIBUTES))) != 0) is TRUE, the
> Attributes must be not 0.
> So " if (Attributes " could be removed.
> 
> BTW: This code block has indentation problem.
> 
> 
> With them handled, Reviewed-by: Star Zeng <star.zeng@intel.com>
> 
> 
> Thanks,
> Star
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Friday, December 28, 2018 4:54 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>
> Subject: [edk2] [patch] MdeModulePkg/NonDiscoverable: Use compare
> operator for comparison
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1422
> 
> According to EDK II C Coding Standards Specification, Non-Boolean
> comparisons must use a compare operator.
> This patch is to update the code to follow EDKII coding style.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  .../NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c    | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable
> PciDeviceIo.c
> b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable
> PciDeviceIo.c
> index f0d3472ea5..a0fe3b9ffa 100644
> ---
> a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable
> PciDeviceIo.c
> +++
> b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverable
> Pc
> +++ iDeviceIo.c
> @@ -1274,11 +1274,11 @@ PciIoAttributes (
>    #define DEV_SUPPORTED_ATTRIBUTES \
>      (EFI_PCI_DEVICE_ENABLE |
> EFI_PCI_IO_ATTRIBUTE_DUAL_ADDRESS_CYCLE)
> 
>    Dev = NON_DISCOVERABLE_PCI_DEVICE_FROM_PCI_IO(This);
> 
> -  if (Attributes) {
> +  if (Attributes != 0) {
>        if ((Attributes & (~(DEV_SUPPORTED_ATTRIBUTES))) != 0) {
>          return EFI_UNSUPPORTED;
>        }
>      }
> 
> --
> 2.18.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel