public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bi, Dandan" <dandan.bi@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH] MdeModulePkg/MdeModulePkg.dsc: ignore standalone MM modules for EBC or XCODE5
Date: Mon, 28 Jan 2019 01:56:16 +0000	[thread overview]
Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40B8D677@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190125081205.2967-1-ard.biesheuvel@linaro.org>

Reviewed-by: Bi Dandan <dandan.bi@intel.com>


Thanks,
Dandan

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Ard Biesheuvel
> Sent: Friday, January 25, 2019 4:12 PM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.dsc: ignore
> standalone MM modules for EBC or XCODE5
> 
> The newly added standalone MM versions of the FTW and variable runtime
> drivers were included in MdeModulePkg.dsc to get test coverage when
> building the package from its own .dsc, but the resulting modules are non-
> functional since they incorporate some dummy libraries.
> 
> Dandan reports that these modules don't build cleanly when using the EBC or
> XCODE5 compilers, so given the above, let's just ignore them in this case.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  MdeModulePkg/MdeModulePkg.dsc | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dsc
> b/MdeModulePkg/MdeModulePkg.dsc index 93eaf4b404a1..55eca4d74c04
> 100644
> --- a/MdeModulePkg/MdeModulePkg.dsc
> +++ b/MdeModulePkg/MdeModulePkg.dsc
> @@ -426,9 +426,6 @@ [Components]
>    MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf
>    MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf
> 
> -
> MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStanda
> loneMm.inf
> -
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf
> -
>  [Components.IA32, Components.X64, Components.AARCH64]
>    MdeModulePkg/Universal/EbcDxe/EbcDxe.inf
>    MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf
> @@ -442,6 +439,11 @@ [Components.IA32, Components.X64,
> Components.ARM, Components.AARCH64]
> 
> NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32G
> uidedSectionExtractLib.inf
>    }
> 
> +!if $(TOOL_CHAIN_TAG) != "XCODE5"
> +
> +MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStan
> dalo
> +neMm.inf
> +
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf
> +!endif
> +
>  [Components.IA32, Components.X64, Components.Ebc]
> 
> MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntime
> Dxe.inf
> 
> --
> 2.17.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  parent reply	other threads:[~2019-01-28  1:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-25  8:12 [PATCH] MdeModulePkg/MdeModulePkg.dsc: ignore standalone MM modules for EBC or XCODE5 Ard Biesheuvel
2019-01-25  9:26 ` Gao, Liming
2019-01-28  1:56 ` Bi, Dandan [this message]
2019-01-28 10:25   ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C0D5C461C9E904E8F62152F6274C0BB40B8D677@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox