From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=dandan.bi@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 023CD2117A287 for ; Sun, 27 Jan 2019 17:56:19 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jan 2019 17:56:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,532,1539673200"; d="scan'208";a="133617210" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 27 Jan 2019 17:56:18 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 27 Jan 2019 17:56:18 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 27 Jan 2019 17:56:18 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.71]) with mapi id 14.03.0415.000; Mon, 28 Jan 2019 09:56:16 +0800 From: "Bi, Dandan" To: Ard Biesheuvel , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.dsc: ignore standalone MM modules for EBC or XCODE5 Thread-Index: AQHUtIXXD8PHOqlXkUeZ/s9rXVbN1aXD76aw Date: Mon, 28 Jan 2019 01:56:16 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40B8D677@SHSMSX104.ccr.corp.intel.com> References: <20190125081205.2967-1-ard.biesheuvel@linaro.org> In-Reply-To: <20190125081205.2967-1-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] MdeModulePkg/MdeModulePkg.dsc: ignore standalone MM modules for EBC or XCODE5 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2019 01:56:20 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bi Dandan Thanks, Dandan > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Friday, January 25, 2019 4:12 PM > To: edk2-devel@lists.01.org > Cc: Bi, Dandan ; Gao, Liming > Subject: [edk2] [PATCH] MdeModulePkg/MdeModulePkg.dsc: ignore > standalone MM modules for EBC or XCODE5 >=20 > The newly added standalone MM versions of the FTW and variable runtime > drivers were included in MdeModulePkg.dsc to get test coverage when > building the package from its own .dsc, but the resulting modules are non= - > functional since they incorporate some dummy libraries. >=20 > Dandan reports that these modules don't build cleanly when using the EBC = or > XCODE5 compilers, so given the above, let's just ignore them in this case= . >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > MdeModulePkg/MdeModulePkg.dsc | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dsc > b/MdeModulePkg/MdeModulePkg.dsc index 93eaf4b404a1..55eca4d74c04 > 100644 > --- a/MdeModulePkg/MdeModulePkg.dsc > +++ b/MdeModulePkg/MdeModulePkg.dsc > @@ -426,9 +426,6 @@ [Components] > MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf > MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf >=20 > - > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStanda > loneMm.inf > - > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf > - > [Components.IA32, Components.X64, Components.AARCH64] > MdeModulePkg/Universal/EbcDxe/EbcDxe.inf > MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf > @@ -442,6 +439,11 @@ [Components.IA32, Components.X64, > Components.ARM, Components.AARCH64] >=20 > NULL|MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32G > uidedSectionExtractLib.inf > } >=20 > +!if $(TOOL_CHAIN_TAG) !=3D "XCODE5" > + > +MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStan > dalo > +neMm.inf > + > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf > +!endif > + > [Components.IA32, Components.X64, Components.Ebc] >=20 > MdeModulePkg/Universal/Variable/EmuRuntimeDxe/EmuVariableRuntime > Dxe.inf >=20 > -- > 2.17.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel