From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=dandan.bi@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7A9E0211C3F40 for ; Thu, 31 Jan 2019 18:16:16 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2019 18:16:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,546,1539673200"; d="scan'208";a="123043484" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 31 Jan 2019 18:16:14 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 31 Jan 2019 18:16:10 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 31 Jan 2019 18:16:09 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.110]) with mapi id 14.03.0415.000; Fri, 1 Feb 2019 10:16:08 +0800 From: "Bi, Dandan" To: Nikita Leshenko , "edk2-devel@lists.01.org" CC: "liran.alon@oracle.com" Thread-Topic: [edk2] [PATCH 01/14] OvmfPkg/MptScsiDxe: Create empty driver Thread-Index: AQHUuUzhDDLRfyvBNE26YfX/Uq7UoKXKNA1g Date: Fri, 1 Feb 2019 02:16:07 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40B8F64E@SHSMSX104.ccr.corp.intel.com> References: <20190131100724.20907-1-nikita.leshchenko@oracle.com> <20190131100724.20907-2-nikita.leshchenko@oracle.com> In-Reply-To: <20190131100724.20907-2-nikita.leshchenko@oracle.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 01/14] OvmfPkg/MptScsiDxe: Create empty driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2019 02:16:16 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Nikita, I have one comment here, could you help to verify this patch series with VS= tool chain build before commit the patches? Thanks, Dandan > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Nikita Leshenko > Sent: Thursday, January 31, 2019 6:07 PM > To: edk2-devel@lists.01.org > Cc: liran.alon@oracle.com > Subject: [edk2] [PATCH 01/14] OvmfPkg/MptScsiDxe: Create empty driver >=20 > In preparation for implementing LSI Fusion MPT SCSI devices, create a bas= ic > scaffolding for a driver. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Nikita Leshenko > Reviewed-by: Konrad Rzeszutek Wilk > Reviewed-by: Aaron Young > Reviewed-by: Liran Alon > --- > OvmfPkg/MptScsiDxe/MptScsi.c | 30 ++++++++++++++++++++++++++++ > OvmfPkg/MptScsiDxe/MptScsiDxe.inf | 33 > +++++++++++++++++++++++++++++++ > OvmfPkg/OvmfPkgIa32.dsc | 1 + > OvmfPkg/OvmfPkgIa32.fdf | 1 + > OvmfPkg/OvmfPkgIa32X64.dsc | 1 + > OvmfPkg/OvmfPkgIa32X64.fdf | 1 + > OvmfPkg/OvmfPkgX64.dsc | 1 + > OvmfPkg/OvmfPkgX64.fdf | 1 + > 8 files changed, 69 insertions(+) > create mode 100644 OvmfPkg/MptScsiDxe/MptScsi.c create mode 100644 > OvmfPkg/MptScsiDxe/MptScsiDxe.inf >=20 > diff --git a/OvmfPkg/MptScsiDxe/MptScsi.c > b/OvmfPkg/MptScsiDxe/MptScsi.c new file mode 100644 index > 0000000000..73a693741d > --- /dev/null > +++ b/OvmfPkg/MptScsiDxe/MptScsi.c > @@ -0,0 +1,30 @@ > +/** @file > + > + This driver produces Extended SCSI Pass Thru Protocol instances for > + LSI Fusion MPT SCSI devices. > + > + Copyright (C) 2018, Oracle and/or its affiliates. All rights reserved. > + > + This program and the accompanying materials are licensed and made > + available under the terms and conditions of the BSD License which > + accompanies this distribution. The full text of the license may be > + found at http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > + > +**/ > + > +// > +// Entry Point > +// > + > +EFI_STATUS > +EFIAPI > +MptScsiEntryPoint ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE *SystemTable > + ) > +{ > + return EFI_UNSUPPORTED; > +} > diff --git a/OvmfPkg/MptScsiDxe/MptScsiDxe.inf > b/OvmfPkg/MptScsiDxe/MptScsiDxe.inf > new file mode 100644 > index 0000000000..c558d78034 > --- /dev/null > +++ b/OvmfPkg/MptScsiDxe/MptScsiDxe.inf > @@ -0,0 +1,33 @@ > +## @file > +# This driver produces Extended SCSI Pass Thru Protocol instances for # > +LSI Fusion MPT SCSI devices. > +# > +# Copyright (C) 2018, Oracle and/or its affiliates. All rights reserved. > +# > +# This program and the accompanying materials are licensed and made > +available # under the terms and conditions of the BSD License which > +accompanies this # distribution. The full text of the license may be > +found at # http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > +WITHOUT # WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > +# > +## > + > +[Defines] > + INF_VERSION =3D 0x00010005 > + BASE_NAME =3D MptScsiDxe > + FILE_GUID =3D 2B3DB5DD-B315-4961-8454-0AFF3C811B1= 9 > + MODULE_TYPE =3D UEFI_DRIVER > + VERSION_STRING =3D 1.0 > + ENTRY_POINT =3D MptScsiEntryPoint > + > +[Sources] > + MptScsi.c > + > +[Packages] > + MdePkg/MdePkg.dec > + OvmfPkg/OvmfPkg.dec > + > +[LibraryClasses] > + UefiDriverEntryPoint > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc index > aee19b75d7..52458859b6 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -708,6 +708,7 @@ > OvmfPkg/XenIoPciDxe/XenIoPciDxe.inf > OvmfPkg/XenBusDxe/XenBusDxe.inf > OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf > + OvmfPkg/MptScsiDxe/MptScsiDxe.inf > MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf >=20 > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCoun > terRuntimeDxe.inf > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf index > e013099136..73e36636e0 100644 > --- a/OvmfPkg/OvmfPkgIa32.fdf > +++ b/OvmfPkg/OvmfPkgIa32.fdf > @@ -233,6 +233,7 @@ INF OvmfPkg/VirtioRngDxe/VirtioRng.inf > INF OvmfPkg/XenIoPciDxe/XenIoPciDxe.inf > INF OvmfPkg/XenBusDxe/XenBusDxe.inf > INF OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf > +INF OvmfPkg/MptScsiDxe/MptScsiDxe.inf >=20 > !if $(SECURE_BOOT_ENABLE) =3D=3D TRUE > INF > SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfi > gDxe.inf > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 90cbd8e341..d8ea2addb2 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -717,6 +717,7 @@ > OvmfPkg/XenIoPciDxe/XenIoPciDxe.inf > OvmfPkg/XenBusDxe/XenBusDxe.inf > OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf > + OvmfPkg/MptScsiDxe/MptScsiDxe.inf > MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf >=20 > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCoun > terRuntimeDxe.inf > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf > index afaa334384..e22a223e7e 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.fdf > +++ b/OvmfPkg/OvmfPkgIa32X64.fdf > @@ -234,6 +234,7 @@ INF OvmfPkg/VirtioRngDxe/VirtioRng.inf > INF OvmfPkg/XenIoPciDxe/XenIoPciDxe.inf > INF OvmfPkg/XenBusDxe/XenBusDxe.inf > INF OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf > +INF OvmfPkg/MptScsiDxe/MptScsiDxe.inf >=20 > !if $(SECURE_BOOT_ENABLE) =3D=3D TRUE > INF > SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfi > gDxe.inf > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index > 83d16eb00b..daf03cd1b5 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -715,6 +715,7 @@ > OvmfPkg/XenIoPciDxe/XenIoPciDxe.inf > OvmfPkg/XenBusDxe/XenBusDxe.inf > OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf > + OvmfPkg/MptScsiDxe/MptScsiDxe.inf > MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf >=20 > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCoun > terRuntimeDxe.inf > MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf index > afaa334384..e22a223e7e 100644 > --- a/OvmfPkg/OvmfPkgX64.fdf > +++ b/OvmfPkg/OvmfPkgX64.fdf > @@ -234,6 +234,7 @@ INF OvmfPkg/VirtioRngDxe/VirtioRng.inf > INF OvmfPkg/XenIoPciDxe/XenIoPciDxe.inf > INF OvmfPkg/XenBusDxe/XenBusDxe.inf > INF OvmfPkg/XenPvBlkDxe/XenPvBlkDxe.inf > +INF OvmfPkg/MptScsiDxe/MptScsiDxe.inf >=20 > !if $(SECURE_BOOT_ENABLE) =3D=3D TRUE > INF > SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfi > gDxe.inf > -- > 2.20.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel