From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: dandan.bi@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Thu, 04 Apr 2019 18:00:41 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Apr 2019 18:00:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,310,1549958400"; d="scan'208";a="158377498" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 04 Apr 2019 18:00:39 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 4 Apr 2019 18:00:39 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 4 Apr 2019 18:00:39 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.21]) with mapi id 14.03.0415.000; Fri, 5 Apr 2019 09:00:37 +0800 From: "Dandan Bi" To: "devel@edk2.groups.io" , "felixp@ami.com" CC: "Gao, Liming" , "Wang, Jian J" , "Wu, Hao A" Subject: Re: [edk2-devel] [patch 4/7] MdeModulePkg: Move BaseUefiTianoCustomDecompressLib to Thread-Topic: [edk2-devel] [patch 4/7] MdeModulePkg: Move BaseUefiTianoCustomDecompressLib to Thread-Index: AQHU6u2/vGlI125OME2U0XcGYqTMKaYsfoyggAA/cfA= Date: Fri, 5 Apr 2019 01:00:37 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40BB7C50@SHSMSX104.ccr.corp.intel.com> References: <20190404135209.13116-1-dandan.bi@intel.com> <20190404135209.13116-5-dandan.bi@intel.com> <9333E191E0D52B4999CE63A99BA663A00302C73274@atlms1.us.megatrends.com> In-Reply-To: <9333E191E0D52B4999CE63A99BA663A00302C73274@atlms1.us.megatrends.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYThjYmYzM2YtOGQ4NS00OWVlLTk1ODQtNTQ2Y2VjNWU4YzcwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMGNhelM1Y3owdHlqWjJIalJOY1ErMlFIZzZERFVoN2xOTHRQUkVqRXRWWWNQQjFzbDkwNU5BQllXUU8wekE0OSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: dandan.bi@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Felix Polyudov > Sent: Friday, April 05, 2019 5:15 AM > To: devel@edk2.groups.io; Bi, Dandan > Cc: Gao, Liming ; Wang, Jian J > ; Wu, Hao A > Subject: Re: [edk2-devel] [patch 4/7] MdeModulePkg: Move > BaseUefiTianoCustomDecompressLib to >=20 > Dandan, >=20 > Since UEFI compression and Tiano compression are just different flavors = of > the same algorithm (the same algorithm with different PBit values), I th= ink > it's better not to have two parallel implementation in > BaseUefiDecompressLib.c and BaseUefiTianoCustomDecompressLib.c. > A cleaner approach would be to share the same decompression code > between two libraries. Hi, Thanks for your suggestion. I think code cleanup and sharing is good. We can do it in next step. It should not be covered in this move action, we need make patch clean. Thanks, Dandan >=20 > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Dandan Bi > Sent: Thursday, April 04, 2019 9:52 AM > To: devel@edk2.groups.io > Cc: Liming Gao; Jian J Wang; Hao Wu > Subject: [edk2-devel] [patch 4/7] MdeModulePkg: Move > BaseUefiTianoCustomDecompressLib to >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1683 >=20 > We will remove IntelFrameworkModulePkg, > but BaseUefiTianoCustomDecompressLib may still need to be used. So > move BaseUefiTianoCustomDecompressLib from > IntelFrameworkModulePkg to MdeModulePkg. >=20 > Cc: Liming Gao > Cc: Jian J Wang > Cc: Hao Wu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > --- > IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec | 4 ---- > IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 1 - > .../Include/Guid/TianoDecompress.h | 0 > .../BaseUefiTianoCustomDecompressLib.c | 0 > .../BaseUefiTianoCustomDecompressLib.inf | 2 +- > .../BaseUefiTianoCustomDecompressLibInternals.h | 0 > .../BaseUefiTianoDecompressLib.uni | 0 > MdeModulePkg/MdeModulePkg.dec | 4 ++++ > MdeModulePkg/MdeModulePkg.dsc | 1 + > 9 files changed, 6 insertions(+), 6 deletions(-) rename > {IntelFrameworkModulePkg =3D> > MdeModulePkg}/Include/Guid/TianoDecompress.h (100%) rename > {IntelFrameworkModulePkg =3D> > MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTia > noCustomDecompressLib.c (100%) rename {IntelFrameworkModulePkg =3D> > MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTia > noCustomDecompressLib.inf (94%) rename {IntelFrameworkModulePkg =3D> > MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTia > noCustomDecompressLibInternals.h (100%) rename > {IntelFrameworkModulePkg =3D> > MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTia > noDecompressLib.uni (100%) >=20 > diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec > b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec > index 5557b5a1cd..0a451dd9ee 100644 > --- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec > +++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec > @@ -40,14 +40,10 @@ >=20 > ## GUID identifies Data Hub records logged by Status Code Runtime > Protocol. > # Include/Guid/DataHubStatusCodeRecord.h > gEfiDataHubStatusCodeRecordGuid =3D { 0xD083E94C, 0x6560, 0x42E4, > { 0xB6, 0xD4, 0x2D, 0xF7, 0x5A, 0xDF, 0x6A, 0x2A }} >=20 > - ## GUID indicates the tiano custom compress/decompress algorithm. > - # Include/Guid/TianoDecompress.h > - gTianoCustomDecompressGuid =3D { 0xA31280AD, 0x481E, 0x41B6, > { 0x95, 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }} > - > ## Include/Guid/AcpiVariable.h > gEfiAcpiVariableCompatiblityGuid =3D { 0xc020489e, 0x6db2, 0x4ef2, > { 0x9a, 0xa5, 0xca, 0x6, 0xfc, 0x11, 0xd3, 0x6a }} >=20 > ## Include/Guid/LegacyBios.h > gEfiLegacyBiosGuid =3D { 0x2E3044AC, 0x879F, 0x490F, = { 0x97, > 0x60, 0xBB, 0xDF, 0xAF, 0x69, 0x5F, 0x50 }} > diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc > b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc > index 949a181a7b..2afda5df79 100644 > --- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc > +++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc > @@ -117,11 +117,10 @@ > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x0f > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x06 > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000 >=20 > [Components] > - > IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/B > aseUefiTianoCustomDecompressLib.inf >=20 > IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCusto > mDecompressLib.inf > IntelFrameworkModulePkg/Library/PeiS3Lib/PeiS3Lib.inf > IntelFrameworkModulePkg/Library/PeiRecoveryLib/PeiRecoveryLib.inf >=20 > IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/Dx > eReportStatusCodeLib.inf >=20 > IntelFrameworkModulePkg/Library/SmmRuntimeDxeReportStatusCodeLibF > ramework/SmmRuntimeDxeReportStatusCodeLibFramework.inf > diff --git a/IntelFrameworkModulePkg/Include/Guid/TianoDecompress.h > b/MdeModulePkg/Include/Guid/TianoDecompress.h > similarity index 100% > rename from IntelFrameworkModulePkg/Include/Guid/TianoDecompress.h > rename to MdeModulePkg/Include/Guid/TianoDecompress.h > diff --git > a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib > /BaseUefiTianoCustomDecompressLib.c > b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi > anoCustomDecompressLib.c > similarity index 100% > rename from > IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/B > aseUefiTianoCustomDecompressLib.c > rename to > MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian > oCustomDecompressLib.c > diff --git > a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib > /BaseUefiTianoCustomDecompressLib.inf > b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi > anoCustomDecompressLib.inf > similarity index 94% > rename from > IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/B > aseUefiTianoCustomDecompressLib.inf > rename to > MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian > oCustomDecompressLib.inf > index ee64fa0d0e..41cc48cd24 100644 > --- > a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib > /BaseUefiTianoCustomDecompressLib.inf > +++ > b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi > an > +++ oCustomDecompressLib.inf > @@ -33,11 +33,11 @@ > BaseUefiTianoCustomDecompressLibInternals.h > BaseUefiTianoCustomDecompressLib.c >=20 > [Packages] > MdePkg/MdePkg.dec > - IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec > + MdeModulePkg/MdeModulePkg.dec >=20 > [LibraryClasses] > BaseLib > DebugLib > BaseMemoryLib > diff --git > a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib > /BaseUefiTianoCustomDecompressLibInternals.h > b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi > anoCustomDecompressLibInternals.h > similarity index 100% > rename from > IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/B > aseUefiTianoCustomDecompressLibInternals.h > rename to > MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian > oCustomDecompressLibInternals.h > diff --git > a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib > /BaseUefiTianoDecompressLib.uni > b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi > anoDecompressLib.uni > similarity index 100% > rename from > IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/B > aseUefiTianoDecompressLib.uni > rename to > MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian > oDecompressLib.uni > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec index 9bbd0572f5..546ec38b9d > 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -377,10 +377,14 @@ > ## GUID indicates the LZMA custom compress/decompress algorithm. > # Include/Guid/LzmaDecompress.h > gLzmaCustomDecompressGuid =3D { 0xEE4E5898, 0x3914, 0x4259, > { 0x9D, 0x6E, 0xDC, 0x7B, 0xD7, 0x94, 0x03, 0xCF }} > gLzmaF86CustomDecompressGuid =3D { 0xD42AE6BD, 0x1352, 0x4bfb, > { 0x90, 0x9A, 0xCA, 0x72, 0xA6, 0xEA, 0xE8, 0x89 }} >=20 > + ## GUID indicates the tiano custom compress/decompress algorithm. > + # Include/Guid/TianoDecompress.h > + gTianoCustomDecompressGuid =3D { 0xA31280AD, 0x481E, 0x41B6, > { 0x95, 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }} > + > ## Include/Guid/TtyTerm.h > gEfiTtyTermGuid =3D { 0x7d916d80, 0x5bb1, 0x458c, {0xa= 4, 0x8f, > 0xe2, 0x5f, 0xdd, 0x51, 0xef, 0x94 }} >=20 > ## Include/Guid/HiiBootMaintenanceFormset.h > gEfiIfrBootMaintenanceGuid =3D { 0xb2dedc91, 0xd59f, 0x48d2, { 0= x89, > 0x8a, 0x12, 0x49, 0xc, 0x74, 0xa4, 0xe0 }} > diff --git a/MdeModulePkg/MdeModulePkg.dsc > b/MdeModulePkg/MdeModulePkg.dsc index da2078b8d2..8905ca5814 > 100644 > --- a/MdeModulePkg/MdeModulePkg.dsc > +++ b/MdeModulePkg/MdeModulePkg.dsc > @@ -317,10 +317,11 @@ > MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf >=20 > MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscove > rableDeviceRegistrationLib.inf > MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf >=20 > MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdate > ProgressLibGraphics.inf >=20 > MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgr > essLibText.inf > + > + > MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian > oCus > + tomDecompressLib.inf >=20 > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf >=20 > MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuA > pp.inf > MdeModulePkg/Application/UiApp/UiApp.inf{ > > -- > 2.18.0.windows.1 >=20 >=20 >=20 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and > proprietary to American Megatrends, Inc. This communication is intended > to be read only by the individual or entity to whom it is addressed or b= y > their designee. If the reader of this message is not the intended recipi= ent, > you are on notice that any distribution of this message, in any form, is > strictly prohibited. Please promptly notify the sender by reply e-mail = or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission. >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#84): https://edk2.groups.io/g/devel/message/84 > Mute This Topic: https://groups.io/mt/30896393/1768738 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [dandan.bi@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D