Re: [edk2-devel] [patch 2/7] BeagleBoardPkg: Update UefiDecompressLib instance

["Dandan Bi" <dandan.bi@intel.com>]

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ard Biesheuvel
> Sent: Thursday, April 04, 2019 11:27 PM
> To: Bi, Dandan <dandan.bi@intel.com>
> Cc: devel@edk2.groups.io; Leif Lindholm <leif.lindholm@linaro.org>
> Subject: Re: [edk2-devel] [patch 2/7] BeagleBoardPkg: Update
> UefiDecompressLib instance
> 
> On Thu, 4 Apr 2019 at 20:52, Dandan Bi <dandan.bi@intel.com> wrote:
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
> >
> > BaseUefiDecompressLib in MdePkg is the base UEFI decompress Library.
> > BaseUefiTianoCustomDecompressLib in IntelFrameworkModulePkg
> implements
> > the base UEFI decompress functionality and Tiano decompress
> > functionality.
> >
> > 1. TIANOCOMPRESSED rule in BeagleBoardPkg.fdf is not used, so remove
> > it.
> > 2. Platform doesn't use the TianoCompress, so do not have to use
> > BaseUefiTianoCustomDecompressLib, can use the BaseUefiDecompressLib
> in
> > MdePkg directly.
> >
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> > ---
> >  BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++--
> > BeagleBoardPkg/BeagleBoardPkg.fdf | 9 ---------
> >  2 files changed, 2 insertions(+), 11 deletions(-)
> >
> > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc
> > b/BeagleBoardPkg/BeagleBoardPkg.dsc
> > index e0fee3692f..e5fbe7eeb2 100644
> > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc
> > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
> > @@ -185,17 +185,17 @@
> >
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerforma
> nceLib.inf
> >
> >
> NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscove
> ra
> > bleDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
> >
> >  [LibraryClasses.common.UEFI_APPLICATION]
> >
> >
> ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatus
> Cod
> > eLibFramework/DxeReportStatusCodeLib.inf
> > -
> >
> UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCust
> omD
> > ecompressLib/BaseUefiTianoCustomDecompressLib.inf
> > +
> > +
> UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco
> m
> > + pressLib.inf
> >
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerforma
> nceLib.inf
> >    HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
> >
> >  [LibraryClasses.common.UEFI_DRIVER]
> >
> >
> ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatus
> Cod
> > eLibFramework/DxeReportStatusCodeLib.inf
> > -
> >
> UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCust
> omD
> > ecompressLib/BaseUefiTianoCustomDecompressLib.inf
> > +
> > +
> UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco
> m
> > + pressLib.inf
> >
> ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/Dxe
> ExtractGuidedSectionLib.inf
> >
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerforma
> nceLib.inf
> >    DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> >
> >  [LibraryClasses.common.DXE_RUNTIME_DRIVER]
> 
> Can we add a single UefiDecompressLib resolution to the common section
> and drop all the others?

Yes, I will cover this in V2 and pick up your Reviewed-by.

Thanks,
Dandan
> 
> > diff --git a/BeagleBoardPkg/BeagleBoardPkg.fdf
> > b/BeagleBoardPkg/BeagleBoardPkg.fdf
> > index 42d6bad0c7..9c9cecf894 100644
> > --- a/BeagleBoardPkg/BeagleBoardPkg.fdf
> > +++ b/BeagleBoardPkg/BeagleBoardPkg.fdf
> > @@ -262,19 +262,10 @@ READ_LOCK_STATUS   = TRUE
> >       PEI_DEPEX PEI_DEPEX Optional
> $(INF_OUTPUT)/$(MODULE_NAME).depex
> >       PE32      PE32                     $(INF_OUTPUT)/$(MODULE_NAME).efi
> >       UI       STRING="$(MODULE_NAME)" Optional
> >    }
> >
> > -[Rule.Common.PEIM.TIANOCOMPRESSED]
> > -  FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 {
> > -    PEI_DEPEX PEI_DEPEX Optional
> $(INF_OUTPUT)/$(MODULE_NAME).depex
> > -    GUIDED A31280AD-481E-41B6-95E8-127F4C984779
> PROCESSING_REQUIRED = TRUE {
> > -      PE32      PE32                    $(INF_OUTPUT)/$(MODULE_NAME).efi
> > -      UI        STRING="$(MODULE_NAME)" Optional
> > -    }
> > -  }
> > -
> >  [Rule.Common.DXE_CORE]
> >    FILE DXE_CORE = $(NAMED_GUID) {
> >      PE32     PE32                       $(INF_OUTPUT)/$(MODULE_NAME).efi
> >      UI       STRING="$(MODULE_NAME)" Optional
> >    }
> > --
> > 2.18.0.windows.1
> >
> 
> With the above update:
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 
>