* [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg
@ 2019-04-04 13:52 dandan.bi
2019-04-04 13:52 ` [patch 1/7] ArmVirtPkg: Update UefiDecompressLib instance Dandan Bi
` (7 more replies)
0 siblings, 8 replies; 27+ messages in thread
From: dandan.bi @ 2019-04-04 13:52 UTC (permalink / raw)
To: devel
Cc: Laszlo Ersek, Julien Grall, Leif Lindholm, Ard Biesheuvel,
Jordan Justen, Andrew Fish, Liming Gao, Ray Ni, Jian J Wang,
Hao Wu, Michael D Kinney, Kelly Steele, Zailiang Sun, Yi Qian
We will remove IntelFrameworkModulePkg,but BaseUefiTianoCustomDecompressLib in it
may still need to be used. So move BaseUefiTianoCustomDecompressLib from
IntelFrameworkModulePkg to MdeModulePkg firstly.
Patch 1-3 are to clean up platform unnecessary dependency on BaseUefiTianoCustomDecompressLib
in IntelFrameworkModulePkg before the move.
Patch 4 is to move the BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg.
Patch 5-7 are to update the consumer to use the BaseUefiTianoCustomDecompressLib in MdeModulePkg after the move.
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Julien Grall <julien.grall@arm.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Dandan Bi (7):
ArmVirtPkg: Update UefiDecompressLib instance
BeagleBoardPkg: Update UefiDecompressLib instance
EmulatorPkg: Update UefiDecompressLib instance
MdeModulePkg: Move BaseUefiTianoCustomDecompressLib to
Nt32Pkg: Update to use UefiDecompressLib in MdeModulePkg
Quark: Update to use UefiDecompressLib in MdeModulePkg
Vlv2TbltDevicePkg: Update to use UefiDecompressLib in MdeModulePkg
ArmVirtPkg/ArmVirt.dsc.inc | 4 ++--
ArmVirtPkg/ArmVirtRules.fdf.inc | 9 ---------
BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++--
BeagleBoardPkg/BeagleBoardPkg.fdf | 9 ---------
EmulatorPkg/EmulatorPkg.dsc | 2 +-
IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec | 4 ----
IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 1 -
.../Include/Guid/TianoDecompress.h | 0
.../BaseUefiTianoCustomDecompressLib.c | 0
.../BaseUefiTianoCustomDecompressLib.inf | 2 +-
.../BaseUefiTianoCustomDecompressLibInternals.h | 0
.../BaseUefiTianoDecompressLib.uni | 0
MdeModulePkg/MdeModulePkg.dec | 4 ++++
MdeModulePkg/MdeModulePkg.dsc | 1 +
Nt32Pkg/Nt32Pkg.dsc | 2 +-
QuarkPlatformPkg/Quark.dsc | 2 +-
QuarkPlatformPkg/QuarkMin.dsc | 2 +-
Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 2 +-
Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 2 +-
Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 2 +-
20 files changed, 17 insertions(+), 35 deletions(-)
rename {IntelFrameworkModulePkg => MdeModulePkg}/Include/Guid/TianoDecompress.h (100%)
rename {IntelFrameworkModulePkg => MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c (100%)
rename {IntelFrameworkModulePkg => MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf (94%)
rename {IntelFrameworkModulePkg => MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLibInternals.h (100%)
rename {IntelFrameworkModulePkg => MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoDecompressLib.uni (100%)
--
2.18.0.windows.1
^ permalink raw reply [flat|nested] 27+ messages in thread
* [patch 1/7] ArmVirtPkg: Update UefiDecompressLib instance
2019-04-04 13:52 [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg dandan.bi
@ 2019-04-04 13:52 ` Dandan Bi
2019-04-04 14:57 ` Laszlo Ersek
2019-04-04 13:52 ` [patch 2/7] BeagleBoardPkg: " Dandan Bi
` (6 subsequent siblings)
7 siblings, 1 reply; 27+ messages in thread
From: Dandan Bi @ 2019-04-04 13:52 UTC (permalink / raw)
To: devel; +Cc: Laszlo Ersek, Ard Biesheuvel, Julien Grall
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
BaseUefiDecompressLib in MdePkg is the
base UEFI decompress Library.
BaseUefiTianoCustomDecompressLib in IntelFrameworkModulePkg
implements the base UEFI decompress functionality and
Tiano decompress functionality.
1. TIANOCOMPRESSED rule in ArmVirtRules.fdf.inc
is not used, so remove it.
2. Platform doesn't use the TianoCompress, so do
not have to use BaseUefiTianoCustomDecompressLib,
can use the BaseUefiDecompressLib in MdePkg directly.
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Julien Grall <julien.grall@arm.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
ArmVirtPkg/ArmVirt.dsc.inc | 4 ++--
ArmVirtPkg/ArmVirtRules.fdf.inc | 9 ---------
2 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index d172a082c9..556ec0dcb1 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -223,17 +223,17 @@
SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
[LibraryClasses.common.UEFI_APPLICATION]
- UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
+ UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
[LibraryClasses.common.UEFI_DRIVER]
- UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
+ UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
[LibraryClasses.common.DXE_RUNTIME_DRIVER]
diff --git a/ArmVirtPkg/ArmVirtRules.fdf.inc b/ArmVirtPkg/ArmVirtRules.fdf.inc
index 5ff3004786..bed06364e1 100644
--- a/ArmVirtPkg/ArmVirtRules.fdf.inc
+++ b/ArmVirtPkg/ArmVirtRules.fdf.inc
@@ -56,19 +56,10 @@
PEI_DEPEX PEI_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex
TE TE Align = Auto $(INF_OUTPUT)/$(MODULE_NAME).efi
UI STRING="$(MODULE_NAME)" Optional
}
-[Rule.Common.PEIM.TIANOCOMPRESSED]
- FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 {
- PEI_DEPEX PEI_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex
- GUIDED A31280AD-481E-41B6-95E8-127F4C984779 PROCESSING_REQUIRED = TRUE {
- PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi
- UI STRING="$(MODULE_NAME)" Optional
- }
- }
-
[Rule.Common.DXE_CORE]
FILE DXE_CORE = $(NAMED_GUID) {
PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi
UI STRING="$(MODULE_NAME)" Optional
}
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [patch 2/7] BeagleBoardPkg: Update UefiDecompressLib instance
2019-04-04 13:52 [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg dandan.bi
2019-04-04 13:52 ` [patch 1/7] ArmVirtPkg: Update UefiDecompressLib instance Dandan Bi
@ 2019-04-04 13:52 ` Dandan Bi
2019-04-04 15:26 ` Ard Biesheuvel
2019-04-04 13:52 ` [patch 3/7] EmulatorPkg: " Dandan Bi
` (5 subsequent siblings)
7 siblings, 1 reply; 27+ messages in thread
From: Dandan Bi @ 2019-04-04 13:52 UTC (permalink / raw)
To: devel; +Cc: Leif Lindholm, Ard Biesheuvel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
BaseUefiDecompressLib in MdePkg is the
base UEFI decompress Library.
BaseUefiTianoCustomDecompressLib in IntelFrameworkModulePkg
implements the base UEFI decompress functionality and
Tiano decompress functionality.
1. TIANOCOMPRESSED rule in BeagleBoardPkg.fdf
is not used, so remove it.
2. Platform doesn't use the TianoCompress, so do
not have to use BaseUefiTianoCustomDecompressLib,
can use the BaseUefiDecompressLib in MdePkg directly.
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++--
BeagleBoardPkg/BeagleBoardPkg.fdf | 9 ---------
2 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc
index e0fee3692f..e5fbe7eeb2 100644
--- a/BeagleBoardPkg/BeagleBoardPkg.dsc
+++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
@@ -185,17 +185,17 @@
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
[LibraryClasses.common.UEFI_APPLICATION]
ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
- UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
+ UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
[LibraryClasses.common.UEFI_DRIVER]
ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
- UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
+ UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
[LibraryClasses.common.DXE_RUNTIME_DRIVER]
diff --git a/BeagleBoardPkg/BeagleBoardPkg.fdf b/BeagleBoardPkg/BeagleBoardPkg.fdf
index 42d6bad0c7..9c9cecf894 100644
--- a/BeagleBoardPkg/BeagleBoardPkg.fdf
+++ b/BeagleBoardPkg/BeagleBoardPkg.fdf
@@ -262,19 +262,10 @@ READ_LOCK_STATUS = TRUE
PEI_DEPEX PEI_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex
PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi
UI STRING="$(MODULE_NAME)" Optional
}
-[Rule.Common.PEIM.TIANOCOMPRESSED]
- FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 {
- PEI_DEPEX PEI_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex
- GUIDED A31280AD-481E-41B6-95E8-127F4C984779 PROCESSING_REQUIRED = TRUE {
- PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi
- UI STRING="$(MODULE_NAME)" Optional
- }
- }
-
[Rule.Common.DXE_CORE]
FILE DXE_CORE = $(NAMED_GUID) {
PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi
UI STRING="$(MODULE_NAME)" Optional
}
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [patch 3/7] EmulatorPkg: Update UefiDecompressLib instance
2019-04-04 13:52 [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg dandan.bi
2019-04-04 13:52 ` [patch 1/7] ArmVirtPkg: Update UefiDecompressLib instance Dandan Bi
2019-04-04 13:52 ` [patch 2/7] BeagleBoardPkg: " Dandan Bi
@ 2019-04-04 13:52 ` Dandan Bi
2019-04-04 13:52 ` [patch 4/7] MdeModulePkg: Move BaseUefiTianoCustomDecompressLib to Dandan Bi
` (4 subsequent siblings)
7 siblings, 0 replies; 27+ messages in thread
From: Dandan Bi @ 2019-04-04 13:52 UTC (permalink / raw)
To: devel; +Cc: Jordan Justen, Andrew Fish, Ray Ni
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
BaseUefiDecompressLib in MdePkg is the
base UEFI decompress Library.
BaseUefiTianoCustomDecompressLib in IntelFrameworkModulePkg
implements the base UEFI decompress functionality and
Tiano decompress functionality.
BaseUefiDecompressLib in MdePkg is the
base UEFI decompress Library.
BaseUefiTianoCustomDecompressLib in IntelFrameworkModulePkg
implements the base UEFI decompress functionality and Tiano
decompress functionality.
Platform doesn't use the TianoCompress, so do
not have to use BaseUefiTianoCustomDecompressLib,
can use the BaseUefiDecompressLib in MdePkg directly.
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
EmulatorPkg/EmulatorPkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc
index 4097e1192e..84223b83ba 100644
--- a/EmulatorPkg/EmulatorPkg.dsc
+++ b/EmulatorPkg/EmulatorPkg.dsc
@@ -61,11 +61,11 @@
UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
- UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
+ UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
SmbiosLib|EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [patch 4/7] MdeModulePkg: Move BaseUefiTianoCustomDecompressLib to
2019-04-04 13:52 [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg dandan.bi
` (2 preceding siblings ...)
2019-04-04 13:52 ` [patch 3/7] EmulatorPkg: " Dandan Bi
@ 2019-04-04 13:52 ` Dandan Bi
2019-04-04 14:21 ` [edk2-devel] " Laszlo Ersek
2019-04-04 21:14 ` felixp
2019-04-04 13:52 ` [patch 5/7] Nt32Pkg: Update to use UefiDecompressLib in MdeModulePkg Dandan Bi
` (3 subsequent siblings)
7 siblings, 2 replies; 27+ messages in thread
From: Dandan Bi @ 2019-04-04 13:52 UTC (permalink / raw)
To: devel; +Cc: Liming Gao, Jian J Wang, Hao Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
We will remove IntelFrameworkModulePkg,
but BaseUefiTianoCustomDecompressLib may still need
to be used. So move BaseUefiTianoCustomDecompressLib
from IntelFrameworkModulePkg to MdeModulePkg.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec | 4 ----
IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 1 -
.../Include/Guid/TianoDecompress.h | 0
.../BaseUefiTianoCustomDecompressLib.c | 0
.../BaseUefiTianoCustomDecompressLib.inf | 2 +-
.../BaseUefiTianoCustomDecompressLibInternals.h | 0
.../BaseUefiTianoDecompressLib.uni | 0
MdeModulePkg/MdeModulePkg.dec | 4 ++++
MdeModulePkg/MdeModulePkg.dsc | 1 +
9 files changed, 6 insertions(+), 6 deletions(-)
rename {IntelFrameworkModulePkg => MdeModulePkg}/Include/Guid/TianoDecompress.h (100%)
rename {IntelFrameworkModulePkg => MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c (100%)
rename {IntelFrameworkModulePkg => MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf (94%)
rename {IntelFrameworkModulePkg => MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLibInternals.h (100%)
rename {IntelFrameworkModulePkg => MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoDecompressLib.uni (100%)
diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
index 5557b5a1cd..0a451dd9ee 100644
--- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
+++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
@@ -40,14 +40,10 @@
## GUID identifies Data Hub records logged by Status Code Runtime Protocol.
# Include/Guid/DataHubStatusCodeRecord.h
gEfiDataHubStatusCodeRecordGuid = { 0xD083E94C, 0x6560, 0x42E4, { 0xB6, 0xD4, 0x2D, 0xF7, 0x5A, 0xDF, 0x6A, 0x2A }}
- ## GUID indicates the tiano custom compress/decompress algorithm.
- # Include/Guid/TianoDecompress.h
- gTianoCustomDecompressGuid = { 0xA31280AD, 0x481E, 0x41B6, { 0x95, 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }}
-
## Include/Guid/AcpiVariable.h
gEfiAcpiVariableCompatiblityGuid = { 0xc020489e, 0x6db2, 0x4ef2, { 0x9a, 0xa5, 0xca, 0x6, 0xfc, 0x11, 0xd3, 0x6a }}
## Include/Guid/LegacyBios.h
gEfiLegacyBiosGuid = { 0x2E3044AC, 0x879F, 0x490F, { 0x97, 0x60, 0xBB, 0xDF, 0xAF, 0x69, 0x5F, 0x50 }}
diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
index 949a181a7b..2afda5df79 100644
--- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
+++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
@@ -117,11 +117,10 @@
gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x0f
gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x06
gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000
[Components]
- IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
IntelFrameworkModulePkg/Library/PeiS3Lib/PeiS3Lib.inf
IntelFrameworkModulePkg/Library/PeiRecoveryLib/PeiRecoveryLib.inf
IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
IntelFrameworkModulePkg/Library/SmmRuntimeDxeReportStatusCodeLibFramework/SmmRuntimeDxeReportStatusCodeLibFramework.inf
diff --git a/IntelFrameworkModulePkg/Include/Guid/TianoDecompress.h b/MdeModulePkg/Include/Guid/TianoDecompress.h
similarity index 100%
rename from IntelFrameworkModulePkg/Include/Guid/TianoDecompress.h
rename to MdeModulePkg/Include/Guid/TianoDecompress.h
diff --git a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c
similarity index 100%
rename from IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c
rename to MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c
diff --git a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
similarity index 94%
rename from IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
rename to MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
index ee64fa0d0e..41cc48cd24 100644
--- a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
+++ b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
@@ -33,11 +33,11 @@
BaseUefiTianoCustomDecompressLibInternals.h
BaseUefiTianoCustomDecompressLib.c
[Packages]
MdePkg/MdePkg.dec
- IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
+ MdeModulePkg/MdeModulePkg.dec
[LibraryClasses]
BaseLib
DebugLib
BaseMemoryLib
diff --git a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLibInternals.h b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLibInternals.h
similarity index 100%
rename from IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLibInternals.h
rename to MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLibInternals.h
diff --git a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoDecompressLib.uni b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoDecompressLib.uni
similarity index 100%
rename from IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoDecompressLib.uni
rename to MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoDecompressLib.uni
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 9bbd0572f5..546ec38b9d 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -377,10 +377,14 @@
## GUID indicates the LZMA custom compress/decompress algorithm.
# Include/Guid/LzmaDecompress.h
gLzmaCustomDecompressGuid = { 0xEE4E5898, 0x3914, 0x4259, { 0x9D, 0x6E, 0xDC, 0x7B, 0xD7, 0x94, 0x03, 0xCF }}
gLzmaF86CustomDecompressGuid = { 0xD42AE6BD, 0x1352, 0x4bfb, { 0x90, 0x9A, 0xCA, 0x72, 0xA6, 0xEA, 0xE8, 0x89 }}
+ ## GUID indicates the tiano custom compress/decompress algorithm.
+ # Include/Guid/TianoDecompress.h
+ gTianoCustomDecompressGuid = { 0xA31280AD, 0x481E, 0x41B6, { 0x95, 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }}
+
## Include/Guid/TtyTerm.h
gEfiTtyTermGuid = { 0x7d916d80, 0x5bb1, 0x458c, {0xa4, 0x8f, 0xe2, 0x5f, 0xdd, 0x51, 0xef, 0x94 }}
## Include/Guid/HiiBootMaintenanceFormset.h
gEfiIfrBootMaintenanceGuid = { 0xb2dedc91, 0xd59f, 0x48d2, { 0x89, 0x8a, 0x12, 0x49, 0xc, 0x74, 0xa4, 0xe0 }}
diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
index da2078b8d2..8905ca5814 100644
--- a/MdeModulePkg/MdeModulePkg.dsc
+++ b/MdeModulePkg/MdeModulePkg.dsc
@@ -317,10 +317,11 @@
MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf
MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf
MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.inf
MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.inf
+ MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf
MdeModulePkg/Application/UiApp/UiApp.inf{
<LibraryClasses>
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [patch 5/7] Nt32Pkg: Update to use UefiDecompressLib in MdeModulePkg
2019-04-04 13:52 [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg dandan.bi
` (3 preceding siblings ...)
2019-04-04 13:52 ` [patch 4/7] MdeModulePkg: Move BaseUefiTianoCustomDecompressLib to Dandan Bi
@ 2019-04-04 13:52 ` Dandan Bi
2019-04-04 21:21 ` [edk2-devel] " Felix Polyudov
2019-04-04 13:52 ` [patch 6/7] Quark: " Dandan Bi
` (2 subsequent siblings)
7 siblings, 1 reply; 27+ messages in thread
From: Dandan Bi @ 2019-04-04 13:52 UTC (permalink / raw)
To: devel; +Cc: Ray Ni, Hao Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
We have moved the BaseUefiTianoCustomDecompressLib
from IntelFrameworkModulePkg to MdeModulePkg, so
update the consumer accordingly.
Cc: Ray Ni <ray.ni@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Nt32Pkg/Nt32Pkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc
index d7b78007d2..2a7218766d 100644
--- a/Nt32Pkg/Nt32Pkg.dsc
+++ b/Nt32Pkg/Nt32Pkg.dsc
@@ -124,11 +124,11 @@
UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDevicePathProtocol.inf
- UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
+ UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [patch 6/7] Quark: Update to use UefiDecompressLib in MdeModulePkg
2019-04-04 13:52 [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg dandan.bi
` (4 preceding siblings ...)
2019-04-04 13:52 ` [patch 5/7] Nt32Pkg: Update to use UefiDecompressLib in MdeModulePkg Dandan Bi
@ 2019-04-04 13:52 ` Dandan Bi
2019-04-04 13:52 ` [patch 7/7] Vlv2TbltDevicePkg: " Dandan Bi
2019-04-23 16:26 ` [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg Ard Biesheuvel
7 siblings, 0 replies; 27+ messages in thread
From: Dandan Bi @ 2019-04-04 13:52 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Kelly Steele
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
We have moved the BaseUefiTianoCustomDecompressLib
from IntelFrameworkModulePkg to MdeModulePkg, so
update the consumer accordingly.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
QuarkPlatformPkg/Quark.dsc | 2 +-
QuarkPlatformPkg/QuarkMin.dsc | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/QuarkPlatformPkg/Quark.dsc b/QuarkPlatformPkg/Quark.dsc
index 0e69b3c51f..226825bc05 100644
--- a/QuarkPlatformPkg/Quark.dsc
+++ b/QuarkPlatformPkg/Quark.dsc
@@ -117,11 +117,11 @@
UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
- UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
+ UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf
PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
diff --git a/QuarkPlatformPkg/QuarkMin.dsc b/QuarkPlatformPkg/QuarkMin.dsc
index 04ecd096ce..afd09e3fde 100644
--- a/QuarkPlatformPkg/QuarkMin.dsc
+++ b/QuarkPlatformPkg/QuarkMin.dsc
@@ -105,11 +105,11 @@
UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
- UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
+ UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf
PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 27+ messages in thread
* [patch 7/7] Vlv2TbltDevicePkg: Update to use UefiDecompressLib in MdeModulePkg
2019-04-04 13:52 [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg dandan.bi
` (5 preceding siblings ...)
2019-04-04 13:52 ` [patch 6/7] Quark: " Dandan Bi
@ 2019-04-04 13:52 ` Dandan Bi
2019-04-08 3:30 ` Qian, Yi
2019-04-23 16:26 ` [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg Ard Biesheuvel
7 siblings, 1 reply; 27+ messages in thread
From: Dandan Bi @ 2019-04-04 13:52 UTC (permalink / raw)
To: devel; +Cc: Zailiang Sun, Yi Qian
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
We have moved the BaseUefiTianoCustomDecompressLib
from IntelFrameworkModulePkg to MdeModulePkg, so
update the consumer accordingly.
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 2 +-
Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 2 +-
Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
index ac401c4826..3b4c7ec579 100644
--- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
+++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
@@ -136,11 +136,11 @@
UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
- UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
+ UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf
PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
index 0b5b976d61..ba5ad53293 100644
--- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
+++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
@@ -136,11 +136,11 @@
UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
- UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
+ UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf
PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
index 1940aead03..c9c9ee8af6 100644
--- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
+++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
@@ -136,11 +136,11 @@
UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
- UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
+ UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf
PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [edk2-devel] [patch 4/7] MdeModulePkg: Move BaseUefiTianoCustomDecompressLib to
2019-04-04 13:52 ` [patch 4/7] MdeModulePkg: Move BaseUefiTianoCustomDecompressLib to Dandan Bi
@ 2019-04-04 14:21 ` Laszlo Ersek
2019-04-05 1:21 ` Dandan Bi
2019-04-04 21:14 ` felixp
1 sibling, 1 reply; 27+ messages in thread
From: Laszlo Ersek @ 2019-04-04 14:21 UTC (permalink / raw)
To: devel, dandan.bi; +Cc: Liming Gao, Jian J Wang, Hao Wu
On 04/04/19 15:52, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
>
> We will remove IntelFrameworkModulePkg,
> but BaseUefiTianoCustomDecompressLib may still need
> to be used. So move BaseUefiTianoCustomDecompressLib
> from IntelFrameworkModulePkg to MdeModulePkg.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec | 4 ----
> IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 1 -
> .../Include/Guid/TianoDecompress.h | 0
> .../BaseUefiTianoCustomDecompressLib.c | 0
> .../BaseUefiTianoCustomDecompressLib.inf | 2 +-
> .../BaseUefiTianoCustomDecompressLibInternals.h | 0
> .../BaseUefiTianoDecompressLib.uni | 0
> MdeModulePkg/MdeModulePkg.dec | 4 ++++
> MdeModulePkg/MdeModulePkg.dsc | 1 +
> 9 files changed, 6 insertions(+), 6 deletions(-)
> rename {IntelFrameworkModulePkg => MdeModulePkg}/Include/Guid/TianoDecompress.h (100%)
> rename {IntelFrameworkModulePkg => MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c (100%)
> rename {IntelFrameworkModulePkg => MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf (94%)
> rename {IntelFrameworkModulePkg => MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLibInternals.h (100%)
> rename {IntelFrameworkModulePkg => MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoDecompressLib.uni (100%)
>
> diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
> index 5557b5a1cd..0a451dd9ee 100644
> --- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
> +++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
> @@ -40,14 +40,10 @@
>
> ## GUID identifies Data Hub records logged by Status Code Runtime Protocol.
> # Include/Guid/DataHubStatusCodeRecord.h
> gEfiDataHubStatusCodeRecordGuid = { 0xD083E94C, 0x6560, 0x42E4, { 0xB6, 0xD4, 0x2D, 0xF7, 0x5A, 0xDF, 0x6A, 0x2A }}
>
> - ## GUID indicates the tiano custom compress/decompress algorithm.
> - # Include/Guid/TianoDecompress.h
> - gTianoCustomDecompressGuid = { 0xA31280AD, 0x481E, 0x41B6, { 0x95, 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }}
> -
> ## Include/Guid/AcpiVariable.h
> gEfiAcpiVariableCompatiblityGuid = { 0xc020489e, 0x6db2, 0x4ef2, { 0x9a, 0xa5, 0xca, 0x6, 0xfc, 0x11, 0xd3, 0x6a }}
>
> ## Include/Guid/LegacyBios.h
> gEfiLegacyBiosGuid = { 0x2E3044AC, 0x879F, 0x490F, { 0x97, 0x60, 0xBB, 0xDF, 0xAF, 0x69, 0x5F, 0x50 }}
> diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
> index 949a181a7b..2afda5df79 100644
> --- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
> +++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
> @@ -117,11 +117,10 @@
> gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x0f
> gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x06
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000
>
> [Components]
> - IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
> IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> IntelFrameworkModulePkg/Library/PeiS3Lib/PeiS3Lib.inf
> IntelFrameworkModulePkg/Library/PeiRecoveryLib/PeiRecoveryLib.inf
> IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> IntelFrameworkModulePkg/Library/SmmRuntimeDxeReportStatusCodeLibFramework/SmmRuntimeDxeReportStatusCodeLibFramework.inf
> diff --git a/IntelFrameworkModulePkg/Include/Guid/TianoDecompress.h b/MdeModulePkg/Include/Guid/TianoDecompress.h
> similarity index 100%
> rename from IntelFrameworkModulePkg/Include/Guid/TianoDecompress.h
> rename to MdeModulePkg/Include/Guid/TianoDecompress.h
> diff --git a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c
> similarity index 100%
> rename from IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c
> rename to MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c
> diff --git a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
> similarity index 94%
> rename from IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
> rename to MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
> index ee64fa0d0e..41cc48cd24 100644
> --- a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
> +++ b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
> @@ -33,11 +33,11 @@
> BaseUefiTianoCustomDecompressLibInternals.h
> BaseUefiTianoCustomDecompressLib.c
>
> [Packages]
> MdePkg/MdePkg.dec
> - IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
> + MdeModulePkg/MdeModulePkg.dec
>
> [LibraryClasses]
> BaseLib
> DebugLib
> BaseMemoryLib
> diff --git a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLibInternals.h b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLibInternals.h
> similarity index 100%
> rename from IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLibInternals.h
> rename to MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLibInternals.h
> diff --git a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoDecompressLib.uni b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoDecompressLib.uni
> similarity index 100%
> rename from IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoDecompressLib.uni
> rename to MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoDecompressLib.uni
> diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
> index 9bbd0572f5..546ec38b9d 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -377,10 +377,14 @@
> ## GUID indicates the LZMA custom compress/decompress algorithm.
> # Include/Guid/LzmaDecompress.h
> gLzmaCustomDecompressGuid = { 0xEE4E5898, 0x3914, 0x4259, { 0x9D, 0x6E, 0xDC, 0x7B, 0xD7, 0x94, 0x03, 0xCF }}
> gLzmaF86CustomDecompressGuid = { 0xD42AE6BD, 0x1352, 0x4bfb, { 0x90, 0x9A, 0xCA, 0x72, 0xA6, 0xEA, 0xE8, 0x89 }}
>
> + ## GUID indicates the tiano custom compress/decompress algorithm.
> + # Include/Guid/TianoDecompress.h
> + gTianoCustomDecompressGuid = { 0xA31280AD, 0x481E, 0x41B6, { 0x95, 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }}
> +
> ## Include/Guid/TtyTerm.h
> gEfiTtyTermGuid = { 0x7d916d80, 0x5bb1, 0x458c, {0xa4, 0x8f, 0xe2, 0x5f, 0xdd, 0x51, 0xef, 0x94 }}
>
> ## Include/Guid/HiiBootMaintenanceFormset.h
> gEfiIfrBootMaintenanceGuid = { 0xb2dedc91, 0xd59f, 0x48d2, { 0x89, 0x8a, 0x12, 0x49, 0xc, 0x74, 0xa4, 0xe0 }}
> diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
> index da2078b8d2..8905ca5814 100644
> --- a/MdeModulePkg/MdeModulePkg.dsc
> +++ b/MdeModulePkg/MdeModulePkg.dsc
> @@ -317,10 +317,11 @@
> MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf
> MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
> MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf
> MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.inf
> MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.inf
> + MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
>
> MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf
> MdeModulePkg/Application/UiApp/UiApp.inf{
> <LibraryClasses>
>
I think that, if you do a rename like this, then the packages in the
rest of the series will break, temporarily. If the maintainers of
Nt32Pkg, Quark, and Vlv2 are OK with that, I don't mind, but normally
you'd create a copy first, then update the references to the copy, then
remove the original.
Thanks
Laszlo
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [patch 1/7] ArmVirtPkg: Update UefiDecompressLib instance
2019-04-04 13:52 ` [patch 1/7] ArmVirtPkg: Update UefiDecompressLib instance Dandan Bi
@ 2019-04-04 14:57 ` Laszlo Ersek
2019-04-05 1:10 ` Dandan Bi
0 siblings, 1 reply; 27+ messages in thread
From: Laszlo Ersek @ 2019-04-04 14:57 UTC (permalink / raw)
To: Dandan Bi, devel; +Cc: Ard Biesheuvel, Julien Grall
On 04/04/19 15:52, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
>
> BaseUefiDecompressLib in MdePkg is the
> base UEFI decompress Library.
> BaseUefiTianoCustomDecompressLib in IntelFrameworkModulePkg
> implements the base UEFI decompress functionality and
> Tiano decompress functionality.
>
> 1. TIANOCOMPRESSED rule in ArmVirtRules.fdf.inc
> is not used, so remove it.
That's correct, the only FDF files that refer to any TIANOCOMPRESSED rules, with RuleOverride, are:
- Nt32Pkg.fdf (for EnglishDxe.inf)
- Quark.fdf (for Shell.inf)
And the GUID in the rule being removed, A31280AD-481E-41B6-95E8-127F4C984779, is indeed gTianoCustomDecompressGuid.
> 2. Platform doesn't use the TianoCompress, so do
> not have to use BaseUefiTianoCustomDecompressLib,
> can use the BaseUefiDecompressLib in MdePkg directly.
It looks like we have the following guid-ed section extractors in edk2:
BrotliCustomDecompress 3D532050-5CDA-4FD0-879E-0F7F630D5AFB
EfiCertTypeRsa2048Sha256 A7717414-C616-4977-9420-844712A735BF
EfiCrc32GuidedSectionExtraction FC1BCDB0-7D31-49AA-936A-A4600D9DD083
LzmaCustomDecompress EE4E5898-3914-4259-9D6E-DC7BD79403CF
LzmaF86CustomDecompress D42AE6BD-1352-4BFB-909A-CA72A6EAE889
TianoCustomDecompress A31280AD-481E-41B6-95E8-127F4C984779
(with the leading "g" and trailing "Guid" stripped).
In order to see whether a platform uses an algorithm for section encoding, we should grep that platform's FDF files for the algorithm's GUID directly... And, indeed, under ArmVirtPkg, the only mention of A31280AD-481E-41B6-95E8-127F4C984779 is in the (unused) rule that's being removed.
The one algorithm that ArmVirtPkg does use, for section encoding, is LzmaCustomDecompress. For that, we have "MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf" resolutions in place already.
So what needs UefiDecompressLib at all? ... Aha, both of these:
- MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
- MdeModulePkg/Core/Dxe/DxeMain.inf
That's a good argument for preserving the lib class resolution at all.
I've compared "BaseUefiTianoCustomDecompressLib.c" to "BaseUefiDecompressLib.c". The main differences are:
* the latter has no constructor that registers a guid-ed section extractor -- and that's fine here, because in the code modified by this patch, the lib instance is not hooked into another module via NULL resolution,
* the following hunk:
//
// The length of the field 'Position Set Code Length Array Size' in Block Header.
// For UEFI 2.0 de/compression algorithm(Version 1), mPBit = 4
- // For Tiano de/compression algorithm(Version 2), mPBit = 5
//
- switch (Version) {
- case 1 :
- Sd->mPBit = 4;
- break;
- case 2 :
- Sd->mPBit = 5;
- break;
- default:
- ASSERT (FALSE);
- }
+ Sd->mPBit = 4;
So, let's see the patch:
>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Julien Grall <julien.grall@arm.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> ArmVirtPkg/ArmVirt.dsc.inc | 4 ++--
> ArmVirtPkg/ArmVirtRules.fdf.inc | 9 ---------
> 2 files changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index d172a082c9..556ec0dcb1 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -223,17 +223,17 @@
> SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
>
> [LibraryClasses.common.UEFI_APPLICATION]
> - UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
> + UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
>
> [LibraryClasses.common.UEFI_DRIVER]
> - UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
> + UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
> ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
>
> [LibraryClasses.common.DXE_RUNTIME_DRIVER]
> diff --git a/ArmVirtPkg/ArmVirtRules.fdf.inc b/ArmVirtPkg/ArmVirtRules.fdf.inc
> index 5ff3004786..bed06364e1 100644
> --- a/ArmVirtPkg/ArmVirtRules.fdf.inc
> +++ b/ArmVirtPkg/ArmVirtRules.fdf.inc
> @@ -56,19 +56,10 @@
> PEI_DEPEX PEI_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex
> TE TE Align = Auto $(INF_OUTPUT)/$(MODULE_NAME).efi
> UI STRING="$(MODULE_NAME)" Optional
> }
>
> -[Rule.Common.PEIM.TIANOCOMPRESSED]
> - FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 {
> - PEI_DEPEX PEI_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex
> - GUIDED A31280AD-481E-41B6-95E8-127F4C984779 PROCESSING_REQUIRED = TRUE {
> - PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi
> - UI STRING="$(MODULE_NAME)" Optional
> - }
> - }
> -
> [Rule.Common.DXE_CORE]
> FILE DXE_CORE = $(NAMED_GUID) {
> PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi
> UI STRING="$(MODULE_NAME)" Optional
> }
>
The patch seems good, but we could improve it: in "ArmVirtPkg", we already have the following UefiDecompressLib resolutions:
ArmVirt.dsc.inc:44: UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
ArmVirt.dsc.inc:192: UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
ArmVirt.dsc.inc:208: UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
ArmVirt.dsc.inc:219: UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
ArmVirt.dsc.inc:228: UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
ArmVirt.dsc.inc:234: UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
On line 44, the resolution is for [LibraryClasses.common]. So, rather than multiplying the same resolution for UEFI_APPLICATION and UEFI_DRIVER too, I suggest removing *all* the resolutions, except the one on line 44 (i.e., in section [LibraryClasses.common]).
The commit message needs a minimal change only -- please append a sentence about the default resolution being right already, and relying on that for all module types.
The "ArmVirtRules.fdf.inc" hunk is good as-is, of course.
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [patch 2/7] BeagleBoardPkg: Update UefiDecompressLib instance
2019-04-04 13:52 ` [patch 2/7] BeagleBoardPkg: " Dandan Bi
@ 2019-04-04 15:26 ` Ard Biesheuvel
2019-04-05 1:03 ` [edk2-devel] " Dandan Bi
0 siblings, 1 reply; 27+ messages in thread
From: Ard Biesheuvel @ 2019-04-04 15:26 UTC (permalink / raw)
To: Dandan Bi; +Cc: devel, Leif Lindholm
On Thu, 4 Apr 2019 at 20:52, Dandan Bi <dandan.bi@intel.com> wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
>
> BaseUefiDecompressLib in MdePkg is the
> base UEFI decompress Library.
> BaseUefiTianoCustomDecompressLib in IntelFrameworkModulePkg
> implements the base UEFI decompress functionality and
> Tiano decompress functionality.
>
> 1. TIANOCOMPRESSED rule in BeagleBoardPkg.fdf
> is not used, so remove it.
> 2. Platform doesn't use the TianoCompress, so do
> not have to use BaseUefiTianoCustomDecompressLib,
> can use the BaseUefiDecompressLib in MdePkg directly.
>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++--
> BeagleBoardPkg/BeagleBoardPkg.fdf | 9 ---------
> 2 files changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc
> index e0fee3692f..e5fbe7eeb2 100644
> --- a/BeagleBoardPkg/BeagleBoardPkg.dsc
> +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
> @@ -185,17 +185,17 @@
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
> NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
>
> [LibraryClasses.common.UEFI_APPLICATION]
> ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> - UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
> + UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
> HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
>
> [LibraryClasses.common.UEFI_DRIVER]
> ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> - UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
> + UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf
> ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
> DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
>
> [LibraryClasses.common.DXE_RUNTIME_DRIVER]
Can we add a single UefiDecompressLib resolution to the common section
and drop all the others?
> diff --git a/BeagleBoardPkg/BeagleBoardPkg.fdf b/BeagleBoardPkg/BeagleBoardPkg.fdf
> index 42d6bad0c7..9c9cecf894 100644
> --- a/BeagleBoardPkg/BeagleBoardPkg.fdf
> +++ b/BeagleBoardPkg/BeagleBoardPkg.fdf
> @@ -262,19 +262,10 @@ READ_LOCK_STATUS = TRUE
> PEI_DEPEX PEI_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex
> PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi
> UI STRING="$(MODULE_NAME)" Optional
> }
>
> -[Rule.Common.PEIM.TIANOCOMPRESSED]
> - FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 {
> - PEI_DEPEX PEI_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex
> - GUIDED A31280AD-481E-41B6-95E8-127F4C984779 PROCESSING_REQUIRED = TRUE {
> - PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi
> - UI STRING="$(MODULE_NAME)" Optional
> - }
> - }
> -
> [Rule.Common.DXE_CORE]
> FILE DXE_CORE = $(NAMED_GUID) {
> PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi
> UI STRING="$(MODULE_NAME)" Optional
> }
> --
> 2.18.0.windows.1
>
With the above update:
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [edk2-devel] [patch 4/7] MdeModulePkg: Move BaseUefiTianoCustomDecompressLib to
2019-04-04 13:52 ` [patch 4/7] MdeModulePkg: Move BaseUefiTianoCustomDecompressLib to Dandan Bi
2019-04-04 14:21 ` [edk2-devel] " Laszlo Ersek
@ 2019-04-04 21:14 ` felixp
2019-04-05 1:00 ` Dandan Bi
1 sibling, 1 reply; 27+ messages in thread
From: felixp @ 2019-04-04 21:14 UTC (permalink / raw)
To: devel@edk2.groups.io, 'dandan.bi@intel.com'
Cc: Liming Gao, Jian J Wang, Hao Wu
Dandan,
Since UEFI compression and Tiano compression are just different flavors of the same algorithm (the same algorithm with different PBit values),
I think it's better not to have two parallel implementation in BaseUefiDecompressLib.c and BaseUefiTianoCustomDecompressLib.c.
A cleaner approach would be to share the same decompression code between two libraries.
-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Dandan Bi
Sent: Thursday, April 04, 2019 9:52 AM
To: devel@edk2.groups.io
Cc: Liming Gao; Jian J Wang; Hao Wu
Subject: [edk2-devel] [patch 4/7] MdeModulePkg: Move BaseUefiTianoCustomDecompressLib to
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
We will remove IntelFrameworkModulePkg,
but BaseUefiTianoCustomDecompressLib may still need
to be used. So move BaseUefiTianoCustomDecompressLib
from IntelFrameworkModulePkg to MdeModulePkg.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec | 4 ----
IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 1 -
.../Include/Guid/TianoDecompress.h | 0
.../BaseUefiTianoCustomDecompressLib.c | 0
.../BaseUefiTianoCustomDecompressLib.inf | 2 +-
.../BaseUefiTianoCustomDecompressLibInternals.h | 0
.../BaseUefiTianoDecompressLib.uni | 0
MdeModulePkg/MdeModulePkg.dec | 4 ++++
MdeModulePkg/MdeModulePkg.dsc | 1 +
9 files changed, 6 insertions(+), 6 deletions(-)
rename {IntelFrameworkModulePkg => MdeModulePkg}/Include/Guid/TianoDecompress.h (100%)
rename {IntelFrameworkModulePkg => MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c (100%)
rename {IntelFrameworkModulePkg => MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf (94%)
rename {IntelFrameworkModulePkg => MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLibInternals.h (100%)
rename {IntelFrameworkModulePkg => MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoDecompressLib.uni (100%)
diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
index 5557b5a1cd..0a451dd9ee 100644
--- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
+++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
@@ -40,14 +40,10 @@
## GUID identifies Data Hub records logged by Status Code Runtime Protocol.
# Include/Guid/DataHubStatusCodeRecord.h
gEfiDataHubStatusCodeRecordGuid = { 0xD083E94C, 0x6560, 0x42E4, { 0xB6, 0xD4, 0x2D, 0xF7, 0x5A, 0xDF, 0x6A, 0x2A }}
- ## GUID indicates the tiano custom compress/decompress algorithm.
- # Include/Guid/TianoDecompress.h
- gTianoCustomDecompressGuid = { 0xA31280AD, 0x481E, 0x41B6, { 0x95, 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }}
-
## Include/Guid/AcpiVariable.h
gEfiAcpiVariableCompatiblityGuid = { 0xc020489e, 0x6db2, 0x4ef2, { 0x9a, 0xa5, 0xca, 0x6, 0xfc, 0x11, 0xd3, 0x6a }}
## Include/Guid/LegacyBios.h
gEfiLegacyBiosGuid = { 0x2E3044AC, 0x879F, 0x490F, { 0x97, 0x60, 0xBB, 0xDF, 0xAF, 0x69, 0x5F, 0x50 }}
diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
index 949a181a7b..2afda5df79 100644
--- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
+++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
@@ -117,11 +117,10 @@
gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x0f
gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x06
gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000
[Components]
- IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
IntelFrameworkModulePkg/Library/PeiS3Lib/PeiS3Lib.inf
IntelFrameworkModulePkg/Library/PeiRecoveryLib/PeiRecoveryLib.inf
IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
IntelFrameworkModulePkg/Library/SmmRuntimeDxeReportStatusCodeLibFramework/SmmRuntimeDxeReportStatusCodeLibFramework.inf
diff --git a/IntelFrameworkModulePkg/Include/Guid/TianoDecompress.h b/MdeModulePkg/Include/Guid/TianoDecompress.h
similarity index 100%
rename from IntelFrameworkModulePkg/Include/Guid/TianoDecompress.h
rename to MdeModulePkg/Include/Guid/TianoDecompress.h
diff --git a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c
similarity index 100%
rename from IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c
rename to MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c
diff --git a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
similarity index 94%
rename from IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
rename to MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
index ee64fa0d0e..41cc48cd24 100644
--- a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
+++ b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
@@ -33,11 +33,11 @@
BaseUefiTianoCustomDecompressLibInternals.h
BaseUefiTianoCustomDecompressLib.c
[Packages]
MdePkg/MdePkg.dec
- IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
+ MdeModulePkg/MdeModulePkg.dec
[LibraryClasses]
BaseLib
DebugLib
BaseMemoryLib
diff --git a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLibInternals.h b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLibInternals.h
similarity index 100%
rename from IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLibInternals.h
rename to MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLibInternals.h
diff --git a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoDecompressLib.uni b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoDecompressLib.uni
similarity index 100%
rename from IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoDecompressLib.uni
rename to MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoDecompressLib.uni
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 9bbd0572f5..546ec38b9d 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -377,10 +377,14 @@
## GUID indicates the LZMA custom compress/decompress algorithm.
# Include/Guid/LzmaDecompress.h
gLzmaCustomDecompressGuid = { 0xEE4E5898, 0x3914, 0x4259, { 0x9D, 0x6E, 0xDC, 0x7B, 0xD7, 0x94, 0x03, 0xCF }}
gLzmaF86CustomDecompressGuid = { 0xD42AE6BD, 0x1352, 0x4bfb, { 0x90, 0x9A, 0xCA, 0x72, 0xA6, 0xEA, 0xE8, 0x89 }}
+ ## GUID indicates the tiano custom compress/decompress algorithm.
+ # Include/Guid/TianoDecompress.h
+ gTianoCustomDecompressGuid = { 0xA31280AD, 0x481E, 0x41B6, { 0x95, 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }}
+
## Include/Guid/TtyTerm.h
gEfiTtyTermGuid = { 0x7d916d80, 0x5bb1, 0x458c, {0xa4, 0x8f, 0xe2, 0x5f, 0xdd, 0x51, 0xef, 0x94 }}
## Include/Guid/HiiBootMaintenanceFormset.h
gEfiIfrBootMaintenanceGuid = { 0xb2dedc91, 0xd59f, 0x48d2, { 0x89, 0x8a, 0x12, 0x49, 0xc, 0x74, 0xa4, 0xe0 }}
diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
index da2078b8d2..8905ca5814 100644
--- a/MdeModulePkg/MdeModulePkg.dsc
+++ b/MdeModulePkg/MdeModulePkg.dsc
@@ -317,10 +317,11 @@
MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf
MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf
MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.inf
MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.inf
+ MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf
MdeModulePkg/Application/UiApp/UiApp.inf{
<LibraryClasses>
--
2.18.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#55): https://edk2.groups.io/g/devel/message/55
Mute This Topic: https://groups.io/mt/30896393/1498468
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [felixp@ami.com]
-=-=-=-=-=-=-=-=-=-=-=-
Please consider the environment before printing this email.
The information contained in this message may be confidential and proprietary to American Megatrends, Inc. This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [edk2-devel] [patch 5/7] Nt32Pkg: Update to use UefiDecompressLib in MdeModulePkg
2019-04-04 13:52 ` [patch 5/7] Nt32Pkg: Update to use UefiDecompressLib in MdeModulePkg Dandan Bi
@ 2019-04-04 21:21 ` Felix Polyudov
2019-04-05 0:52 ` Dandan Bi
0 siblings, 1 reply; 27+ messages in thread
From: Felix Polyudov @ 2019-04-04 21:21 UTC (permalink / raw)
To: devel@edk2.groups.io, 'dandan.bi@intel.com'; +Cc: Ray Ni, Hao Wu
Dandan,
Is there a specific reason why Nt32Pkg cannot use BaseUefiDecompressLib and should use BaseUefiTianoCustomDecompressLib?
-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Dandan Bi
Sent: Thursday, April 04, 2019 9:52 AM
To: devel@edk2.groups.io
Cc: Ray Ni; Hao Wu
Subject: [edk2-devel] [patch 5/7] Nt32Pkg: Update to use UefiDecompressLib in MdeModulePkg
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
We have moved the BaseUefiTianoCustomDecompressLib
from IntelFrameworkModulePkg to MdeModulePkg, so
update the consumer accordingly.
Cc: Ray Ni <ray.ni@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
Nt32Pkg/Nt32Pkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc
index d7b78007d2..2a7218766d 100644
--- a/Nt32Pkg/Nt32Pkg.dsc
+++ b/Nt32Pkg/Nt32Pkg.dsc
@@ -124,11 +124,11 @@
UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
DevicePathLib|MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDevicePathProtocol.inf
- UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
+ UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
--
2.18.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#56): https://edk2.groups.io/g/devel/message/56
Mute This Topic: https://groups.io/mt/30896396/1498468
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [felixp@ami.com]
-=-=-=-=-=-=-=-=-=-=-=-
Please consider the environment before printing this email.
The information contained in this message may be confidential and proprietary to American Megatrends, Inc. This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
^ permalink raw reply related [flat|nested] 27+ messages in thread
* Re: [edk2-devel] [patch 5/7] Nt32Pkg: Update to use UefiDecompressLib in MdeModulePkg
2019-04-04 21:21 ` [edk2-devel] " Felix Polyudov
@ 2019-04-05 0:52 ` Dandan Bi
0 siblings, 0 replies; 27+ messages in thread
From: Dandan Bi @ 2019-04-05 0:52 UTC (permalink / raw)
To: devel@edk2.groups.io, felixp@ami.com; +Cc: Ni, Ray, Wu, Hao A
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Felix Polyudov
> Sent: Friday, April 05, 2019 5:22 AM
> To: devel@edk2.groups.io; Bi, Dandan <dandan.bi@intel.com>
> Cc: Ni, Ray <ray.ni@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> Subject: Re: [edk2-devel] [patch 5/7] Nt32Pkg: Update to use
> UefiDecompressLib in MdeModulePkg
>
> Dandan,
>
> Is there a specific reason why Nt32Pkg cannot use BaseUefiDecompressLib
> and should use BaseUefiTianoCustomDecompressLib?
Hi ,
Nt32 uses the Tiano Compress algorithm, so it needs to use BaseUefiTianoCustomDecompressLib accordingly.
Thanks,
Dandan
>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Dandan Bi
> Sent: Thursday, April 04, 2019 9:52 AM
> To: devel@edk2.groups.io
> Cc: Ray Ni; Hao Wu
> Subject: [edk2-devel] [patch 5/7] Nt32Pkg: Update to use
> UefiDecompressLib in MdeModulePkg
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
>
> We have moved the BaseUefiTianoCustomDecompressLib from
> IntelFrameworkModulePkg to MdeModulePkg, so update the consumer
> accordingly.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> Nt32Pkg/Nt32Pkg.dsc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Nt32Pkg/Nt32Pkg.dsc b/Nt32Pkg/Nt32Pkg.dsc index
> d7b78007d2..2a7218766d 100644
> --- a/Nt32Pkg/Nt32Pkg.dsc
> +++ b/Nt32Pkg/Nt32Pkg.dsc
> @@ -124,11 +124,11 @@
> UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
>
> UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServic
> esLib.inf
> HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
>
> DevicePathLib|MdePkg/Library/UefiDevicePathLibDevicePathProtocol/Uefi
> DevicePathLibDevicePathProtocol.inf
> -
> UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCust
> omDecompressLib/BaseUefiTianoCustomDecompressLib.inf
> +
> +
> UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompr
> essLi
> + b/BaseUefiTianoCustomDecompressLib.inf
>
> PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLib/Pei
> ServicesTablePointerLib.inf
> PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
> DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
>
> DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTable
> Lib.inf
>
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBoo
> tManagerLib.inf
> --
> 2.18.0.windows.1
>
>
>
>
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and
> proprietary to American Megatrends, Inc. This communication is intended
> to be read only by the individual or entity to whom it is addressed or by
> their designee. If the reader of this message is not the intended recipient,
> you are on notice that any distribution of this message, in any form, is
> strictly prohibited. Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
>
> View/Reply Online (#85): https://edk2.groups.io/g/devel/message/85
> Mute This Topic: https://groups.io/mt/30896396/1768738
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [dandan.bi@intel.com]
> -=-=-=-=-=-=
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [edk2-devel] [patch 4/7] MdeModulePkg: Move BaseUefiTianoCustomDecompressLib to
2019-04-04 21:14 ` felixp
@ 2019-04-05 1:00 ` Dandan Bi
0 siblings, 0 replies; 27+ messages in thread
From: Dandan Bi @ 2019-04-05 1:00 UTC (permalink / raw)
To: devel@edk2.groups.io, felixp@ami.com; +Cc: Gao, Liming, Wang, Jian J, Wu, Hao A
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Felix Polyudov
> Sent: Friday, April 05, 2019 5:15 AM
> To: devel@edk2.groups.io; Bi, Dandan <dandan.bi@intel.com>
> Cc: Gao, Liming <liming.gao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> Subject: Re: [edk2-devel] [patch 4/7] MdeModulePkg: Move
> BaseUefiTianoCustomDecompressLib to
>
> Dandan,
>
> Since UEFI compression and Tiano compression are just different flavors of
> the same algorithm (the same algorithm with different PBit values), I think
> it's better not to have two parallel implementation in
> BaseUefiDecompressLib.c and BaseUefiTianoCustomDecompressLib.c.
> A cleaner approach would be to share the same decompression code
> between two libraries.
Hi,
Thanks for your suggestion. I think code cleanup and sharing is good.
We can do it in next step.
It should not be covered in this move action, we need make patch clean.
Thanks,
Dandan
>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Dandan Bi
> Sent: Thursday, April 04, 2019 9:52 AM
> To: devel@edk2.groups.io
> Cc: Liming Gao; Jian J Wang; Hao Wu
> Subject: [edk2-devel] [patch 4/7] MdeModulePkg: Move
> BaseUefiTianoCustomDecompressLib to
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
>
> We will remove IntelFrameworkModulePkg,
> but BaseUefiTianoCustomDecompressLib may still need to be used. So
> move BaseUefiTianoCustomDecompressLib from
> IntelFrameworkModulePkg to MdeModulePkg.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec | 4 ----
> IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 1 -
> .../Include/Guid/TianoDecompress.h | 0
> .../BaseUefiTianoCustomDecompressLib.c | 0
> .../BaseUefiTianoCustomDecompressLib.inf | 2 +-
> .../BaseUefiTianoCustomDecompressLibInternals.h | 0
> .../BaseUefiTianoDecompressLib.uni | 0
> MdeModulePkg/MdeModulePkg.dec | 4 ++++
> MdeModulePkg/MdeModulePkg.dsc | 1 +
> 9 files changed, 6 insertions(+), 6 deletions(-) rename
> {IntelFrameworkModulePkg =>
> MdeModulePkg}/Include/Guid/TianoDecompress.h (100%) rename
> {IntelFrameworkModulePkg =>
> MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTia
> noCustomDecompressLib.c (100%) rename {IntelFrameworkModulePkg =>
> MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTia
> noCustomDecompressLib.inf (94%) rename {IntelFrameworkModulePkg =>
> MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTia
> noCustomDecompressLibInternals.h (100%) rename
> {IntelFrameworkModulePkg =>
> MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTia
> noDecompressLib.uni (100%)
>
> diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
> b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
> index 5557b5a1cd..0a451dd9ee 100644
> --- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
> +++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
> @@ -40,14 +40,10 @@
>
> ## GUID identifies Data Hub records logged by Status Code Runtime
> Protocol.
> # Include/Guid/DataHubStatusCodeRecord.h
> gEfiDataHubStatusCodeRecordGuid = { 0xD083E94C, 0x6560, 0x42E4,
> { 0xB6, 0xD4, 0x2D, 0xF7, 0x5A, 0xDF, 0x6A, 0x2A }}
>
> - ## GUID indicates the tiano custom compress/decompress algorithm.
> - # Include/Guid/TianoDecompress.h
> - gTianoCustomDecompressGuid = { 0xA31280AD, 0x481E, 0x41B6,
> { 0x95, 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }}
> -
> ## Include/Guid/AcpiVariable.h
> gEfiAcpiVariableCompatiblityGuid = { 0xc020489e, 0x6db2, 0x4ef2,
> { 0x9a, 0xa5, 0xca, 0x6, 0xfc, 0x11, 0xd3, 0x6a }}
>
> ## Include/Guid/LegacyBios.h
> gEfiLegacyBiosGuid = { 0x2E3044AC, 0x879F, 0x490F, { 0x97,
> 0x60, 0xBB, 0xDF, 0xAF, 0x69, 0x5F, 0x50 }}
> diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
> b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
> index 949a181a7b..2afda5df79 100644
> --- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
> +++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
> @@ -117,11 +117,10 @@
> gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x0f
> gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x06
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000
>
> [Components]
> -
> IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/B
> aseUefiTianoCustomDecompressLib.inf
>
> IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCusto
> mDecompressLib.inf
> IntelFrameworkModulePkg/Library/PeiS3Lib/PeiS3Lib.inf
> IntelFrameworkModulePkg/Library/PeiRecoveryLib/PeiRecoveryLib.inf
>
> IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/Dx
> eReportStatusCodeLib.inf
>
> IntelFrameworkModulePkg/Library/SmmRuntimeDxeReportStatusCodeLibF
> ramework/SmmRuntimeDxeReportStatusCodeLibFramework.inf
> diff --git a/IntelFrameworkModulePkg/Include/Guid/TianoDecompress.h
> b/MdeModulePkg/Include/Guid/TianoDecompress.h
> similarity index 100%
> rename from IntelFrameworkModulePkg/Include/Guid/TianoDecompress.h
> rename to MdeModulePkg/Include/Guid/TianoDecompress.h
> diff --git
> a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib
> /BaseUefiTianoCustomDecompressLib.c
> b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi
> anoCustomDecompressLib.c
> similarity index 100%
> rename from
> IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/B
> aseUefiTianoCustomDecompressLib.c
> rename to
> MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian
> oCustomDecompressLib.c
> diff --git
> a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib
> /BaseUefiTianoCustomDecompressLib.inf
> b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi
> anoCustomDecompressLib.inf
> similarity index 94%
> rename from
> IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/B
> aseUefiTianoCustomDecompressLib.inf
> rename to
> MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian
> oCustomDecompressLib.inf
> index ee64fa0d0e..41cc48cd24 100644
> ---
> a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib
> /BaseUefiTianoCustomDecompressLib.inf
> +++
> b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi
> an
> +++ oCustomDecompressLib.inf
> @@ -33,11 +33,11 @@
> BaseUefiTianoCustomDecompressLibInternals.h
> BaseUefiTianoCustomDecompressLib.c
>
> [Packages]
> MdePkg/MdePkg.dec
> - IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
> + MdeModulePkg/MdeModulePkg.dec
>
> [LibraryClasses]
> BaseLib
> DebugLib
> BaseMemoryLib
> diff --git
> a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib
> /BaseUefiTianoCustomDecompressLibInternals.h
> b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi
> anoCustomDecompressLibInternals.h
> similarity index 100%
> rename from
> IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/B
> aseUefiTianoCustomDecompressLibInternals.h
> rename to
> MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian
> oCustomDecompressLibInternals.h
> diff --git
> a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib
> /BaseUefiTianoDecompressLib.uni
> b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi
> anoDecompressLib.uni
> similarity index 100%
> rename from
> IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/B
> aseUefiTianoDecompressLib.uni
> rename to
> MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian
> oDecompressLib.uni
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec index 9bbd0572f5..546ec38b9d
> 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -377,10 +377,14 @@
> ## GUID indicates the LZMA custom compress/decompress algorithm.
> # Include/Guid/LzmaDecompress.h
> gLzmaCustomDecompressGuid = { 0xEE4E5898, 0x3914, 0x4259,
> { 0x9D, 0x6E, 0xDC, 0x7B, 0xD7, 0x94, 0x03, 0xCF }}
> gLzmaF86CustomDecompressGuid = { 0xD42AE6BD, 0x1352, 0x4bfb,
> { 0x90, 0x9A, 0xCA, 0x72, 0xA6, 0xEA, 0xE8, 0x89 }}
>
> + ## GUID indicates the tiano custom compress/decompress algorithm.
> + # Include/Guid/TianoDecompress.h
> + gTianoCustomDecompressGuid = { 0xA31280AD, 0x481E, 0x41B6,
> { 0x95, 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }}
> +
> ## Include/Guid/TtyTerm.h
> gEfiTtyTermGuid = { 0x7d916d80, 0x5bb1, 0x458c, {0xa4, 0x8f,
> 0xe2, 0x5f, 0xdd, 0x51, 0xef, 0x94 }}
>
> ## Include/Guid/HiiBootMaintenanceFormset.h
> gEfiIfrBootMaintenanceGuid = { 0xb2dedc91, 0xd59f, 0x48d2, { 0x89,
> 0x8a, 0x12, 0x49, 0xc, 0x74, 0xa4, 0xe0 }}
> diff --git a/MdeModulePkg/MdeModulePkg.dsc
> b/MdeModulePkg/MdeModulePkg.dsc index da2078b8d2..8905ca5814
> 100644
> --- a/MdeModulePkg/MdeModulePkg.dsc
> +++ b/MdeModulePkg/MdeModulePkg.dsc
> @@ -317,10 +317,11 @@
> MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf
>
> MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscove
> rableDeviceRegistrationLib.inf
> MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf
>
> MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdate
> ProgressLibGraphics.inf
>
> MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgr
> essLibText.inf
> +
> +
> MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian
> oCus
> + tomDecompressLib.inf
>
> MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
>
> MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuA
> pp.inf
> MdeModulePkg/Application/UiApp/UiApp.inf{
> <LibraryClasses>
> --
> 2.18.0.windows.1
>
>
>
>
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and
> proprietary to American Megatrends, Inc. This communication is intended
> to be read only by the individual or entity to whom it is addressed or by
> their designee. If the reader of this message is not the intended recipient,
> you are on notice that any distribution of this message, in any form, is
> strictly prohibited. Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
>
> View/Reply Online (#84): https://edk2.groups.io/g/devel/message/84
> Mute This Topic: https://groups.io/mt/30896393/1768738
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [dandan.bi@intel.com]
> -=-=-=-=-=-=
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [edk2-devel] [patch 2/7] BeagleBoardPkg: Update UefiDecompressLib instance
2019-04-04 15:26 ` Ard Biesheuvel
@ 2019-04-05 1:03 ` Dandan Bi
0 siblings, 0 replies; 27+ messages in thread
From: Dandan Bi @ 2019-04-05 1:03 UTC (permalink / raw)
To: devel@edk2.groups.io, ard.biesheuvel@linaro.org; +Cc: Leif Lindholm
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ard Biesheuvel
> Sent: Thursday, April 04, 2019 11:27 PM
> To: Bi, Dandan <dandan.bi@intel.com>
> Cc: devel@edk2.groups.io; Leif Lindholm <leif.lindholm@linaro.org>
> Subject: Re: [edk2-devel] [patch 2/7] BeagleBoardPkg: Update
> UefiDecompressLib instance
>
> On Thu, 4 Apr 2019 at 20:52, Dandan Bi <dandan.bi@intel.com> wrote:
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
> >
> > BaseUefiDecompressLib in MdePkg is the base UEFI decompress Library.
> > BaseUefiTianoCustomDecompressLib in IntelFrameworkModulePkg
> implements
> > the base UEFI decompress functionality and Tiano decompress
> > functionality.
> >
> > 1. TIANOCOMPRESSED rule in BeagleBoardPkg.fdf is not used, so remove
> > it.
> > 2. Platform doesn't use the TianoCompress, so do not have to use
> > BaseUefiTianoCustomDecompressLib, can use the BaseUefiDecompressLib
> in
> > MdePkg directly.
> >
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> > ---
> > BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++--
> > BeagleBoardPkg/BeagleBoardPkg.fdf | 9 ---------
> > 2 files changed, 2 insertions(+), 11 deletions(-)
> >
> > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc
> > b/BeagleBoardPkg/BeagleBoardPkg.dsc
> > index e0fee3692f..e5fbe7eeb2 100644
> > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc
> > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc
> > @@ -185,17 +185,17 @@
> >
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerforma
> nceLib.inf
> >
> >
> NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscove
> ra
> > bleDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
> >
> > [LibraryClasses.common.UEFI_APPLICATION]
> >
> >
> ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatus
> Cod
> > eLibFramework/DxeReportStatusCodeLib.inf
> > -
> >
> UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCust
> omD
> > ecompressLib/BaseUefiTianoCustomDecompressLib.inf
> > +
> > +
> UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco
> m
> > + pressLib.inf
> >
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerforma
> nceLib.inf
> > HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
> >
> > [LibraryClasses.common.UEFI_DRIVER]
> >
> >
> ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatus
> Cod
> > eLibFramework/DxeReportStatusCodeLib.inf
> > -
> >
> UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCust
> omD
> > ecompressLib/BaseUefiTianoCustomDecompressLib.inf
> > +
> > +
> UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco
> m
> > + pressLib.inf
> >
> ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/Dxe
> ExtractGuidedSectionLib.inf
> >
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerforma
> nceLib.inf
> > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> >
> > [LibraryClasses.common.DXE_RUNTIME_DRIVER]
>
> Can we add a single UefiDecompressLib resolution to the common section
> and drop all the others?
Yes, I will cover this in V2 and pick up your Reviewed-by.
Thanks,
Dandan
>
> > diff --git a/BeagleBoardPkg/BeagleBoardPkg.fdf
> > b/BeagleBoardPkg/BeagleBoardPkg.fdf
> > index 42d6bad0c7..9c9cecf894 100644
> > --- a/BeagleBoardPkg/BeagleBoardPkg.fdf
> > +++ b/BeagleBoardPkg/BeagleBoardPkg.fdf
> > @@ -262,19 +262,10 @@ READ_LOCK_STATUS = TRUE
> > PEI_DEPEX PEI_DEPEX Optional
> $(INF_OUTPUT)/$(MODULE_NAME).depex
> > PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi
> > UI STRING="$(MODULE_NAME)" Optional
> > }
> >
> > -[Rule.Common.PEIM.TIANOCOMPRESSED]
> > - FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 {
> > - PEI_DEPEX PEI_DEPEX Optional
> $(INF_OUTPUT)/$(MODULE_NAME).depex
> > - GUIDED A31280AD-481E-41B6-95E8-127F4C984779
> PROCESSING_REQUIRED = TRUE {
> > - PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi
> > - UI STRING="$(MODULE_NAME)" Optional
> > - }
> > - }
> > -
> > [Rule.Common.DXE_CORE]
> > FILE DXE_CORE = $(NAMED_GUID) {
> > PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi
> > UI STRING="$(MODULE_NAME)" Optional
> > }
> > --
> > 2.18.0.windows.1
> >
>
> With the above update:
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [patch 1/7] ArmVirtPkg: Update UefiDecompressLib instance
2019-04-04 14:57 ` Laszlo Ersek
@ 2019-04-05 1:10 ` Dandan Bi
0 siblings, 0 replies; 27+ messages in thread
From: Dandan Bi @ 2019-04-05 1:10 UTC (permalink / raw)
To: Laszlo Ersek, devel@edk2.groups.io; +Cc: Ard Biesheuvel, Julien Grall
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Thursday, April 04, 2019 10:58 PM
> To: Bi, Dandan <dandan.bi@intel.com>; devel@edk2.groups.io
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Julien Grall
> <julien.grall@arm.com>
> Subject: Re: [patch 1/7] ArmVirtPkg: Update UefiDecompressLib instance
>
> On 04/04/19 15:52, Dandan Bi wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
> >
> > BaseUefiDecompressLib in MdePkg is the base UEFI decompress Library.
> > BaseUefiTianoCustomDecompressLib in IntelFrameworkModulePkg
> implements
> > the base UEFI decompress functionality and Tiano decompress
> > functionality.
> >
> > 1. TIANOCOMPRESSED rule in ArmVirtRules.fdf.inc is not used, so remove
> > it.
>
> That's correct, the only FDF files that refer to any TIANOCOMPRESSED rules,
> with RuleOverride, are:
>
> - Nt32Pkg.fdf (for EnglishDxe.inf)
> - Quark.fdf (for Shell.inf)
>
> And the GUID in the rule being removed, A31280AD-481E-41B6-95E8-
> 127F4C984779, is indeed gTianoCustomDecompressGuid.
>
> > 2. Platform doesn't use the TianoCompress, so do not have to use
> > BaseUefiTianoCustomDecompressLib, can use the BaseUefiDecompressLib
> in
> > MdePkg directly.
>
> It looks like we have the following guid-ed section extractors in edk2:
>
> BrotliCustomDecompress 3D532050-5CDA-4FD0-879E-
> 0F7F630D5AFB
> EfiCertTypeRsa2048Sha256 A7717414-C616-4977-9420-
> 844712A735BF
> EfiCrc32GuidedSectionExtraction FC1BCDB0-7D31-49AA-936A-
> A4600D9DD083
> LzmaCustomDecompress EE4E5898-3914-4259-9D6E-
> DC7BD79403CF
> LzmaF86CustomDecompress D42AE6BD-1352-4BFB-909A-
> CA72A6EAE889
> TianoCustomDecompress A31280AD-481E-41B6-95E8-
> 127F4C984779
>
> (with the leading "g" and trailing "Guid" stripped).
>
> In order to see whether a platform uses an algorithm for section encoding,
> we should grep that platform's FDF files for the algorithm's GUID directly...
> And, indeed, under ArmVirtPkg, the only mention of A31280AD-481E-41B6-
> 95E8-127F4C984779 is in the (unused) rule that's being removed.
>
> The one algorithm that ArmVirtPkg does use, for section encoding, is
> LzmaCustomDecompress. For that, we have
> "MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecomp
> ressLib.inf" resolutions in place already.
>
> So what needs UefiDecompressLib at all? ... Aha, both of these:
> - MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf
> - MdeModulePkg/Core/Dxe/DxeMain.inf
>
> That's a good argument for preserving the lib class resolution at all.
>
> I've compared "BaseUefiTianoCustomDecompressLib.c" to
> "BaseUefiDecompressLib.c". The main differences are:
>
> * the latter has no constructor that registers a guid-ed section extractor --
> and that's fine here, because in the code modified by this patch, the lib
> instance is not hooked into another module via NULL resolution,
>
> * the following hunk:
>
> //
> // The length of the field 'Position Set Code Length Array Size' in Block
> Header.
> // For UEFI 2.0 de/compression algorithm(Version 1), mPBit = 4
> - // For Tiano de/compression algorithm(Version 2), mPBit = 5
> //
> - switch (Version) {
> - case 1 :
> - Sd->mPBit = 4;
> - break;
> - case 2 :
> - Sd->mPBit = 5;
> - break;
> - default:
> - ASSERT (FALSE);
> - }
> + Sd->mPBit = 4;
>
> So, let's see the patch:
>
> >
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Julien Grall <julien.grall@arm.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> > ---
> > ArmVirtPkg/ArmVirt.dsc.inc | 4 ++--
> > ArmVirtPkg/ArmVirtRules.fdf.inc | 9 ---------
> > 2 files changed, 2 insertions(+), 11 deletions(-)
> >
> > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> > index d172a082c9..556ec0dcb1 100644
> > --- a/ArmVirtPkg/ArmVirt.dsc.inc
> > +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> > @@ -223,17 +223,17 @@
> >
> SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagement
> Lib/DxeSecurityManagementLib.inf
> >
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerforma
> nceLib.inf
> >
> >
> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMem
> oryA
> > llocationLib.inf
> >
> > [LibraryClasses.common.UEFI_APPLICATION]
> > -
> >
> UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCust
> omD
> > ecompressLib/BaseUefiTianoCustomDecompressLib.inf
> > +
> > +
> UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco
> m
> > + pressLib.inf
> >
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerforma
> nceLib.inf
> >
> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMem
> oryAllocationLib.inf
> > HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
> >
> > [LibraryClasses.common.UEFI_DRIVER]
> > -
> >
> UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCust
> omD
> > ecompressLib/BaseUefiTianoCustomDecompressLib.inf
> > +
> > +
> UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco
> m
> > + pressLib.inf
> >
> ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/Dxe
> ExtractGuidedSectionLib.inf
> >
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerforma
> nceLib.inf
> >
> >
> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMem
> oryA
> > llocationLib.inf
> >
> > [LibraryClasses.common.DXE_RUNTIME_DRIVER]
> > diff --git a/ArmVirtPkg/ArmVirtRules.fdf.inc
> > b/ArmVirtPkg/ArmVirtRules.fdf.inc index 5ff3004786..bed06364e1
> 100644
> > --- a/ArmVirtPkg/ArmVirtRules.fdf.inc
> > +++ b/ArmVirtPkg/ArmVirtRules.fdf.inc
> > @@ -56,19 +56,10 @@
> > PEI_DEPEX PEI_DEPEX Optional
> $(INF_OUTPUT)/$(MODULE_NAME).depex
> > TE TE Align = Auto $(INF_OUTPUT)/$(MODULE_NAME).efi
> > UI STRING="$(MODULE_NAME)" Optional
> > }
> >
> > -[Rule.Common.PEIM.TIANOCOMPRESSED]
> > - FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 {
> > - PEI_DEPEX PEI_DEPEX Optional
> $(INF_OUTPUT)/$(MODULE_NAME).depex
> > - GUIDED A31280AD-481E-41B6-95E8-127F4C984779
> PROCESSING_REQUIRED = TRUE {
> > - PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi
> > - UI STRING="$(MODULE_NAME)" Optional
> > - }
> > - }
> > -
> > [Rule.Common.DXE_CORE]
> > FILE DXE_CORE = $(NAMED_GUID) {
> > PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi
> > UI STRING="$(MODULE_NAME)" Optional
> > }
> >
>
> The patch seems good, but we could improve it: in "ArmVirtPkg", we
> already have the following UefiDecompressLib resolutions:
>
> ArmVirt.dsc.inc:44:
> UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco
> mpressLib.inf
> ArmVirt.dsc.inc:192:
> UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco
> mpressLib.inf
> ArmVirt.dsc.inc:208:
> UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco
> mpressLib.inf
> ArmVirt.dsc.inc:219:
> UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco
> mpressLib.inf
> ArmVirt.dsc.inc:228:
> UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCust
> omDecompressLib/BaseUefiTianoCustomDecompressLib.inf
> ArmVirt.dsc.inc:234:
> UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCust
> omDecompressLib/BaseUefiTianoCustomDecompressLib.inf
>
> On line 44, the resolution is for [LibraryClasses.common]. So, rather than
> multiplying the same resolution for UEFI_APPLICATION and UEFI_DRIVER
> too, I suggest removing *all* the resolutions, except the one on line 44 (i.e.,
> in section [LibraryClasses.common]).
Thanks for your suggestion.
I had planned to leave one UefiDecompressLib resolution in common section before, but then gave up since didn't want to touch too much platform update.
I will cover this update in V2.
Thanks,
Dandan
>
> The commit message needs a minimal change only -- please append a
> sentence about the default resolution being right already, and relying on
> that for all module types.
>
> The "ArmVirtRules.fdf.inc" hunk is good as-is, of course.
>
> Thanks!
> Laszlo
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [edk2-devel] [patch 4/7] MdeModulePkg: Move BaseUefiTianoCustomDecompressLib to
2019-04-04 14:21 ` [edk2-devel] " Laszlo Ersek
@ 2019-04-05 1:21 ` Dandan Bi
0 siblings, 0 replies; 27+ messages in thread
From: Dandan Bi @ 2019-04-05 1:21 UTC (permalink / raw)
To: Laszlo Ersek, devel@edk2.groups.io; +Cc: Gao, Liming, Wang, Jian J, Wu, Hao A
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Thursday, April 04, 2019 10:21 PM
> To: devel@edk2.groups.io; Bi, Dandan <dandan.bi@intel.com>
> Cc: Gao, Liming <liming.gao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> Subject: Re: [edk2-devel] [patch 4/7] MdeModulePkg: Move
> BaseUefiTianoCustomDecompressLib to
>
> On 04/04/19 15:52, Dandan Bi wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
> >
> > We will remove IntelFrameworkModulePkg, but
> > BaseUefiTianoCustomDecompressLib may still need to be used. So move
> > BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to
> > MdeModulePkg.
> >
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Hao Wu <hao.a.wu@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> > ---
> > IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec | 4 ----
> > IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 1 -
> > .../Include/Guid/TianoDecompress.h | 0
> > .../BaseUefiTianoCustomDecompressLib.c | 0
> > .../BaseUefiTianoCustomDecompressLib.inf | 2 +-
> > .../BaseUefiTianoCustomDecompressLibInternals.h | 0
> > .../BaseUefiTianoDecompressLib.uni | 0
> > MdeModulePkg/MdeModulePkg.dec | 4 ++++
> > MdeModulePkg/MdeModulePkg.dsc | 1 +
> > 9 files changed, 6 insertions(+), 6 deletions(-) rename
> > {IntelFrameworkModulePkg =>
> > MdeModulePkg}/Include/Guid/TianoDecompress.h (100%) rename
> > {IntelFrameworkModulePkg =>
> >
> MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTia
> noCu
> > stomDecompressLib.c (100%) rename {IntelFrameworkModulePkg =>
> >
> MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTia
> noCu
> > stomDecompressLib.inf (94%) rename {IntelFrameworkModulePkg =>
> >
> MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTia
> noCu
> > stomDecompressLibInternals.h (100%) rename
> {IntelFrameworkModulePkg
> > =>
> >
> MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTia
> noDe
> > compressLib.uni (100%)
> >
> > diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
> > b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
> > index 5557b5a1cd..0a451dd9ee 100644
> > --- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
> > +++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
> > @@ -40,14 +40,10 @@
> >
> > ## GUID identifies Data Hub records logged by Status Code Runtime
> Protocol.
> > # Include/Guid/DataHubStatusCodeRecord.h
> > gEfiDataHubStatusCodeRecordGuid = { 0xD083E94C, 0x6560, 0x42E4, {
> > 0xB6, 0xD4, 0x2D, 0xF7, 0x5A, 0xDF, 0x6A, 0x2A }}
> >
> > - ## GUID indicates the tiano custom compress/decompress algorithm.
> > - # Include/Guid/TianoDecompress.h
> > - gTianoCustomDecompressGuid = { 0xA31280AD, 0x481E, 0x41B6,
> { 0x95, 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }}
> > -
> > ## Include/Guid/AcpiVariable.h
> > gEfiAcpiVariableCompatiblityGuid = { 0xc020489e, 0x6db2, 0x4ef2,
> { 0x9a, 0xa5, 0xca, 0x6, 0xfc, 0x11, 0xd3, 0x6a }}
> >
> > ## Include/Guid/LegacyBios.h
> > gEfiLegacyBiosGuid = { 0x2E3044AC, 0x879F, 0x490F, { 0x97,
> 0x60, 0xBB, 0xDF, 0xAF, 0x69, 0x5F, 0x50 }}
> > diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
> > b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
> > index 949a181a7b..2afda5df79 100644
> > --- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
> > +++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc
> > @@ -117,11 +117,10 @@
> > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x0f
> > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x06
> > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000
> >
> > [Components]
> > -
> IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/B
> aseUefiTianoCustomDecompressLib.inf
> >
> IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCusto
> mDecompressLib.inf
> > IntelFrameworkModulePkg/Library/PeiS3Lib/PeiS3Lib.inf
> > IntelFrameworkModulePkg/Library/PeiRecoveryLib/PeiRecoveryLib.inf
> >
> IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/Dx
> eReportStatusCodeLib.inf
> >
> >
> IntelFrameworkModulePkg/Library/SmmRuntimeDxeReportStatusCodeLibF
> ramew
> > ork/SmmRuntimeDxeReportStatusCodeLibFramework.inf
> > diff --git a/IntelFrameworkModulePkg/Include/Guid/TianoDecompress.h
> > b/MdeModulePkg/Include/Guid/TianoDecompress.h
> > similarity index 100%
> > rename from
> IntelFrameworkModulePkg/Include/Guid/TianoDecompress.h
> > rename to MdeModulePkg/Include/Guid/TianoDecompress.h
> > diff --git
> >
> a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib
> /Bas
> > eUefiTianoCustomDecompressLib.c
> >
> b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi
> anoC
> > ustomDecompressLib.c
> > similarity index 100%
> > rename from
> >
> IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/B
> aseU
> > efiTianoCustomDecompressLib.c rename to
> >
> MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian
> oCus
> > tomDecompressLib.c diff --git
> >
> a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib
> /Bas
> > eUefiTianoCustomDecompressLib.inf
> >
> b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi
> anoC
> > ustomDecompressLib.inf
> > similarity index 94%
> > rename from
> >
> IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/B
> aseU
> > efiTianoCustomDecompressLib.inf rename to
> >
> MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian
> oCus
> > tomDecompressLib.inf
> > index ee64fa0d0e..41cc48cd24 100644
> > ---
> >
> a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib
> /Bas
> > eUefiTianoCustomDecompressLib.inf
> > +++
> b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi
> > +++ anoCustomDecompressLib.inf
> > @@ -33,11 +33,11 @@
> > BaseUefiTianoCustomDecompressLibInternals.h
> > BaseUefiTianoCustomDecompressLib.c
> >
> > [Packages]
> > MdePkg/MdePkg.dec
> > - IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
> > + MdeModulePkg/MdeModulePkg.dec
> >
> > [LibraryClasses]
> > BaseLib
> > DebugLib
> > BaseMemoryLib
> > diff --git
> >
> a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib
> /Bas
> > eUefiTianoCustomDecompressLibInternals.h
> >
> b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi
> anoC
> > ustomDecompressLibInternals.h
> > similarity index 100%
> > rename from
> >
> IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/B
> aseU
> > efiTianoCustomDecompressLibInternals.h
> > rename to
> >
> MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian
> oCus
> > tomDecompressLibInternals.h diff --git
> >
> a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib
> /Bas
> > eUefiTianoDecompressLib.uni
> >
> b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi
> anoD
> > ecompressLib.uni
> > similarity index 100%
> > rename from
> >
> IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/B
> aseU
> > efiTianoDecompressLib.uni rename to
> >
> MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian
> oDec
> > ompressLib.uni diff --git a/MdeModulePkg/MdeModulePkg.dec
> > b/MdeModulePkg/MdeModulePkg.dec index 9bbd0572f5..546ec38b9d
> 100644
> > --- a/MdeModulePkg/MdeModulePkg.dec
> > +++ b/MdeModulePkg/MdeModulePkg.dec
> > @@ -377,10 +377,14 @@
> > ## GUID indicates the LZMA custom compress/decompress algorithm.
> > # Include/Guid/LzmaDecompress.h
> > gLzmaCustomDecompressGuid = { 0xEE4E5898, 0x3914, 0x4259,
> { 0x9D, 0x6E, 0xDC, 0x7B, 0xD7, 0x94, 0x03, 0xCF }}
> > gLzmaF86CustomDecompressGuid = { 0xD42AE6BD, 0x1352, 0x4bfb,
> { 0x90, 0x9A, 0xCA, 0x72, 0xA6, 0xEA, 0xE8, 0x89 }}
> >
> > + ## GUID indicates the tiano custom compress/decompress algorithm.
> > + # Include/Guid/TianoDecompress.h
> > + gTianoCustomDecompressGuid = { 0xA31280AD, 0x481E, 0x41B6,
> { 0x95, 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }}
> > +
> > ## Include/Guid/TtyTerm.h
> > gEfiTtyTermGuid = { 0x7d916d80, 0x5bb1, 0x458c, {0xa4, 0x8f,
> 0xe2, 0x5f, 0xdd, 0x51, 0xef, 0x94 }}
> >
> > ## Include/Guid/HiiBootMaintenanceFormset.h
> > gEfiIfrBootMaintenanceGuid = { 0xb2dedc91, 0xd59f, 0x48d2, { 0x89,
> 0x8a, 0x12, 0x49, 0xc, 0x74, 0xa4, 0xe0 }}
> > diff --git a/MdeModulePkg/MdeModulePkg.dsc
> > b/MdeModulePkg/MdeModulePkg.dsc index da2078b8d2..8905ca5814
> 100644
> > --- a/MdeModulePkg/MdeModulePkg.dsc
> > +++ b/MdeModulePkg/MdeModulePkg.dsc
> > @@ -317,10 +317,11 @@
> > MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf
> >
> MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscove
> rableDeviceRegistrationLib.inf
> > MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf
> >
> MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdate
> ProgressLibGraphics.inf
> >
> >
> MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgr
> es
> > sLibText.inf
> > +
> > +
> MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian
> oC
> > + ustomDecompressLib.inf
> >
> > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> >
> MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuA
> pp.inf
> > MdeModulePkg/Application/UiApp/UiApp.inf{
> > <LibraryClasses>
> >
>
> I think that, if you do a rename like this, then the packages in the rest of the
> series will break, temporarily. If the maintainers of Nt32Pkg, Quark, and
> Vlv2 are OK with that, I don't mind, but normally you'd create a copy first,
> then update the references to the copy, then remove the original.
Yeah, you are right, it will break temporarily.
And we also thought the solution to copy one firstly and then remove the original one , but this may loss the historical commit log.
So we choose this sample rename solution to keep the history commit log. Since it will not break build with whole patch set.
Anyway I will collect the comments from the owner of the impacted platforms.
Thanks,
Dandan
>
> Thanks
> Laszlo
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [patch 7/7] Vlv2TbltDevicePkg: Update to use UefiDecompressLib in MdeModulePkg
2019-04-04 13:52 ` [patch 7/7] Vlv2TbltDevicePkg: " Dandan Bi
@ 2019-04-08 3:30 ` Qian, Yi
0 siblings, 0 replies; 27+ messages in thread
From: Qian, Yi @ 2019-04-08 3:30 UTC (permalink / raw)
To: Bi, Dandan, devel@edk2.groups.io; +Cc: Sun, Zailiang
Reviewed by Qian, Yi<yi.qian@intel.com>
Thanks
Qian Yi
> -----Original Message-----
> From: Bi, Dandan
> Sent: Thursday, April 04, 2019 9:52 PM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: [patch 7/7] Vlv2TbltDevicePkg: Update to use UefiDecompressLib in
> MdeModulePkg
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683
>
> We have moved the BaseUefiTianoCustomDecompressLib from
> IntelFrameworkModulePkg to MdeModulePkg, so update the consumer
> accordingly.
>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 2 +-
> Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 2 +-
> Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> index ac401c4826..3b4c7ec579 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc
> @@ -136,11 +136,11 @@
> UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
>
> UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiService
> sLib.inf
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> -
> UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCusto
> mDecompressLib/BaseUefiTianoCustomDecompressLib.inf
> +
> +
> UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompr
> essLi
> + b/BaseUefiTianoCustomDecompressLib.inf
>
> PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/P
> eiServicesTablePointerLibIdt.inf
> PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
> DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
>
> DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTabl
> eLib.inf
> UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> index 0b5b976d61..ba5ad53293 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc
> @@ -136,11 +136,11 @@
> UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
>
> UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiService
> sLib.inf
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> -
> UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCusto
> mDecompressLib/BaseUefiTianoCustomDecompressLib.inf
> +
> +
> UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompr
> essLi
> + b/BaseUefiTianoCustomDecompressLib.inf
>
> PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/P
> eiServicesTablePointerLibIdt.inf
> PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
> DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
>
> DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTabl
> eLib.inf
> UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
> diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> index 1940aead03..c9c9ee8af6 100644
> --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc
> @@ -136,11 +136,11 @@
> UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
>
> UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiService
> sLib.inf
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> -
> UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCusto
> mDecompressLib/BaseUefiTianoCustomDecompressLib.inf
> +
> +
> UefiDecompressLib|MdeModulePkg/Library/BaseUefiTianoCustomDecompr
> essLi
> + b/BaseUefiTianoCustomDecompressLib.inf
>
> PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/P
> eiServicesTablePointerLibIdt.inf
> PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf
> DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
>
> DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTabl
> eLib.inf
> UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg
2019-04-04 13:52 [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg dandan.bi
` (6 preceding siblings ...)
2019-04-04 13:52 ` [patch 7/7] Vlv2TbltDevicePkg: " Dandan Bi
@ 2019-04-23 16:26 ` Ard Biesheuvel
2019-04-23 23:13 ` [edk2-devel] " Dandan Bi
2019-04-24 9:52 ` Laszlo Ersek
7 siblings, 2 replies; 27+ messages in thread
From: Ard Biesheuvel @ 2019-04-23 16:26 UTC (permalink / raw)
To: Dandan Bi
Cc: edk2-devel-groups-io, Laszlo Ersek, Julien Grall, Leif Lindholm,
Jordan Justen, Andrew Fish, Liming Gao, Ray Ni, Jian J Wang,
Hao Wu, Michael D Kinney, Kelly Steele, Zailiang Sun, Yi Qian
On Thu, 4 Apr 2019 at 15:52, Dandan Bi <dandan.bi@intel.com> wrote:
>
> We will remove IntelFrameworkModulePkg,but BaseUefiTianoCustomDecompressLib in it
> may still need to be used. So move BaseUefiTianoCustomDecompressLib from
> IntelFrameworkModulePkg to MdeModulePkg firstly.
>
The following platforms are now broken in edk2-platforms/master since
they still refer to BaseUefiTianoCustomDecompressLib in the old
location:
AMD Overdrive
Lemaker Cello
Raspberry Pi3
SoftIron 1000
D03/D05/D06
Hikey/Hikey960
Could we please try not to leave edk2-platforms behind when making
changes to the core repository? Thanks.
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [edk2-devel] [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg
2019-04-23 16:26 ` [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg Ard Biesheuvel
@ 2019-04-23 23:13 ` Dandan Bi
2019-04-24 9:52 ` Laszlo Ersek
1 sibling, 0 replies; 27+ messages in thread
From: Dandan Bi @ 2019-04-23 23:13 UTC (permalink / raw)
To: devel@edk2.groups.io, ard.biesheuvel@linaro.org
Cc: Laszlo Ersek, Julien Grall, Leif Lindholm, Justen, Jordan L,
Andrew Fish, Gao, Liming, Ni, Ray, Wang, Jian J, Wu, Hao A,
Kinney, Michael D, Steele, Kelly, Sun, Zailiang, Qian, Yi
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ard Biesheuvel
> Sent: Wednesday, April 24, 2019 12:26 AM
> To: Bi, Dandan <dandan.bi@intel.com>
> Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Laszlo Ersek
> <lersek@redhat.com>; Julien Grall <julien.grall@arm.com>; Leif Lindholm
> <leif.lindholm@linaro.org>; Justen, Jordan L <jordan.l.justen@intel.com>;
> Andrew Fish <afish@apple.com>; Gao, Liming <liming.gao@intel.com>; Ni,
> Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
> <hao.a.wu@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Steele, Kelly <kelly.steele@intel.com>; Sun, Zailiang
> <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: Re: [edk2-devel] [patch 0/7] Move
> BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to
> MdeModulePkg
>
> On Thu, 4 Apr 2019 at 15:52, Dandan Bi <dandan.bi@intel.com> wrote:
> >
> > We will remove IntelFrameworkModulePkg,but
> > BaseUefiTianoCustomDecompressLib in it may still need to be used. So
> > move BaseUefiTianoCustomDecompressLib from
> IntelFrameworkModulePkg to MdeModulePkg firstly.
> >
>
> The following platforms are now broken in edk2-platforms/master since they
> still refer to BaseUefiTianoCustomDecompressLib in the old
> location:
>
> AMD Overdrive
> Lemaker Cello
> Raspberry Pi3
> SoftIron 1000
> D03/D05/D06
> Hikey/Hikey960
>
> Could we please try not to leave edk2-platforms behind when making
> changes to the core repository? Thanks.
Sorry for missing checking the edk2-platforms/master when making the changes.
I will submit patch to fix the issue.
Thanks,
Dandan
>
>
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg
2019-04-23 16:26 ` [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg Ard Biesheuvel
2019-04-23 23:13 ` [edk2-devel] " Dandan Bi
@ 2019-04-24 9:52 ` Laszlo Ersek
2019-04-24 12:46 ` Liming Gao
1 sibling, 1 reply; 27+ messages in thread
From: Laszlo Ersek @ 2019-04-24 9:52 UTC (permalink / raw)
To: Ard Biesheuvel, Dandan Bi
Cc: edk2-devel-groups-io, Julien Grall, Leif Lindholm, Jordan Justen,
Andrew Fish, Liming Gao, Ray Ni, Jian J Wang, Hao Wu,
Michael D Kinney, Kelly Steele, Zailiang Sun, Yi Qian
On 04/23/19 18:26, Ard Biesheuvel wrote:
> On Thu, 4 Apr 2019 at 15:52, Dandan Bi <dandan.bi@intel.com> wrote:
>>
>> We will remove IntelFrameworkModulePkg,but BaseUefiTianoCustomDecompressLib in it
>> may still need to be used. So move BaseUefiTianoCustomDecompressLib from
>> IntelFrameworkModulePkg to MdeModulePkg firstly.
>>
>
> The following platforms are now broken in edk2-platforms/master since
> they still refer to BaseUefiTianoCustomDecompressLib in the old
> location:
>
> AMD Overdrive
> Lemaker Cello
> Raspberry Pi3
> SoftIron 1000
> D03/D05/D06
> Hikey/Hikey960
>
> Could we please try not to leave edk2-platforms behind when making
> changes to the core repository? Thanks.
>
(this is why edk2-platforms should live inside edk2...)
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg
2019-04-24 9:52 ` Laszlo Ersek
@ 2019-04-24 12:46 ` Liming Gao
2019-04-24 12:48 ` Ard Biesheuvel
0 siblings, 1 reply; 27+ messages in thread
From: Liming Gao @ 2019-04-24 12:46 UTC (permalink / raw)
To: Laszlo Ersek, Ard Biesheuvel, Bi, Dandan
Cc: edk2-devel-groups-io, Julien Grall, Leif Lindholm,
Justen, Jordan L, Andrew Fish, Ni, Ray, Wang, Jian J, Wu, Hao A,
Kinney, Michael D, Steele, Kelly, Sun, Zailiang, Qian, Yi
So, we need to consider the combination of edk2 master + edk2-platform master. When do the incompatible change in edk2 master, we need to update edk2-platform master together.
Thanks
Liming
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Wednesday, April 24, 2019 5:53 PM
> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Bi, Dandan <dandan.bi@intel.com>
> Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Julien Grall <julien.grall@arm.com>; Leif Lindholm <leif.lindholm@linaro.org>; Justen,
> Jordan L <jordan.l.justen@intel.com>; Andrew Fish <afish@apple.com>; Gao, Liming <liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Steele, Kelly
> <kelly.steele@intel.com>; Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: Re: [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg
>
> On 04/23/19 18:26, Ard Biesheuvel wrote:
> > On Thu, 4 Apr 2019 at 15:52, Dandan Bi <dandan.bi@intel.com> wrote:
> >>
> >> We will remove IntelFrameworkModulePkg,but BaseUefiTianoCustomDecompressLib in it
> >> may still need to be used. So move BaseUefiTianoCustomDecompressLib from
> >> IntelFrameworkModulePkg to MdeModulePkg firstly.
> >>
> >
> > The following platforms are now broken in edk2-platforms/master since
> > they still refer to BaseUefiTianoCustomDecompressLib in the old
> > location:
> >
> > AMD Overdrive
> > Lemaker Cello
> > Raspberry Pi3
> > SoftIron 1000
> > D03/D05/D06
> > Hikey/Hikey960
> >
> > Could we please try not to leave edk2-platforms behind when making
> > changes to the core repository? Thanks.
> >
>
> (this is why edk2-platforms should live inside edk2...)
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg
2019-04-24 12:46 ` Liming Gao
@ 2019-04-24 12:48 ` Ard Biesheuvel
2019-04-24 13:02 ` Liming Gao
0 siblings, 1 reply; 27+ messages in thread
From: Ard Biesheuvel @ 2019-04-24 12:48 UTC (permalink / raw)
To: Gao, Liming
Cc: Laszlo Ersek, Bi, Dandan, edk2-devel-groups-io, Julien Grall,
Leif Lindholm, Justen, Jordan L, Andrew Fish, Ni, Ray,
Wang, Jian J, Wu, Hao A, Kinney, Michael D, Steele, Kelly,
Sun, Zailiang, Qian, Yi
On Wed, 24 Apr 2019 at 14:46, Gao, Liming <liming.gao@intel.com> wrote:
>
>
> So, we need to consider the combination of edk2 master + edk2-platform master. When do the incompatible change in edk2 master, we need to update edk2-platform master together.
>
Yes, it is either that, or we separate them properly, by pulling core
EDK2 into edk2-platforms as a git submodule. That way, we can update
the upstream commit depended upon instead of assuming that we are
always updated in lockstep.
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg
2019-04-24 12:48 ` Ard Biesheuvel
@ 2019-04-24 13:02 ` Liming Gao
2019-04-24 13:03 ` Ard Biesheuvel
0 siblings, 1 reply; 27+ messages in thread
From: Liming Gao @ 2019-04-24 13:02 UTC (permalink / raw)
To: Ard Biesheuvel
Cc: Laszlo Ersek, Bi, Dandan, edk2-devel-groups-io, Julien Grall,
Leif Lindholm, Justen, Jordan L, Andrew Fish, Ni, Ray,
Wang, Jian J, Wu, Hao A, Kinney, Michael D, Steele, Kelly,
Sun, Zailiang, Qian, Yi
Ard:
I prefer to keep them as the separate repo. One dummy Git repo can be introduced to submodule edk2, edk2-platform, edk2-non-osi, and others. User can use this git repo to get everything.
Thanks
Liming
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Wednesday, April 24, 2019 8:48 PM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>; Bi, Dandan <dandan.bi@intel.com>; edk2-devel-groups-io <devel@edk2.groups.io>; Julien Grall
> <julien.grall@arm.com>; Leif Lindholm <leif.lindholm@linaro.org>; Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Steele, Kelly <kelly.steele@intel.com>; Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi
> <yi.qian@intel.com>
> Subject: Re: [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg
>
> On Wed, 24 Apr 2019 at 14:46, Gao, Liming <liming.gao@intel.com> wrote:
> >
> >
> > So, we need to consider the combination of edk2 master + edk2-platform master. When do the incompatible change in edk2 master, we
> need to update edk2-platform master together.
> >
>
> Yes, it is either that, or we separate them properly, by pulling core
> EDK2 into edk2-platforms as a git submodule. That way, we can update
> the upstream commit depended upon instead of assuming that we are
> always updated in lockstep.
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg
2019-04-24 13:02 ` Liming Gao
@ 2019-04-24 13:03 ` Ard Biesheuvel
2019-04-24 17:23 ` Michael D Kinney
0 siblings, 1 reply; 27+ messages in thread
From: Ard Biesheuvel @ 2019-04-24 13:03 UTC (permalink / raw)
To: Gao, Liming
Cc: Laszlo Ersek, Bi, Dandan, edk2-devel-groups-io, Julien Grall,
Leif Lindholm, Justen, Jordan L, Andrew Fish, Ni, Ray,
Wang, Jian J, Wu, Hao A, Kinney, Michael D, Steele, Kelly,
Sun, Zailiang, Qian, Yi
On Wed, 24 Apr 2019 at 15:02, Gao, Liming <liming.gao@intel.com> wrote:
>
> Ard:
> I prefer to keep them as the separate repo. One dummy Git repo can be introduced to submodule edk2, edk2-platform, edk2-non-osi, and others. User can use this git repo to get everything.
>
That is not really my point.
A git submodule allows you to store *in* the dependent repository
which exact commit in the core repository you depend on. A dummy git
repo does not work the same way.
> > -----Original Message-----
> > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> > Sent: Wednesday, April 24, 2019 8:48 PM
> > To: Gao, Liming <liming.gao@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>; Bi, Dandan <dandan.bi@intel.com>; edk2-devel-groups-io <devel@edk2.groups.io>; Julien Grall
> > <julien.grall@arm.com>; Leif Lindholm <leif.lindholm@linaro.org>; Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> > <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Kinney,
> > Michael D <michael.d.kinney@intel.com>; Steele, Kelly <kelly.steele@intel.com>; Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi
> > <yi.qian@intel.com>
> > Subject: Re: [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg
> >
> > On Wed, 24 Apr 2019 at 14:46, Gao, Liming <liming.gao@intel.com> wrote:
> > >
> > >
> > > So, we need to consider the combination of edk2 master + edk2-platform master. When do the incompatible change in edk2 master, we
> > need to update edk2-platform master together.
> > >
> >
> > Yes, it is either that, or we separate them properly, by pulling core
> > EDK2 into edk2-platforms as a git submodule. That way, we can update
> > the upstream commit depended upon instead of assuming that we are
> > always updated in lockstep.
^ permalink raw reply [flat|nested] 27+ messages in thread
* Re: [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg
2019-04-24 13:03 ` Ard Biesheuvel
@ 2019-04-24 17:23 ` Michael D Kinney
0 siblings, 0 replies; 27+ messages in thread
From: Michael D Kinney @ 2019-04-24 17:23 UTC (permalink / raw)
To: Ard Biesheuvel, Gao, Liming, Kinney, Michael D
Cc: Laszlo Ersek, Bi, Dandan, edk2-devel-groups-io, Julien Grall,
Leif Lindholm, Justen, Jordan L, Andrew Fish, Ni, Ray,
Wang, Jian J, Wu, Hao A, Steele, Kelly, Sun, Zailiang, Qian, Yi
Ard,
Using edk2 and edk2-non-osi as submodules in the edk2-platforms
repo does have some advantages. Each branch in edk2-platforms
can decide which release/tag/sha is required from dependent repos.
This provides a platform focused view of the EDK II project.
If using a release/tag/sha for the dependent repos, the content
is effectively being used as read-only content like we do for
the OpenSSL submodule.
When using the combination of edk2-platforms/master, edk2/master,
and edk2-non-osi/master, if changes are made in submodules, then
there are some additional complexities that the developer needs
to be aware. But this is a workflow that is required to make
sure a change in edk2/master does not break any platforms in
edk2-platforms/master. I think easily discovering a build break
is higher priority.
Thanks,
Mike
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Wednesday, April 24, 2019 6:04 AM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>; Bi, Dandan
> <dandan.bi@intel.com>; edk2-devel-groups-io
> <devel@edk2.groups.io>; Julien Grall
> <julien.grall@arm.com>; Leif Lindholm
> <leif.lindholm@linaro.org>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Andrew Fish
> <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Wang, Jian
> J <jian.j.wang@intel.com>; Wu, Hao A
> <hao.a.wu@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Steele, Kelly
> <kelly.steele@intel.com>; Sun, Zailiang
> <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: Re: [patch 0/7] Move
> BaseUefiTianoCustomDecompressLib from
> IntelFrameworkModulePkg to MdeModulePkg
>
> On Wed, 24 Apr 2019 at 15:02, Gao, Liming
> <liming.gao@intel.com> wrote:
> >
> > Ard:
> > I prefer to keep them as the separate repo. One dummy
> Git repo can be introduced to submodule edk2, edk2-
> platform, edk2-non-osi, and others. User can use this git
> repo to get everything.
> >
>
> That is not really my point.
>
> A git submodule allows you to store *in* the dependent
> repository
> which exact commit in the core repository you depend on.
> A dummy git
> repo does not work the same way.
>
> > > -----Original Message-----
> > > From: Ard Biesheuvel
> [mailto:ard.biesheuvel@linaro.org]
> > > Sent: Wednesday, April 24, 2019 8:48 PM
> > > To: Gao, Liming <liming.gao@intel.com>
> > > Cc: Laszlo Ersek <lersek@redhat.com>; Bi, Dandan
> <dandan.bi@intel.com>; edk2-devel-groups-io
> <devel@edk2.groups.io>; Julien Grall
> > > <julien.grall@arm.com>; Leif Lindholm
> <leif.lindholm@linaro.org>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Andrew Fish
> > > <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Wang,
> Jian J <jian.j.wang@intel.com>; Wu, Hao A
> <hao.a.wu@intel.com>; Kinney,
> > > Michael D <michael.d.kinney@intel.com>; Steele, Kelly
> <kelly.steele@intel.com>; Sun, Zailiang
> <zailiang.sun@intel.com>; Qian, Yi
> > > <yi.qian@intel.com>
> > > Subject: Re: [patch 0/7] Move
> BaseUefiTianoCustomDecompressLib from
> IntelFrameworkModulePkg to MdeModulePkg
> > >
> > > On Wed, 24 Apr 2019 at 14:46, Gao, Liming
> <liming.gao@intel.com> wrote:
> > > >
> > > >
> > > > So, we need to consider the combination of edk2
> master + edk2-platform master. When do the incompatible
> change in edk2 master, we
> > > need to update edk2-platform master together.
> > > >
> > >
> > > Yes, it is either that, or we separate them properly,
> by pulling core
> > > EDK2 into edk2-platforms as a git submodule. That
> way, we can update
> > > the upstream commit depended upon instead of assuming
> that we are
> > > always updated in lockstep.
^ permalink raw reply [flat|nested] 27+ messages in thread
end of thread, other threads:[~2019-04-24 17:23 UTC | newest]
Thread overview: 27+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-04 13:52 [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg dandan.bi
2019-04-04 13:52 ` [patch 1/7] ArmVirtPkg: Update UefiDecompressLib instance Dandan Bi
2019-04-04 14:57 ` Laszlo Ersek
2019-04-05 1:10 ` Dandan Bi
2019-04-04 13:52 ` [patch 2/7] BeagleBoardPkg: " Dandan Bi
2019-04-04 15:26 ` Ard Biesheuvel
2019-04-05 1:03 ` [edk2-devel] " Dandan Bi
2019-04-04 13:52 ` [patch 3/7] EmulatorPkg: " Dandan Bi
2019-04-04 13:52 ` [patch 4/7] MdeModulePkg: Move BaseUefiTianoCustomDecompressLib to Dandan Bi
2019-04-04 14:21 ` [edk2-devel] " Laszlo Ersek
2019-04-05 1:21 ` Dandan Bi
2019-04-04 21:14 ` felixp
2019-04-05 1:00 ` Dandan Bi
2019-04-04 13:52 ` [patch 5/7] Nt32Pkg: Update to use UefiDecompressLib in MdeModulePkg Dandan Bi
2019-04-04 21:21 ` [edk2-devel] " Felix Polyudov
2019-04-05 0:52 ` Dandan Bi
2019-04-04 13:52 ` [patch 6/7] Quark: " Dandan Bi
2019-04-04 13:52 ` [patch 7/7] Vlv2TbltDevicePkg: " Dandan Bi
2019-04-08 3:30 ` Qian, Yi
2019-04-23 16:26 ` [patch 0/7] Move BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg Ard Biesheuvel
2019-04-23 23:13 ` [edk2-devel] " Dandan Bi
2019-04-24 9:52 ` Laszlo Ersek
2019-04-24 12:46 ` Liming Gao
2019-04-24 12:48 ` Ard Biesheuvel
2019-04-24 13:02 ` Liming Gao
2019-04-24 13:03 ` Ard Biesheuvel
2019-04-24 17:23 ` Michael D Kinney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox