From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: dandan.bi@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Tue, 07 May 2019 08:05:40 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 May 2019 08:05:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,442,1549958400"; d="scan'208";a="169228394" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 07 May 2019 08:05:36 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 7 May 2019 08:05:36 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 7 May 2019 08:05:36 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.136]) with mapi id 14.03.0415.000; Tue, 7 May 2019 23:05:33 +0800 From: "Dandan Bi" To: "Carsey, Jaben" , "Gao, Zhichao" , "devel@edk2.groups.io" , "Ni, Ray" , "jwatt@jwatt.org" Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option Thread-Topic: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option Thread-Index: AQHVBAwhkFtEdfFLEEas9zufo13KOqZeIHXAgAE68iD//9qhAIAAi5rA Date: Tue, 7 May 2019 15:05:32 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40BD05FB@SHSMSX104.ccr.corp.intel.com> References: <20190506130257.80722-1-jwatt@jwatt.org> <20190506130257.80722-2-jwatt@jwatt.org> <734D49CCEBEEF84792F5B80ED585239D5C12C3EF@SHSMSX104.ccr.corp.intel.com> <3CE959C139B4C44DBEA1810E3AA6F9000B7D0C0D@SHSMSX101.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: dandan.bi@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Also agree to update Shell Spec to add description for "#" in "-opt" part t= o make it consistent with other options since this patch has updated the co= de behavior to be consistent. For the patch Reviewed-by: Bi Dandan Thanks, Dandan > -----Original Message----- > From: Carsey, Jaben > Sent: Tuesday, May 07, 2019 10:36 PM > To: Gao, Zhichao ; devel@edk2.groups.io; Ni, Ray > ; jwatt@jwatt.org > Cc: Bi, Dandan > Subject: RE: [edk2-devel] [PATCH v1 1/1] > ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option >=20 > Zhichao, > I can help submit errata for shell spec if needed. >=20 > Per patch, > I agree. This looks good. > Reviewed-by: Jaben Carsey >=20 >=20 > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Tuesday, May 07, 2019 2:52 AM > > To: devel@edk2.groups.io; Ni, Ray ; jwatt@jwatt.org > > Cc: Carsey, Jaben ; Bi, Dandan > > > > Subject: RE: [edk2-devel] [PATCH v1 1/1] > > ShellPkg/UefiShellBcfgCommandLib: Fix '-opt' option > > Importance: High > > > > This patch looks good for me. > > Reviewed-by: Zhichao Gao > > > > But when I view the command in UEFI SHELL 2.2 spec: > > ... > > bcfg driver|boot [-opt # [[filename]|["data"]] | [KeyData > UnicodeChar>*]] > > ... > > -opt > > Modify the optional data associated with a driver or boot option. > > Followed either by the filename of the file which contains the binary > > data to be associated with the driver or boot option optional data, or > > else the quote- delimited data that will be associated with the driver > > or boot option optional data. > > ... > > > > This description lack the comment of '#' parameter and that may make > > the consumer confused. Usually consumers would regard it as the same > > in other option, such as ' bcfg driver|boot [rm #]'. The '#' is > > clearly descripted as a hexadecimal parameter: > > rm > > Remove an option. The # parameter lists the option number to remove in > > hexadecimal. > > > > So I think we should update the shell spec by the way. > > > > Thanks, > > Zhichao > > > > > -----Original Message----- > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf > > > Of > > Ni, > > > Ray > > > Sent: Monday, May 6, 2019 10:02 PM > > > To: jwatt@jwatt.org; devel@edk2.groups.io > > > Cc: Carsey, Jaben ; Bi, Dandan > > > > > > Subject: Re: [edk2-devel] [PATCH v1 1/1] > > ShellPkg/UefiShellBcfgCommandLib: > > > Fix '-opt' option > > > > > > Dandan, > > > Can you please help to review? > > > > > > Thanks, > > > Ray > > > > > > > -----Original Message----- > > > > From: jwatt@jwatt.org [mailto:jwatt@jwatt.org] > > > > Sent: Monday, May 6, 2019 9:03 PM > > > > To: devel@edk2.groups.io > > > > Cc: Carsey, Jaben ; Ni, Ray > > > > > > > > Subject: [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-op= t' > > > > option > > > > > > > > From: Jonathan Watt > > > > > > > > For all other bcfg commands the "#" (option number) argument(s) > > > > are treated as hexedecimal values regardless of whether or not > > > > they are prefixed by "0x". This change fixes '-opt' to handle its= "#" > > > > (option number) argument consistently with the other commands. > > > > > > > > Making this change removes a potential footgun whereby a user that > > > > has been using a number without a "0x" prefix with other bcfg > > > > commands finds that, on using that exact same number with '-opt', > > > > it has this time unexpectedly been interpreted as a decimal number > > > > and they have modified > > > > (corrupted) an unrelated load option. For example, a user may > > > > have been specifying "10" to other commands to have them act on > > > > the 16th option (because simply "10", without any prefix, is how > > > > 'bcfg boot dump' displayed the option number for the 16th option). > > > > Unfortunately for them, if they also use '-opt' with "10" it would > > > > unexpectedly and inconsistently act on the 10th option. > > > > > > > > CC: Jaben Carsey > > > > CC: Ray Ni > > > > Signed-off-by: Jonathan Watt > > > > --- > > > > > > > > > ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > > | > > > > 2 > > > > +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git > > > > > > > a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > > > > > > > b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > > > > index d033c7c1dc59..e8b48b4990dd 100644 > > > > --- > > > > > > > a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > > > > +++ > > > > > > > b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c > > > > @@ -1019,7 +1019,7 @@ BcfgAddOpt( > > > > // > > > > // Get the index of the variable we are changing. > > > > // > > > > - Status =3D ShellConvertStringToUint64(Walker, &Intermediate, > > > > FALSE, TRUE); > > > > + Status =3D ShellConvertStringToUint64(Walker, &Intermediate, > > > > + TRUE, TRUE); > > > > if (EFI_ERROR(Status) || (((UINT16)Intermediate) !=3D > > > > Intermediate) > > > > || StrStr(Walker, L" ") =3D=3D NULL || ((UINT16)Intermediate) > > > > > ((UINT16)OrderCount)) { > > > > ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN > > > > (STR_GEN_PARAM_INV), gShellBcfgHiiHandle, L"bcfg", L"Option > Index"); > > > > ShellStatus =3D SHELL_INVALID_PARAMETER; > > > > -- > > > > 2.21.0 > > > > > > > > >=20