From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: dandan.bi@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Wed, 08 May 2019 17:43:18 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2019 17:43:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,448,1549958400"; d="scan'208";a="169808041" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 08 May 2019 17:43:18 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 8 May 2019 17:43:17 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.70]) with mapi id 14.03.0415.000; Thu, 9 May 2019 08:43:16 +0800 From: "Dandan Bi" To: Leif Lindholm CC: "devel@edk2.groups.io" , Ard Biesheuvel , "Kinney, Michael D" Subject: Re: [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance Thread-Topic: [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance Thread-Index: AQHVBcgrKLFqhSJSJEW8S6qZLQvvsKZh87gA Date: Thu, 9 May 2019 00:43:15 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40BD100F@SHSMSX104.ccr.corp.intel.com> References: <20190508020031.28436-1-dandan.bi@intel.com> <20190508180205.qemhakgnhsksk3l3@bivouac.eciton.net> In-Reply-To: <20190508180205.qemhakgnhsksk3l3@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: dandan.bi@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Thursday, May 9, 2019 2:02 AM > To: Bi, Dandan > Cc: devel@edk2.groups.io; Ard Biesheuvel ; > Kinney, Michael D > Subject: Re: [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib > instance >=20 > On Wed, May 08, 2019 at 10:00:24AM +0800, Dandan Bi wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1722 > > > > BaseUefiDecompressLib in MdePkg is the base UEFI decompress Library. > > BaseUefiTianoCustomDecompressLib in MdeModulePkg implements the > base > > UEFI decompress functionality and Tiano decompress functionality. > > > > 1. TIANOCOMPRESSED rule in OverdriveBoard.fdf is not used, so remove > > it. > > 2. Platform doesn't use the TianoCompress, so do not have to use > > BaseUefiTianoCustomDecompressLib, can use the BaseUefiDecompressLib > in > > MdePkg directly. > > 3. A common UefiDecompressLib resolution can apply to all module types > > now. So keep the common one in [LibraryClasses.common] section and > > remove all others. > > > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Cc: Michael D Kinney >=20 > For the series: > Reviewed-by: Leif Lindholm >=20 > Are you happy to push these yourself? Could you help to push them? Since I don't have the push rights. Thanks, Dandan >=20 > Final note - it would be even better if --stat=3D1000 and > --stat-graph-width=3D20 were also used, in accordance with > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-gi= t- > guide-for-edk2-contributors-and-maintainers#contrib-23 > While we have a bug in upstream git that means the cover letter still sho= ws > truncated paths, that resolves the problem for the actual patches. >=20 > Best Regards, >=20 > Leif >=20 > > Dandan Bi (7): > > Platform/AMD: Update UefiDecompressLib instance > > Platform/LeMaker: Update UefiDecompressLib instance > > Platform/RPi3: Update UefiDecompressLib instance > > Platform/SoftIron: Update UefiDecompressLib instance > > Silicon/Hisilicon: Update UefiDecompressLib instance > > Silicon/Armada7k8k: Remove TIANOCOMPRESSED rule > > Platform: Remove TIANOCOMPRESSED rule > > > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 5 ----- > > Platform/AMD/OverdriveBoard/OverdriveBoard.fdf | 9 --------- > > Platform/ARM/SgiPkg/SgiPlatform.fdf | 9 --------- > > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 5 ----- > > Platform/LeMaker/CelloBoard/CelloBoard.fdf | 9 --------- > > Platform/RaspberryPi/RPi3/RPi3.dsc | 3 --- > > Platform/RaspberryPi/RPi3/RPi3.fdf | 9 --------- > > Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 9 --------- > > .../Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.fdf | 9 --------- > > .../SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 5 ----- > > .../SoftIron/Overdrive1000Board/Overdrive1000Board.fdf | 9 --------- > > Silicon/Hisilicon/Hisilicon.dsc.inc | 5 ----- > > Silicon/Hisilicon/Hisilicon.fdf.inc | 9 --------- > > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 - > > Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 9 --------- > > 15 files changed, 105 deletions(-) > > > > -- > > 2.18.0.windows.1 > >