From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: dandan.bi@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Wed, 15 May 2019 08:30:20 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 May 2019 08:30:19 -0700 X-ExtLoop1: 1 Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 15 May 2019 08:30:19 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 15 May 2019 08:30:18 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 15 May 2019 08:30:18 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.136]) with mapi id 14.03.0415.000; Wed, 15 May 2019 23:30:16 +0800 From: "Dandan Bi" To: "devel@edk2.groups.io" , "krzysztof.koch@arm.com" , "Carsey, Jaben" , "Ni, Ray" CC: Sami Mujawar , nd Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation Thread-Topic: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation Thread-Index: AQHUuWkdvH8DmLst5kClxxYBn+yNt6ZjY7xggAiSUwCAAPl/8A== Date: Wed, 15 May 2019 15:30:15 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40BD4110@SHSMSX104.ccr.corp.intel.com> References: <20190131133008.14620-1-krzysztof.koch@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: dandan.bi@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Krzysztof Koch, You patch is good to me. Reviewed-by: Bi Dandan I think maintainers will help push soon if they don't have additional comm= ents. I have just one comments for future patches since this one is small and cl= ear. Could you help file a Bugzilla (if not have one)to track the issue and add= the Bugzilla link into the patch if you submit patch to edk2? Thanks in a= dvance for cooperation and contribution. Thanks, Dandan > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Krzysztof Koch > Sent: Wednesday, May 15, 2019 4:24 PM > To: devel@edk2.groups.io; Carsey, Jaben ; Ni, Ra= y > > Cc: Sami Mujawar ; nd > Subject: Re: [edk2-devel] [PATCH v1 1/1] > ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validati= on >=20 > Hi Jaben and Ray, >=20 > It's been a while since I posted this patch. Can I help you in any way t= o get > this merged? >=20 > Kind regards, >=20 > Krzysztof Koch >=20 > -----Original Message----- > From: Sami Mujawar > Sent: Thursday, May 9, 2019 14:37 > To: devel@edk2.groups.io > Cc: jaben.carsey@intel.com; ray.ni@intel.com; Matteo Carlini > ; Stephanie Hughes-Fitt Fitt@arm.com>; nd ; Krzysztof Koch > > Subject: RE: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix > PPTT cache attributes validation >=20 > Reviewed-by: Sami Mujawar >=20 > Regards, >=20 > Sami Mujawar >=20 > -----Original Message----- > From: Krzysztof Koch > Sent: 31 January 2019 01:30 PM > To: edk2-devel@lists.01.org > Cc: jaben.carsey@intel.com; ray.ni@intel.com; Matteo Carlini > ; Stephanie Hughes-Fitt Fitt@arm.com>; Sami Mujawar ; nd > > Subject: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT > cache attributes validation >=20 > Removed conditional pre-compiling for ARM CPUs because function > ValidateCacheAttributes(..) is based on ACPI PPTT specification. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Krzysztof Koch > Reported-by: Zhichao Gao > --- >=20 > The code can be found at: > https://github.com/KrzysztofKoch1/edk2/tree/woa_422_cache_valid_fix_v1 >=20 > Notes: > v1: > - removed conditional precompilation [Krzysztof] >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c > | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser. > c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser. > c > index > bc56fe9ea1dd9c1e98a6a568d3f9191263bedc90..b6b420890a3494869020ed8bc > c7b791fcf7d70f3 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser. > c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser. > c > @@ -86,11 +86,9 @@ ValidateCacheAttributes ( > IN VOID* Context > ) > { > -#if defined(MDE_CPU_ARM) || defined (MDE_CPU_AARCH64) > // Reference: Advanced Configuration and Power Interface (ACPI) > Specification > // Version 6.2 Errata A, September 2017 > // Table 5-153: Cache Type Structure > - > UINT8 Attributes; > Attributes =3D *(UINT8*)Ptr; >=20 > @@ -102,7 +100,6 @@ ValidateCacheAttributes ( > ); > return; > } > -#endif > } >=20 > /** > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20 >=20 >=20