From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: dandan.bi@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Tue, 30 Jul 2019 18:01:25 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jul 2019 18:01:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,327,1559545200"; d="scan'208";a="347338740" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 30 Jul 2019 18:01:24 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jul 2019 18:01:24 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 30 Jul 2019 18:01:23 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.15]) with mapi id 14.03.0439.000; Wed, 31 Jul 2019 09:01:21 +0800 From: "Dandan Bi" To: "devel@edk2.groups.io" , "Zhang, Shenglei" CC: "Wang, Jian J" , "Wu, Hao A" Subject: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Fix typos and add periods Thread-Topic: [edk2-devel] [PATCH 1/3] MdeModulePkg: Fix typos and add periods Thread-Index: AQHVRrIXjQJWcYncBUyJeqkgA7Opzabj54sg Date: Wed, 31 Jul 2019 01:01:21 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40C3674D@SHSMSX104.ccr.corp.intel.com> References: <20190730083732.1564-1-shenglei.zhang@intel.com> <20190730083732.1564-2-shenglei.zhang@intel.com> In-Reply-To: <20190730083732.1564-2-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: dandan.bi@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Shenglei, How about refine the commit message like below before push the patch? 1. Update @parm to @param in function comments in Presentation.c. 2. Add missing period (.) in some function comments. With this update=20 Reviewed-by: Dandan Bi Thanks, Dandan > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Tuesday, July 30, 2019 4:38 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg: Fix typos and add > periods >=20 > para in Presentation.c is spelled incorrectly. > Add periods in CapsuleLib.h and Presentation.c. >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Shenglei Zhang > --- > MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 4 ++-- > MdeModulePkg/Include/Library/CapsuleLib.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > index 7c36a6f2b7fa..bafee4c61292 100644 > --- a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c > @@ -21,9 +21,9 @@ FORM_DISPLAY_ENGINE_FORM gDisplayFormData; > BOOLEAN mFinishRetrieveCall =3D FALSE; >=20 > /** > - Check whether the ConfigAccess protocol is available > + Check whether the ConfigAccess protocol is available. >=20 > - @parm FormSet FormSet of which the ConfigAcces protocol nee= d to > be checked. > + @param FormSet FormSet of which the ConfigAcces protocol ne= ed to > be checked. >=20 > @retval EFI_SUCCESS The function executed successfully. >=20 > diff --git a/MdeModulePkg/Include/Library/CapsuleLib.h > b/MdeModulePkg/Include/Library/CapsuleLib.h > index 7a5414c80f19..0f4164257619 100644 > --- a/MdeModulePkg/Include/Library/CapsuleLib.h > +++ b/MdeModulePkg/Include/Library/CapsuleLib.h > @@ -101,7 +101,7 @@ CoDCheckCapsuleOnDiskFlag( > ); >=20 > /** > - This routine is called to clear CapsuleOnDisk flags including OsIndic= ations > and BootNext variable > + This routine is called to clear CapsuleOnDisk flags including OsIndic= ations > and BootNext variable. >=20 > @retval EFI_SUCCESS All Capsule On Disk flags are cleared >=20 > -- > 2.18.0.windows.1 >=20 >=20 >=20