* [PATCH 0/3] Fix coding style issues
@ 2019-07-30 8:37 Zhang, Shenglei
2019-07-30 8:37 ` [PATCH 1/3] MdeModulePkg: Fix typos and add periods Zhang, Shenglei
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Zhang, Shenglei @ 2019-07-30 8:37 UTC (permalink / raw)
To: devel
Cc: Hao A Wu, Jiewen Yao, Jian Wang, Chao Zhang, Eric Dong, Ray Ni,
Laszlo Ersek
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian Wang <jian.j.wang@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Shenglei Zhang (3):
MdeModulePkg: Fix typos and add periods
SecurityPkg/FvReportPei: Change HashAlgoId to HashAlgId
UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h
MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 4 ++--
SecurityPkg/FvReportPei/FvReportPei.c | 2 +-
MdeModulePkg/Include/Library/CapsuleLib.h | 2 +-
UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h | 1 -
4 files changed, 4 insertions(+), 5 deletions(-)
--
2.18.0.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 1/3] MdeModulePkg: Fix typos and add periods
2019-07-30 8:37 [PATCH 0/3] Fix coding style issues Zhang, Shenglei
@ 2019-07-30 8:37 ` Zhang, Shenglei
2019-07-30 9:15 ` [edk2-devel] " Wang, Jian J
` (2 more replies)
2019-07-30 8:37 ` [PATCH 2/3] SecurityPkg/FvReportPei: Change HashAlgoId to HashAlgId Zhang, Shenglei
2019-07-30 8:37 ` [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h Zhang, Shenglei
2 siblings, 3 replies; 10+ messages in thread
From: Zhang, Shenglei @ 2019-07-30 8:37 UTC (permalink / raw)
To: devel; +Cc: Jian J Wang, Hao A Wu
para in Presentation.c is spelled incorrectly.
Add periods in CapsuleLib.h and Presentation.c.
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 4 ++--
MdeModulePkg/Include/Library/CapsuleLib.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
index 7c36a6f2b7fa..bafee4c61292 100644
--- a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
+++ b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
@@ -21,9 +21,9 @@ FORM_DISPLAY_ENGINE_FORM gDisplayFormData;
BOOLEAN mFinishRetrieveCall = FALSE;
/**
- Check whether the ConfigAccess protocol is available
+ Check whether the ConfigAccess protocol is available.
- @parm FormSet FormSet of which the ConfigAcces protocol need to be checked.
+ @param FormSet FormSet of which the ConfigAcces protocol need to be checked.
@retval EFI_SUCCESS The function executed successfully.
diff --git a/MdeModulePkg/Include/Library/CapsuleLib.h b/MdeModulePkg/Include/Library/CapsuleLib.h
index 7a5414c80f19..0f4164257619 100644
--- a/MdeModulePkg/Include/Library/CapsuleLib.h
+++ b/MdeModulePkg/Include/Library/CapsuleLib.h
@@ -101,7 +101,7 @@ CoDCheckCapsuleOnDiskFlag(
);
/**
- This routine is called to clear CapsuleOnDisk flags including OsIndications and BootNext variable
+ This routine is called to clear CapsuleOnDisk flags including OsIndications and BootNext variable.
@retval EFI_SUCCESS All Capsule On Disk flags are cleared
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Fix typos and add periods
2019-07-30 8:37 ` [PATCH 1/3] MdeModulePkg: Fix typos and add periods Zhang, Shenglei
@ 2019-07-30 9:15 ` Wang, Jian J
2019-07-30 10:25 ` Philippe Mathieu-Daudé
2019-07-31 1:01 ` Dandan Bi
2 siblings, 0 replies; 10+ messages in thread
From: Wang, Jian J @ 2019-07-30 9:15 UTC (permalink / raw)
To: devel@edk2.groups.io, Zhang, Shenglei; +Cc: Wu, Hao A
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Tuesday, July 30, 2019 4:38 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg: Fix typos and add
> periods
>
> para in Presentation.c is spelled incorrectly.
> Add periods in CapsuleLib.h and Presentation.c.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 4 ++--
> MdeModulePkg/Include/Library/CapsuleLib.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
> b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
> index 7c36a6f2b7fa..bafee4c61292 100644
> --- a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
> +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
> @@ -21,9 +21,9 @@ FORM_DISPLAY_ENGINE_FORM gDisplayFormData;
> BOOLEAN mFinishRetrieveCall = FALSE;
>
> /**
> - Check whether the ConfigAccess protocol is available
> + Check whether the ConfigAccess protocol is available.
>
> - @parm FormSet FormSet of which the ConfigAcces protocol need to
> be checked.
> + @param FormSet FormSet of which the ConfigAcces protocol need
> to be checked.
>
> @retval EFI_SUCCESS The function executed successfully.
>
> diff --git a/MdeModulePkg/Include/Library/CapsuleLib.h
> b/MdeModulePkg/Include/Library/CapsuleLib.h
> index 7a5414c80f19..0f4164257619 100644
> --- a/MdeModulePkg/Include/Library/CapsuleLib.h
> +++ b/MdeModulePkg/Include/Library/CapsuleLib.h
> @@ -101,7 +101,7 @@ CoDCheckCapsuleOnDiskFlag(
> );
>
> /**
> - This routine is called to clear CapsuleOnDisk flags including OsIndications
> and BootNext variable
> + This routine is called to clear CapsuleOnDisk flags including OsIndications
> and BootNext variable.
>
> @retval EFI_SUCCESS All Capsule On Disk flags are cleared
>
> --
> 2.18.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Fix typos and add periods
2019-07-30 8:37 ` [PATCH 1/3] MdeModulePkg: Fix typos and add periods Zhang, Shenglei
2019-07-30 9:15 ` [edk2-devel] " Wang, Jian J
@ 2019-07-30 10:25 ` Philippe Mathieu-Daudé
2019-07-31 1:01 ` Dandan Bi
2 siblings, 0 replies; 10+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-07-30 10:25 UTC (permalink / raw)
To: devel, shenglei.zhang; +Cc: Jian J Wang, Hao A Wu
On 7/30/19 10:37 AM, Zhang, Shenglei wrote:
> para in Presentation.c is spelled incorrectly.
'param'
> Add periods in CapsuleLib.h and Presentation.c.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 4 ++--
> MdeModulePkg/Include/Library/CapsuleLib.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
> index 7c36a6f2b7fa..bafee4c61292 100644
> --- a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
> +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
> @@ -21,9 +21,9 @@ FORM_DISPLAY_ENGINE_FORM gDisplayFormData;
> BOOLEAN mFinishRetrieveCall = FALSE;
>
> /**
> - Check whether the ConfigAccess protocol is available
> + Check whether the ConfigAccess protocol is available.
>
> - @parm FormSet FormSet of which the ConfigAcces protocol need to be checked.
> + @param FormSet FormSet of which the ConfigAcces protocol need to be checked.
>
> @retval EFI_SUCCESS The function executed successfully.
>
> diff --git a/MdeModulePkg/Include/Library/CapsuleLib.h b/MdeModulePkg/Include/Library/CapsuleLib.h
> index 7a5414c80f19..0f4164257619 100644
> --- a/MdeModulePkg/Include/Library/CapsuleLib.h
> +++ b/MdeModulePkg/Include/Library/CapsuleLib.h
> @@ -101,7 +101,7 @@ CoDCheckCapsuleOnDiskFlag(
> );
>
> /**
> - This routine is called to clear CapsuleOnDisk flags including OsIndications and BootNext variable
> + This routine is called to clear CapsuleOnDisk flags including OsIndications and BootNext variable.
>
> @retval EFI_SUCCESS All Capsule On Disk flags are cleared
>
>
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Fix typos and add periods
2019-07-30 8:37 ` [PATCH 1/3] MdeModulePkg: Fix typos and add periods Zhang, Shenglei
2019-07-30 9:15 ` [edk2-devel] " Wang, Jian J
2019-07-30 10:25 ` Philippe Mathieu-Daudé
@ 2019-07-31 1:01 ` Dandan Bi
2 siblings, 0 replies; 10+ messages in thread
From: Dandan Bi @ 2019-07-31 1:01 UTC (permalink / raw)
To: devel@edk2.groups.io, Zhang, Shenglei; +Cc: Wang, Jian J, Wu, Hao A
Hi Shenglei,
How about refine the commit message like below before push the patch?
1. Update @parm to @param in function comments in Presentation.c.
2. Add missing period (.) in some function comments.
With this update
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
Thanks,
Dandan
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Tuesday, July 30, 2019 4:38 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg: Fix typos and add
> periods
>
> para in Presentation.c is spelled incorrectly.
> Add periods in CapsuleLib.h and Presentation.c.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 4 ++--
> MdeModulePkg/Include/Library/CapsuleLib.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
> b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
> index 7c36a6f2b7fa..bafee4c61292 100644
> --- a/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
> +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c
> @@ -21,9 +21,9 @@ FORM_DISPLAY_ENGINE_FORM gDisplayFormData;
> BOOLEAN mFinishRetrieveCall = FALSE;
>
> /**
> - Check whether the ConfigAccess protocol is available
> + Check whether the ConfigAccess protocol is available.
>
> - @parm FormSet FormSet of which the ConfigAcces protocol need to
> be checked.
> + @param FormSet FormSet of which the ConfigAcces protocol need to
> be checked.
>
> @retval EFI_SUCCESS The function executed successfully.
>
> diff --git a/MdeModulePkg/Include/Library/CapsuleLib.h
> b/MdeModulePkg/Include/Library/CapsuleLib.h
> index 7a5414c80f19..0f4164257619 100644
> --- a/MdeModulePkg/Include/Library/CapsuleLib.h
> +++ b/MdeModulePkg/Include/Library/CapsuleLib.h
> @@ -101,7 +101,7 @@ CoDCheckCapsuleOnDiskFlag(
> );
>
> /**
> - This routine is called to clear CapsuleOnDisk flags including OsIndications
> and BootNext variable
> + This routine is called to clear CapsuleOnDisk flags including OsIndications
> and BootNext variable.
>
> @retval EFI_SUCCESS All Capsule On Disk flags are cleared
>
> --
> 2.18.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/3] SecurityPkg/FvReportPei: Change HashAlgoId to HashAlgId
2019-07-30 8:37 [PATCH 0/3] Fix coding style issues Zhang, Shenglei
2019-07-30 8:37 ` [PATCH 1/3] MdeModulePkg: Fix typos and add periods Zhang, Shenglei
@ 2019-07-30 8:37 ` Zhang, Shenglei
2019-07-30 9:12 ` Wang, Jian J
2019-07-30 8:37 ` [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h Zhang, Shenglei
2 siblings, 1 reply; 10+ messages in thread
From: Zhang, Shenglei @ 2019-07-30 8:37 UTC (permalink / raw)
To: devel; +Cc: Jiewen Yao, Jian Wang, Chao Zhang
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian Wang <jian.j.wang@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
SecurityPkg/FvReportPei/FvReportPei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SecurityPkg/FvReportPei/FvReportPei.c b/SecurityPkg/FvReportPei/FvReportPei.c
index c3cf221fa6d8..d24470af6b19 100644
--- a/SecurityPkg/FvReportPei/FvReportPei.c
+++ b/SecurityPkg/FvReportPei/FvReportPei.c
@@ -17,7 +17,7 @@ STATIC CONST HASH_ALG_INFO mHashAlgInfo[] = {
/**
Find hash algorithm information from mHashAlgInfo according to given ID.
- @param[in] HashAlgoId Hash algorithm type id.
+ @param[in] HashAlgId Hash algorithm type id.
@retval Pointer to HASH_ALG_INFO if given hash algorithm is supported.
@retval NULL if given algorithm is not supported.
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/3] SecurityPkg/FvReportPei: Change HashAlgoId to HashAlgId
2019-07-30 8:37 ` [PATCH 2/3] SecurityPkg/FvReportPei: Change HashAlgoId to HashAlgId Zhang, Shenglei
@ 2019-07-30 9:12 ` Wang, Jian J
0 siblings, 0 replies; 10+ messages in thread
From: Wang, Jian J @ 2019-07-30 9:12 UTC (permalink / raw)
To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Yao, Jiewen, Zhang, Chao B
Thanks for the fix.
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Tuesday, July 30, 2019 4:38 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>
> Subject: [PATCH 2/3] SecurityPkg/FvReportPei: Change HashAlgoId to
> HashAlgId
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian Wang <jian.j.wang@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> SecurityPkg/FvReportPei/FvReportPei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/SecurityPkg/FvReportPei/FvReportPei.c
> b/SecurityPkg/FvReportPei/FvReportPei.c
> index c3cf221fa6d8..d24470af6b19 100644
> --- a/SecurityPkg/FvReportPei/FvReportPei.c
> +++ b/SecurityPkg/FvReportPei/FvReportPei.c
> @@ -17,7 +17,7 @@ STATIC CONST HASH_ALG_INFO mHashAlgInfo[] = {
> /**
> Find hash algorithm information from mHashAlgInfo according to given ID.
>
> - @param[in] HashAlgoId Hash algorithm type id.
> + @param[in] HashAlgId Hash algorithm type id.
>
> @retval Pointer to HASH_ALG_INFO if given hash algorithm is supported.
> @retval NULL if given algorithm is not supported.
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h
2019-07-30 8:37 [PATCH 0/3] Fix coding style issues Zhang, Shenglei
2019-07-30 8:37 ` [PATCH 1/3] MdeModulePkg: Fix typos and add periods Zhang, Shenglei
2019-07-30 8:37 ` [PATCH 2/3] SecurityPkg/FvReportPei: Change HashAlgoId to HashAlgId Zhang, Shenglei
@ 2019-07-30 8:37 ` Zhang, Shenglei
2019-07-30 14:11 ` [edk2-devel] " Laszlo Ersek
2 siblings, 1 reply; 10+ messages in thread
From: Zhang, Shenglei @ 2019-07-30 8:37 UTC (permalink / raw)
To: devel; +Cc: Eric Dong, Ray Ni, Laszlo Ersek
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
index e0d823a4b1c6..b95ed8c6f836 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
@@ -24,7 +24,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
@retval EFI_SUCCESS The number of processors was retrieved successfully
@retval EFI_INVALID_PARAMETER NumberOfProcessors is NULL
**/
-
EFI_STATUS
EFIAPI
SmmMpGetNumberOfProcessors (
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h
2019-07-30 8:37 ` [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h Zhang, Shenglei
@ 2019-07-30 14:11 ` Laszlo Ersek
2019-07-31 0:16 ` Dong, Eric
0 siblings, 1 reply; 10+ messages in thread
From: Laszlo Ersek @ 2019-07-30 14:11 UTC (permalink / raw)
To: devel, shenglei.zhang; +Cc: Eric Dong, Ray Ni
On 07/30/19 10:37, Zhang, Shenglei wrote:
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> index e0d823a4b1c6..b95ed8c6f836 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> @@ -24,7 +24,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> @retval EFI_SUCCESS The number of processors was retrieved successfully
> @retval EFI_INVALID_PARAMETER NumberOfProcessors is NULL
> **/
> -
> EFI_STATUS
> EFIAPI
> SmmMpGetNumberOfProcessors (
>
The patch looks good, but I wonder if we should call this empty line "trailing". It is not at the end of the file, and not at the end of a line. Perhaps:
UefiCpuPkg/PiSmmCpuDxeSmm: keep function comment and declaration adjacent
(73 characters).
Anyway, I don't feel too strongly about this. Either way:
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks
Laszlo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h
2019-07-30 14:11 ` [edk2-devel] " Laszlo Ersek
@ 2019-07-31 0:16 ` Dong, Eric
0 siblings, 0 replies; 10+ messages in thread
From: Dong, Eric @ 2019-07-31 0:16 UTC (permalink / raw)
To: devel@edk2.groups.io, lersek@redhat.com, Zhang, Shenglei; +Cc: Ni, Ray
Agree with Laszlo's comments. This info is more precise for the issue. Please update the commit message when you push the change.
With the commit message updated, reviewed-by: Eric Dong <eric.dong@intel.com>
Thanks,
Eric
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, July 30, 2019 10:11 PM
> To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zhang@intel.com>
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm:
> Remove trailing white space in SmmMp.h
>
> On 07/30/19 10:37, Zhang, Shenglei wrote:
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> > UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> > index e0d823a4b1c6..b95ed8c6f836 100644
> > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h
> > @@ -24,7 +24,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> > @retval EFI_SUCCESS The number of processors was retrieved
> successfully
> > @retval EFI_INVALID_PARAMETER NumberOfProcessors is NULL
> > **/
> > -
> > EFI_STATUS
> > EFIAPI
> > SmmMpGetNumberOfProcessors (
> >
>
> The patch looks good, but I wonder if we should call this empty line "trailing".
> It is not at the end of the file, and not at the end of a line. Perhaps:
>
> UefiCpuPkg/PiSmmCpuDxeSmm: keep function comment and declaration
> adjacent
>
> (73 characters).
>
> Anyway, I don't feel too strongly about this. Either way:
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
> Thanks
> Laszlo
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-07-31 1:01 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-30 8:37 [PATCH 0/3] Fix coding style issues Zhang, Shenglei
2019-07-30 8:37 ` [PATCH 1/3] MdeModulePkg: Fix typos and add periods Zhang, Shenglei
2019-07-30 9:15 ` [edk2-devel] " Wang, Jian J
2019-07-30 10:25 ` Philippe Mathieu-Daudé
2019-07-31 1:01 ` Dandan Bi
2019-07-30 8:37 ` [PATCH 2/3] SecurityPkg/FvReportPei: Change HashAlgoId to HashAlgId Zhang, Shenglei
2019-07-30 9:12 ` Wang, Jian J
2019-07-30 8:37 ` [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h Zhang, Shenglei
2019-07-30 14:11 ` [edk2-devel] " Laszlo Ersek
2019-07-31 0:16 ` Dong, Eric
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox