[edk2-core] [PATCH 1/1] MdeModulePkg: errors in UninstallMultipleProtocolInterfaces

[edk2-core] [PATCH 1/1] MdeModulePkg: errors in UninstallMultipleProtocolInterfaces

[Heinrich Schuchardt]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1869

The UEFI spec requires that if any error occurs in
UninstallMultipleProtocolInterfaces(), EFI_INVALID_PARAMETER is returned
and not the return code of UninstallProtocolInterface().

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 MdeModulePkg/Core/Dxe/Hand/Handle.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Core/Dxe/Hand/Handle.c b/MdeModulePkg/Core/Dxe/Hand/Handle.c
index b2721b3ab2..7533b8a2ce 100644
--- a/MdeModulePkg/Core/Dxe/Hand/Handle.c
+++ b/MdeModulePkg/Core/Dxe/Hand/Handle.c
@@ -864,6 +864,7 @@ CoreUninstallMultipleProtocolInterfaces (
       CoreInstallProtocolInterface (&Handle, Protocol, EFI_NATIVE_INTERFACE, Interface);
     }
     VA_END (Args);
+    Status = EFI_INVALID_PARAMETER;
   }
 
   return Status;
-- 
2.20.1

Re: [edk2-devel] [edk2-core] [PATCH 1/1] MdeModulePkg: errors in UninstallMultipleProtocolInterfaces

[Dandan Bi]

Hi,

Thanks for the contribution.

I have two minor comments:
1.  The subject seems make people a little confused, how about update it to something like" MdeModulePkg: Make retval in UninstallMultipleProtocol follow Spec" to make the patch clear?
2. How about update the function comments of UninstallMultipleProtocolInterfaces to add the specific returned status defined in UEFI Spec?

Others are OK to me.

Thanks,
Dandan

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Heinrich Schuchardt
> Sent: Friday, September 6, 2019 4:52 PM
> To: EDK II Development <devel@edk2.groups.io>
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Gao, Liming <liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Laszlo Ersek <lersek@redhat.com>; Jin, Eric
> <eric.jin@intel.com>; Supreeth Venkatesh <supreeth.venkatesh@arm.com>;
> Stephano Cetola <stephano.cetola@linux.intel.com>; Heinrich Schuchardt
> <xypron.glpk@gmx.de>
> Subject: [edk2-devel] [edk2-core] [PATCH 1/1] MdeModulePkg: errors in
> UninstallMultipleProtocolInterfaces
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1869
> 
> The UEFI spec requires that if any error occurs in
> UninstallMultipleProtocolInterfaces(), EFI_INVALID_PARAMETER is returned
> and not the return code of UninstallProtocolInterface().
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  MdeModulePkg/Core/Dxe/Hand/Handle.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MdeModulePkg/Core/Dxe/Hand/Handle.c
> b/MdeModulePkg/Core/Dxe/Hand/Handle.c
> index b2721b3ab2..7533b8a2ce 100644
> --- a/MdeModulePkg/Core/Dxe/Hand/Handle.c
> +++ b/MdeModulePkg/Core/Dxe/Hand/Handle.c
> @@ -864,6 +864,7 @@ CoreUninstallMultipleProtocolInterfaces (
>        CoreInstallProtocolInterface (&Handle, Protocol, EFI_NATIVE_INTERFACE,
> Interface);     }     VA_END (Args);+    Status = EFI_INVALID_PARAMETER;   }
> return Status;--
> 2.20.1
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> 
> View/Reply Online (#46974): https://edk2.groups.io/g/devel/message/46974
> Mute This Topic: https://groups.io/mt/33164398/1768738
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub  [dandan.bi@intel.com]
> -=-=-=-=-=-=