From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: dandan.bi@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Mon, 09 Sep 2019 19:33:53 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2019 19:33:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,487,1559545200"; d="scan'208";a="175168757" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 09 Sep 2019 19:33:51 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 9 Sep 2019 19:33:50 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 9 Sep 2019 19:33:50 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by shsmsx102.ccr.corp.intel.com ([169.254.2.113]) with mapi id 14.03.0439.000; Tue, 10 Sep 2019 10:33:48 +0800 From: "Dandan Bi" To: "devel@edk2.groups.io" , "xypron.glpk@gmx.de" CC: "Wu, Hao A" , "Wang, Jian J" , "Gao, Liming" , "Zeng, Star" , "Yao, Jiewen" , Laszlo Ersek , "Jin, Eric" , Supreeth Venkatesh , Stephano Cetola Subject: Re: [edk2-devel] [edk2-core] [PATCH 1/1] MdeModulePkg: errors in UninstallMultipleProtocolInterfaces Thread-Topic: [edk2-devel] [edk2-core] [PATCH 1/1] MdeModulePkg: errors in UninstallMultipleProtocolInterfaces Thread-Index: AQHVZJCAqtR7qsf2XUajDRCnSDQKmKckNKlw Date: Tue, 10 Sep 2019 02:33:47 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40C5890F@SHSMSX104.ccr.corp.intel.com> References: <20190906085225.26348-1-xypron.glpk@gmx.de> In-Reply-To: <20190906085225.26348-1-xypron.glpk@gmx.de> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: dandan.bi@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Thanks for the contribution. I have two minor comments: 1. The subject seems make people a little confused, how about update it to= something like" MdeModulePkg: Make retval in UninstallMultipleProtocol fol= low Spec" to make the patch clear? 2. How about update the function comments of UninstallMultipleProtocolInter= faces to add the specific returned status defined in UEFI Spec? Others are OK to me. Thanks, Dandan > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Heinrich Schuchardt > Sent: Friday, September 6, 2019 4:52 PM > To: EDK II Development > Cc: Wu, Hao A ; Wang, Jian J ; > Gao, Liming ; Zeng, Star ; Yao= , > Jiewen ; Laszlo Ersek ; Jin, Eri= c > ; Supreeth Venkatesh ; > Stephano Cetola ; Heinrich Schuchardt > > Subject: [edk2-devel] [edk2-core] [PATCH 1/1] MdeModulePkg: errors in > UninstallMultipleProtocolInterfaces >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1869 >=20 > The UEFI spec requires that if any error occurs in > UninstallMultipleProtocolInterfaces(), EFI_INVALID_PARAMETER is returned > and not the return code of UninstallProtocolInterface(). >=20 > Signed-off-by: Heinrich Schuchardt > --- > MdeModulePkg/Core/Dxe/Hand/Handle.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/MdeModulePkg/Core/Dxe/Hand/Handle.c > b/MdeModulePkg/Core/Dxe/Hand/Handle.c > index b2721b3ab2..7533b8a2ce 100644 > --- a/MdeModulePkg/Core/Dxe/Hand/Handle.c > +++ b/MdeModulePkg/Core/Dxe/Hand/Handle.c > @@ -864,6 +864,7 @@ CoreUninstallMultipleProtocolInterfaces ( > CoreInstallProtocolInterface (&Handle, Protocol, EFI_NATIVE_INTERF= ACE, > Interface); } VA_END (Args);+ Status =3D EFI_INVALID_PARAMETER= ; } > return Status;-- > 2.20.1 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#46974): https://edk2.groups.io/g/devel/message/46974 > Mute This Topic: https://groups.io/mt/33164398/1768738 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [dandan.bi@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D