From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: dandan.bi@intel.com)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by groups.io with SMTP; Wed, 18 Sep 2019 18:46:13 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
  by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 18:46:13 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,522,1559545200"; 
   d="scan'208";a="212061914"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
  by fmsmga004.fm.intel.com with ESMTP; 18 Sep 2019 18:46:11 -0700
Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by
 FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 18 Sep 2019 18:46:13 -0700
Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by
 fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 18 Sep 2019 18:46:13 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by
 SHSMSX154.ccr.corp.intel.com ([169.254.7.195]) with mapi id 14.03.0439.000;
 Thu, 19 Sep 2019 09:46:10 +0800
From: "Dandan Bi" <dandan.bi@intel.com>
To: Laszlo Ersek <lersek@redhat.com>, edk2-devel-groups-io
	<devel@edk2.groups.io>
CC: "Dong, Eric" <eric.dong@intel.com>, "Wu, Hao A" <hao.a.wu@intel.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [PATCH 08/35] MdeModulePkg/UefiHiiLib: stop using EFI_HANDLE in place of EFI_HII_HANDLE
Thread-Topic: [PATCH 08/35] MdeModulePkg/UefiHiiLib: stop using EFI_HANDLE
 in place of EFI_HII_HANDLE
Thread-Index: AQHVbZEg+QSESkMZTUyumtMr17MpkacyPLHA
Date: Thu, 19 Sep 2019 01:46:10 +0000
Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40C5D9D0@SHSMSX104.ccr.corp.intel.com>
References: <20190917194935.24322-1-lersek@redhat.com>
 <20190917194935.24322-9-lersek@redhat.com>
In-Reply-To: <20190917194935.24322-9-lersek@redhat.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: dandan.bi@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Dandan Bi <dandan.bi@intel.com>

Thanks,
Dandan
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Wednesday, September 18, 2019 3:49 AM
> To: edk2-devel-groups-io <devel@edk2.groups.io>
> Cc: Bi, Dandan <dandan.bi@intel.com>; Dong, Eric <eric.dong@intel.com>;
> Wu, Hao A <hao.a.wu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>
> Subject: [PATCH 08/35] MdeModulePkg/UefiHiiLib: stop using EFI_HANDLE in
> place of EFI_HII_HANDLE
>=20
> HiiGetHiiHandles() returns an array of EFI_HII_HANDLEs, not EFI_HANDLEs.
> HiiGetString() takes an EFI_HII_HANDLE, not an EFI_HANDLE.
>=20
> This change is a no-op in practice; it's a semantic improvement.
>=20
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>=20
> Notes:
>     lightly tested, as UefiHiiLib is used by both ArmVirt and OVMF
>=20
>  MdeModulePkg/Library/UefiHiiLib/HiiString.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/MdeModulePkg/Library/UefiHiiLib/HiiString.c
> b/MdeModulePkg/Library/UefiHiiLib/HiiString.c
> index 498f245dce1f..95229f8a8c9f 100644
> --- a/MdeModulePkg/Library/UefiHiiLib/HiiString.c
> +++ b/MdeModulePkg/Library/UefiHiiLib/HiiString.c
> @@ -173,8 +173,8 @@ HiiGetPackageString (
>    IN CONST CHAR8     *Language  OPTIONAL
>    )
>  {
> -  EFI_HANDLE  *HiiHandleBuffer;
> -  EFI_HANDLE  HiiHandle;
> +  EFI_HII_HANDLE  *HiiHandleBuffer;
> +  EFI_HII_HANDLE  HiiHandle;
>=20
>    ASSERT (PackageListGuid !=3D NULL);
>=20
> --
> 2.19.1.3.g30247aa5d201
>=20