From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: dandan.bi@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Wed, 18 Sep 2019 18:47:05 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 18:47:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,522,1559545200"; d="scan'208";a="212062061" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 18 Sep 2019 18:47:03 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Sep 2019 18:47:04 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Sep 2019 18:47:03 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.32]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.92]) with mapi id 14.03.0439.000; Thu, 19 Sep 2019 09:47:02 +0800 From: "Dandan Bi" To: Laszlo Ersek , edk2-devel-groups-io CC: "Dong, Eric" , "Wu, Hao A" , "Wang, Jian J" , "Ni, Ray" , "Gao, Zhichao" Subject: Re: [PATCH 12/35] MdeModulePkg: stop abusing EFI_HANDLE for keystroke notify registration Thread-Topic: [PATCH 12/35] MdeModulePkg: stop abusing EFI_HANDLE for keystroke notify registration Thread-Index: AQHVbZEmJVT+3jdBd0q9BKqe46ZRMacyPRZQ Date: Thu, 19 Sep 2019 01:47:02 +0000 Message-ID: <3C0D5C461C9E904E8F62152F6274C0BB40C5D9FE@SHSMSX104.ccr.corp.intel.com> References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-13-lersek@redhat.com> In-Reply-To: <20190917194935.24322-13-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: dandan.bi@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Dandan Bi Thanks, Dandan > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Wednesday, September 18, 2019 3:49 AM > To: edk2-devel-groups-io > Cc: Bi, Dandan ; Dong, Eric ; > Wu, Hao A ; Wang, Jian J ; Ni, > Ray ; Gao, Zhichao > Subject: [PATCH 12/35] MdeModulePkg: stop abusing EFI_HANDLE for > keystroke notify registration >=20 > EFI_REGISTER_KEYSTROKE_NOTIFY and > EFI_UNREGISTER_KEYSTROKE_NOTIFY require the notification handle to > have type (VOID*). The notification handle has nothing to do with the > EFI_HANDLE type. >=20 > This change is a semantic fix; functionally, it's a no-op. >=20 > Cc: Dandan Bi > Cc: Eric Dong > Cc: Hao A Wu > Cc: Jian J Wang > Cc: Ray Ni > Cc: Zhichao Gao > Signed-off-by: Laszlo Ersek > --- >=20 > Notes: > lightly tested: ConSplitterDxe is part of the ArmVirt and OVMF platfo= rms >=20 > MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c | 2 +- > MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > index 63c814ae1816..9c38271b65f9 100644 > --- a/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > +++ b/MdeModulePkg/Universal/Console/ConSplitterDxe/ConSplitter.c > @@ -4026,7 +4026,7 @@ ConSplitterTextInRegisterKeyNotify ( > if (NewNotify =3D=3D NULL) { > return EFI_OUT_OF_RESOURCES; > } > - NewNotify->NotifyHandleList =3D (EFI_HANDLE *) AllocateZeroPool (sizeo= f > (EFI_HANDLE) * Private->TextInExListCount); > + NewNotify->NotifyHandleList =3D (VOID **) AllocateZeroPool (sizeof > + (VOID *) * Private->TextInExListCount); > if (NewNotify->NotifyHandleList =3D=3D NULL) { > gBS->FreePool (NewNotify); > return EFI_OUT_OF_RESOURCES; > diff --git a/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > b/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > index 7cfd5c178861..f98797225b63 100644 > --- a/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > +++ b/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c > @@ -143,7 +143,7 @@ InternalStartMonitor( > EFI_HANDLE *Handles; > UINTN HandleCount; > UINTN HandleIndex; > - EFI_HANDLE NotifyHandle; > + VOID *NotifyHandle; >=20 > Status =3D gBS->LocateHandleBuffer ( > ByProtocol, > @@ -202,7 +202,7 @@ InternalStopMonitor( > EFI_KEY_DATA KeyData; > UINTN HandleCount; > UINTN HandleIndex; > - EFI_HANDLE NotifyHandle; > + VOID *NotifyHandle; >=20 > Status =3D gBS->LocateHandleBuffer ( > ByProtocol, > -- > 2.19.1.3.g30247aa5d201 >=20